From dc2d1c15e013bca5a30b9136216522fc4b6df2c3 Mon Sep 17 00:00:00 2001 From: Justin Wind Date: Sat, 14 Jun 2025 12:39:25 -0700 Subject: [PATCH] tests use stub logger from test-helper --- package-lock.json | 8 +++++++- package.json | 1 + test/src/authenticator.js | 3 ++- test/src/manager.js | 11 ++++------- test/src/service.js | 9 ++------- 5 files changed, 16 insertions(+), 16 deletions(-) diff --git a/package-lock.json b/package-lock.json index e47bc80..9c16057 100644 --- a/package-lock.json +++ b/package-lock.json @@ -19,8 +19,9 @@ }, "devDependencies": { "@squeep/eslint-config": "^1", + "@squeep/test-helper": "git+https://git.squeep.com/squeep-test-helper#v3.0.1", "eslint": "^9", - "husky": "^9.1.7", + "husky": "^9", "mocha": "^11", "nyc": "^17", "sinon": "^21" @@ -1058,6 +1059,11 @@ "node": ">=17" } }, + "node_modules/@squeep/test-helper": { + "version": "3.0.1", + "resolved": "git+https://git.squeep.com/squeep-test-helper#062a2d18088fc8b41a126a0d8dcc3af6723d7bca", + "dev": true + }, "node_modules/@tootallnate/quickjs-emscripten": { "version": "0.23.0", "resolved": "https://registry.npmjs.org/@tootallnate/quickjs-emscripten/-/quickjs-emscripten-0.23.0.tgz", diff --git a/package.json b/package.json index bf6c526..34fe62e 100644 --- a/package.json +++ b/package.json @@ -31,6 +31,7 @@ }, "devDependencies": { "@squeep/eslint-config": "^1", + "@squeep/test-helper": "git+https://git.squeep.com/squeep-test-helper#v3.0.1", "eslint": "^9", "husky": "^9", "mocha": "^11", diff --git a/test/src/authenticator.js b/test/src/authenticator.js index 8d7755e..42629de 100644 --- a/test/src/authenticator.js +++ b/test/src/authenticator.js @@ -1,5 +1,6 @@ 'use strict'; +const { StubLogger } = require('@squeep/test-helper'); const assert = require('node:assert'); const sinon = require('sinon'); @@ -13,7 +14,7 @@ describe('Authenticator', function () { let authenticator, logger, db, options; beforeEach(function () { - logger = { debug: () => {} }; + logger = new StubLogger(sinon); db = { context: async (fn) => fn({}), getAuthById: async () => {}, diff --git a/test/src/manager.js b/test/src/manager.js index c25d4e5..1607a19 100644 --- a/test/src/manager.js +++ b/test/src/manager.js @@ -1,5 +1,6 @@ 'use strict'; +const { StubLogger } = require('@squeep/test-helper'); const assert = require('node:assert'); const sinon = require('sinon'); @@ -11,15 +12,11 @@ const { ServeStaticFile, SlugGeneratorExhausted } = require('../../src/errors'); const noExpectedException = 'did not get expected exception'; describe('Manager', function () { - let manager, options; + let manager, logger, options; let res, ctx; beforeEach(function () { - const stubLogger = { - debug: sinon.stub(), - error: sinon.stub(), - info: sinon.stub(), - }; + logger = new StubLogger(sinon); const stubDb = { context: async (fn) => await fn({}), transaction: async (_dbCtx, fn) => await fn({}), @@ -38,7 +35,7 @@ describe('Manager', function () { ctx = { params: {}, }; - manager = new Manager(stubLogger, stubDb, options); + manager = new Manager(logger, stubDb, options); }); afterEach(function () { diff --git a/test/src/service.js b/test/src/service.js index c19984e..eee860f 100644 --- a/test/src/service.js +++ b/test/src/service.js @@ -1,5 +1,6 @@ 'use strict'; +const { StubLogger } = require('@squeep/test-helper'); const assert = require('node:assert'); const sinon = require('sinon'); @@ -14,13 +15,7 @@ describe('service', function () { beforeEach(function () { options = {}; - logger = process.env['VERBOSE_TESTS'] ? console : { - debug: () => undefined, - warn: () => undefined, - info: () => undefined, - error: () => undefined, - log: () => undefined, - }; + logger = new StubLogger(sinon); asyncLocalStorage = { getStore: () => ({}), }; -- 2.49.0