From: Egor Kislitsyn <egor@kislitsyn.com>
Date: Mon, 22 Apr 2019 06:08:30 +0000 (+0700)
Subject: Merge remote-tracking branch 'pleroma/develop' into feature/disable-account
X-Git-Url: https://git.squeep.com/?a=commitdiff_plain;h=e8c2f9a73a37636a9a8ed5c2998617b841f482da;p=akkoma

Merge remote-tracking branch 'pleroma/develop' into feature/disable-account
---

e8c2f9a73a37636a9a8ed5c2998617b841f482da
diff --cc lib/pleroma/activity.ex
index d06fd917d,4a2ded518..9c1c804e0
--- a/lib/pleroma/activity.ex
+++ b/lib/pleroma/activity.ex
@@@ -249,60 -260,4 +264,14 @@@ defmodule Pleroma.Activity d
      |> where([s], s.actor == ^actor)
      |> Repo.all()
    end
 +
-   def increase_replies_count(id) do
-     Activity
-     |> where(id: ^id)
-     |> update([a],
-       set: [
-         data:
-           fragment(
-             """
-             jsonb_set(?, '{object, repliesCount}',
-               (coalesce((?->'object'->>'repliesCount')::int, 0) + 1)::varchar::jsonb, true)
-             """,
-             a.data,
-             a.data
-           )
-       ]
-     )
-     |> Repo.update_all([])
-     |> case do
-       {1, [activity]} -> activity
-       _ -> {:error, "Not found"}
-     end
-   end
- 
-   def decrease_replies_count(id) do
-     Activity
-     |> where(id: ^id)
-     |> update([a],
-       set: [
-         data:
-           fragment(
-             """
-             jsonb_set(?, '{object, repliesCount}',
-               (greatest(0, (?->'object'->>'repliesCount')::int - 1))::varchar::jsonb, true)
-             """,
-             a.data,
-             a.data
-           )
-       ]
-     )
-     |> Repo.update_all([])
-     |> case do
-       {1, [activity]} -> activity
-       _ -> {:error, "Not found"}
-     end
-   end
- 
 +  def restrict_deactivated_users(query) do
 +    from(activity in query,
 +      where:
 +        fragment(
 +          "? not in (SELECT ap_id FROM users WHERE info->'deactivated' @> 'true')",
 +          activity.actor
 +        )
 +    )
 +  end
  end
diff --cc test/user_test.exs
index ac1675d0f,eee6881eb..a5f931853
--- a/test/user_test.exs
+++ b/test/user_test.exs
@@@ -5,10 -5,9 +5,10 @@@
  defmodule Pleroma.UserTest do
    alias Pleroma.Activity
    alias Pleroma.Builders.UserBuilder
-   alias Pleroma.Notification
+   alias Pleroma.Object
    alias Pleroma.Repo
    alias Pleroma.User
 +  alias Pleroma.Web.ActivityPub.ActivityPub
    alias Pleroma.Web.CommonAPI
  
    use Pleroma.DataCase
@@@ -817,71 -816,13 +817,71 @@@
      assert addressed in recipients
    end
  
 -  test ".deactivate can de-activate then re-activate a user" do
 -    user = insert(:user)
 -    assert false == user.info.deactivated
 -    {:ok, user} = User.deactivate(user)
 -    assert true == user.info.deactivated
 -    {:ok, user} = User.deactivate(user, false)
 -    assert false == user.info.deactivated
 +  describe ".deactivate" do
 +    test "can de-activate then re-activate a user" do
 +      user = insert(:user)
 +      assert false == user.info.deactivated
 +      {:ok, user} = User.deactivate(user)
 +      assert true == user.info.deactivated
 +      {:ok, user} = User.deactivate(user, false)
 +      assert false == user.info.deactivated
 +    end
 +
 +    test "hide a user from followers " do
 +      user = insert(:user)
 +      user2 = insert(:user)
 +
 +      {:ok, user} = User.follow(user, user2)
 +      {:ok, _user} = User.deactivate(user)
 +
 +      info = User.get_cached_user_info(user2)
 +
 +      assert info.follower_count == 0
 +      assert {:ok, []} = User.get_followers(user2)
 +    end
 +
 +    test "hide a user from friends" do
 +      user = insert(:user)
 +      user2 = insert(:user)
 +
 +      {:ok, user2} = User.follow(user2, user)
 +      assert User.following_count(user2) == 1
 +
 +      {:ok, _user} = User.deactivate(user)
 +
 +      info = User.get_cached_user_info(user2)
 +
 +      assert info.following_count == 0
 +      assert User.following_count(user2) == 0
 +      assert {:ok, []} = User.get_friends(user2)
 +    end
 +
 +    test "hide a user's statuses from timelines and notifications" do
 +      user = insert(:user)
 +      user2 = insert(:user)
 +
 +      {:ok, user2} = User.follow(user2, user)
 +
 +      {:ok, activity} = CommonAPI.post(user, %{"status" => "hey @#{user2.nickname}"})
 +
-       [notification] = Notification.for_user(user2)
-       assert notification.activity == activity
++      [notification] = Pleroma.Notification.for_user(user2)
++      assert notification.activity.id == activity.id
 +
 +      assert [activity] == ActivityPub.fetch_public_activities(%{})
 +
 +      assert [activity] ==
 +               ActivityPub.fetch_activities([user2.ap_id | user2.following], %{"user" => user2})
 +               |> ActivityPub.contain_timeline(user2)
 +
 +      {:ok, _user} = User.deactivate(user)
 +
 +      assert [] == ActivityPub.fetch_public_activities(%{})
-       assert [] == Notification.for_user(user2)
++      assert [] == Pleroma.Notification.for_user(user2)
 +
 +      assert [] ==
 +               ActivityPub.fetch_activities([user2.ap_id | user2.following], %{"user" => user2})
 +               |> ActivityPub.contain_timeline(user2)
 +    end
    end
  
    test ".delete_user_activities deletes all create activities" do