From: Ekaterina Vaartis <vaartis@kotobank.ch>
Date: Sat, 22 Jan 2022 13:52:06 +0000 (+0300)
Subject: Don't try removing deleted users and such from index as posts
X-Git-Url: https://git.squeep.com/?a=commitdiff_plain;h=7f53aa400b45ee3d3621049d91b0d083cfba7287;p=akkoma

Don't try removing deleted users and such from index as posts
---

diff --git a/lib/pleroma/search.ex b/lib/pleroma/search.ex
index af858fc46..3b266e59b 100644
--- a/lib/pleroma/search.ex
+++ b/lib/pleroma/search.ex
@@ -1,12 +1,12 @@
 defmodule Pleroma.Search do
   alias Pleroma.Workers.SearchIndexingWorker
 
-  def add_to_index(activity) do
-    SearchIndexingWorker.enqueue("add_to_index", %{"activity" => activity.id})
+  def add_to_index(%Pleroma.Activity{id: activity_id}) do
+    SearchIndexingWorker.enqueue("add_to_index", %{"activity" => activity_id})
   end
 
-  def remove_from_index(object) do
-    SearchIndexingWorker.enqueue("remove_from_index", %{"object" => object.id})
+  def remove_from_index(%Pleroma.Object{id: object_id}) do
+    SearchIndexingWorker.enqueue("remove_from_index", %{"object" => object_id})
   end
 
   def search(query, options) do
diff --git a/lib/pleroma/web/activity_pub/side_effects.ex b/lib/pleroma/web/activity_pub/side_effects.ex
index 097afa30e..517dd0a4f 100644
--- a/lib/pleroma/web/activity_pub/side_effects.ex
+++ b/lib/pleroma/web/activity_pub/side_effects.ex
@@ -325,7 +325,10 @@ defmodule Pleroma.Web.ActivityPub.SideEffects do
     if result == :ok do
       Notification.create_notifications(object)
 
-      Pleroma.Search.remove_from_index(deleted_object)
+      # Only remove from index when deleting actual objects, not users or anything else
+      with %Pleroma.Object{} <- deleted_object do
+        Pleroma.Search.remove_from_index(deleted_object)
+      end
 
       {:ok, object, meta}
     else