From: lain <lain@soykaf.club>
Date: Wed, 27 May 2020 07:46:12 +0000 (+0200)
Subject: ActivityPub: Change ordering to `nulls last` in favorites query
X-Git-Url: https://git.squeep.com/?a=commitdiff_plain;h=7e13200869a41647f25bdcf416ecd36ff09219bc;p=akkoma

ActivityPub: Change ordering to `nulls last` in favorites query

This makes it use our existing index and speeds up the query.
---

diff --git a/lib/pleroma/web/activity_pub/activity_pub.ex b/lib/pleroma/web/activity_pub/activity_pub.ex
index 0fe71694a..b8a2873d8 100644
--- a/lib/pleroma/web/activity_pub/activity_pub.ex
+++ b/lib/pleroma/web/activity_pub/activity_pub.ex
@@ -1158,7 +1158,7 @@ defmodule Pleroma.Web.ActivityPub.ActivityPub do
     |> Activity.with_joined_object()
     |> Object.with_joined_activity()
     |> select([_like, object, activity], %{activity | object: object})
-    |> order_by([like, _, _], desc: like.id)
+    |> order_by([like, _, _], desc_nulls_last: like.id)
     |> Pagination.fetch_paginated(
       Map.merge(params, %{"skip_order" => true}),
       pagination,