From: William Pitcock <nenolod@dereferenced.org>
Date: Sat, 17 Nov 2018 16:05:41 +0000 (+0000)
Subject: activitypub: transmogrifier: fix up to/cc addressing brain damage caused by mastodon... 
X-Git-Url: https://git.squeep.com/?a=commitdiff_plain;h=681f40ee5c4de644c79f71bb6671c4c63b18e68a;p=akkoma

activitypub: transmogrifier: fix up to/cc addressing brain damage caused by mastodon-style explicit DMs
---

diff --git a/lib/pleroma/web/activity_pub/transmogrifier.ex b/lib/pleroma/web/activity_pub/transmogrifier.ex
index fa3abe3d8..e9a801cf5 100644
--- a/lib/pleroma/web/activity_pub/transmogrifier.ex
+++ b/lib/pleroma/web/activity_pub/transmogrifier.ex
@@ -93,12 +93,42 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
     end
   end
 
-  def fix_addressing(map) do
-    map
-    |> fix_addressing_list("to")
-    |> fix_addressing_list("cc")
-    |> fix_addressing_list("bto")
-    |> fix_addressing_list("bcc")
+  def fix_explicit_addressing(%{"to" => to, "cc" => cc} = object, explicit_mentions) do
+    explicit_to =
+      to
+      |> Enum.filter(fn x -> x in explicit_mentions end)
+
+    explicit_cc =
+      to
+      |> Enum.filter(fn x -> x not in explicit_mentions end)
+
+    final_cc =
+      (cc ++ explicit_cc)
+      |> Enum.uniq()
+
+    object
+    |> Map.put("to", explicit_to)
+    |> Map.put("cc", final_cc)
+  end
+
+  def fix_explicit_addressing(object, _explicit_mentions), do: object
+
+  def fix_addressing(object) do
+    object =
+      object
+      |> fix_addressing_list("to")
+      |> fix_addressing_list("cc")
+      |> fix_addressing_list("bto")
+      |> fix_addressing_list("bcc")
+
+    explicit_mentions =
+      object
+      |> Utils.determine_explicit_mentions()
+
+    explicit_mentions = explicit_mentions ++ ["https://www.w3.org/ns/activitystreams#Public"]
+
+    object
+    |> fix_explicit_addressing(explicit_mentions)
   end
 
   def fix_actor(%{"attributedTo" => actor} = object) do