From: Mark Felder <feld@FreeBSD.org>
Date: Mon, 6 Jul 2020 15:59:41 +0000 (-0500)
Subject: Simplify the logic
X-Git-Url: https://git.squeep.com/?a=commitdiff_plain;h=65843d92c4d3999f727d00500dcf8943cfe7bbc0;p=akkoma

Simplify the logic
---

diff --git a/lib/pleroma/plugs/http_security_plug.ex b/lib/pleroma/plugs/http_security_plug.ex
index 3bf0b8ce7..13423ca3f 100644
--- a/lib/pleroma/plugs/http_security_plug.ex
+++ b/lib/pleroma/plugs/http_security_plug.ex
@@ -114,24 +114,15 @@ defmodule Pleroma.Plugs.HTTPSecurityPlug do
         add_source(acc, host)
       end)
 
-    media_proxy_base_url =
-      if Config.get([:media_proxy, :base_url]),
-        do: build_csp_param(Config.get([:media_proxy, :base_url]))
+    media_proxy_base_url = build_csp_param(Config.get([:media_proxy, :base_url]))
 
-    upload_base_url =
-      if Config.get([Pleroma.Upload, :base_url]),
-        do: build_csp_param(Config.get([Pleroma.Upload, :base_url]))
+    upload_base_url = build_csp_param(Config.get([Pleroma.Upload, :base_url]))
 
-    s3_endpoint =
-      if Config.get([Pleroma.Upload, :uploader]) == Pleroma.Uploaders.S3,
-        do: build_csp_param(Config.get([Pleroma.Uploaders.S3, :public_endpoint]))
+    s3_endpoint = build_csp_param(Config.get([Pleroma.Uploaders.S3, :public_endpoint]))
 
     captcha_method = Config.get([Pleroma.Captcha, :method])
 
-    captcha_endpoint =
-      if Config.get([Pleroma.Captcha, :enabled]) &&
-           captcha_method != "Pleroma.Captcha.Native",
-         do: build_csp_param(Config.get([captcha_method, :endpoint]))
+    captcha_endpoint = build_csp_param(Config.get([captcha_method, :endpoint]))
 
     []
     |> add_source(media_proxy_base_url)
@@ -148,6 +139,8 @@ defmodule Pleroma.Plugs.HTTPSecurityPlug do
 
   defp add_csp_param(csp_iodata, param), do: [[param, ?;] | csp_iodata]
 
+  defp build_csp_param(nil), do: nil
+
   defp build_csp_param(url) when is_binary(url) do
     %{host: host, scheme: scheme} = URI.parse(url)