From: FloatingGhost <hannah@coffee-and-dreams.uk>
Date: Sat, 26 Nov 2022 21:15:10 +0000 (+0000)
Subject: weirdly no, images should not have classes
X-Git-Url: https://git.squeep.com/?a=commitdiff_plain;h=5bb95256ee2cd0609b6c821820f165a9e6b6c57f;p=akkoma

weirdly no, images should not have classes
---

diff --git a/priv/scrubbers/default.ex b/priv/scrubbers/default.ex
index 950b6c21e..771f27ac1 100644
--- a/priv/scrubbers/default.ex
+++ b/priv/scrubbers/default.ex
@@ -98,7 +98,6 @@ defmodule Pleroma.HTML.Scrubber.Default do
     Meta.allow_tag_with_these_attributes(:img, [
       "width",
       "height",
-      "class",
       "title",
       "alt"
     ])
diff --git a/test/pleroma/web/activity_pub/mrf/normalize_markup_test.exs b/test/pleroma/web/activity_pub/mrf/normalize_markup_test.exs
index 133485a86..739d9b49c 100644
--- a/test/pleroma/web/activity_pub/mrf/normalize_markup_test.exs
+++ b/test/pleroma/web/activity_pub/mrf/normalize_markup_test.exs
@@ -16,6 +16,7 @@ defmodule Pleroma.Web.ActivityPub.MRF.NormalizeMarkupTest do
   this is an image: <img src="http://example.com/image.jpg"><br />
   <script>alert('hacked')</script>
   <div class="wow no classes here">mean</div>
+  <img class="hehe" src="somewhere" />
   """
 
   @expected """
@@ -27,6 +28,7 @@ defmodule Pleroma.Web.ActivityPub.MRF.NormalizeMarkupTest do
   this is an image: <img src="http://example.com/image.jpg"/><br/>
   alert(&#39;hacked&#39;)
   mean
+  <img src="somewhere"/>
   """
 
   test "it filter html tags" do