From: Egor Kislitsyn <egor@kislitsyn.com>
Date: Mon, 2 Mar 2020 11:35:49 +0000 (+0400)
Subject: Merge branch 'develop' into fix/signup-without-email
X-Git-Url: https://git.squeep.com/?a=commitdiff_plain;h=4a45b96a91485a39f26bcc86b6cbd21d1547511e;p=akkoma

Merge branch 'develop' into fix/signup-without-email
---

4a45b96a91485a39f26bcc86b6cbd21d1547511e
diff --cc test/web/mastodon_api/controllers/account_controller_test.exs
index ff7cb88d1,57d0f4416..7f7d8cea3
--- a/test/web/mastodon_api/controllers/account_controller_test.exs
+++ b/test/web/mastodon_api/controllers/account_controller_test.exs
@@@ -745,52 -697,6 +699,54 @@@ defmodule Pleroma.Web.MastodonAPI.Accou
        end)
      end
  
++    clear_config([:instance, :account_activation_required])
++
 +    test "returns bad_request if missing email params when :account_activation_required is enabled",
 +         %{conn: conn, valid_params: valid_params} do
 +      Pleroma.Config.put([:instance, :account_activation_required], true)
 +
 +      app_token = insert(:oauth_token, user: nil)
 +      conn = put_req_header(conn, "authorization", "Bearer " <> app_token.token)
 +
 +      res =
 +        conn
 +        |> Map.put(:remote_ip, {127, 0, 0, 5})
 +        |> post("/api/v1/accounts", Map.delete(valid_params, :email))
 +
 +      assert json_response(res, 400) == %{"error" => "Missing parameters"}
 +
 +      res =
 +        conn
 +        |> Map.put(:remote_ip, {127, 0, 0, 6})
 +        |> post("/api/v1/accounts", Map.put(valid_params, :email, ""))
 +
 +      assert json_response(res, 400) == %{"error" => "{\"email\":[\"can't be blank\"]}"}
 +    end
 +
 +    test "allow registration without an email", %{conn: conn, valid_params: valid_params} do
 +      app_token = insert(:oauth_token, user: nil)
 +      conn = put_req_header(conn, "authorization", "Bearer " <> app_token.token)
 +
 +      res =
 +        conn
 +        |> Map.put(:remote_ip, {127, 0, 0, 7})
 +        |> post("/api/v1/accounts", Map.delete(valid_params, :email))
 +
 +      assert json_response(res, 200)
 +    end
 +
 +    test "allow registration with an empty email", %{conn: conn, valid_params: valid_params} do
 +      app_token = insert(:oauth_token, user: nil)
 +      conn = put_req_header(conn, "authorization", "Bearer " <> app_token.token)
 +
 +      res =
 +        conn
 +        |> Map.put(:remote_ip, {127, 0, 0, 8})
 +        |> post("/api/v1/accounts", Map.put(valid_params, :email, ""))
 +
 +      assert json_response(res, 200)
 +    end
 +
      test "returns forbidden if token is invalid", %{conn: conn, valid_params: valid_params} do
        conn = put_req_header(conn, "authorization", "Bearer " <> "invalid-token")