From: William Pitcock <nenolod@dereferenced.org>
Date: Tue, 19 Jun 2018 00:36:40 +0000 (+0000)
Subject: user: when processing a block in User.block(), ensure all follow relationships are... 
X-Git-Url: https://git.squeep.com/?a=commitdiff_plain;h=320ca7b11e163d059a3f181e2d6eb5ea300f5b55;p=akkoma

user: when processing a block in User.block(), ensure all follow relationships are broken

this is needed for activitypub conformance

ref #213
---

diff --git a/lib/pleroma/user.ex b/lib/pleroma/user.ex
index b27397e13..bfa5d78a4 100644
--- a/lib/pleroma/user.ex
+++ b/lib/pleroma/user.ex
@@ -505,12 +505,25 @@ defmodule Pleroma.User do
     Repo.all(q)
   end
 
-  def block(user, %{ap_id: ap_id}) do
-    blocks = user.info["blocks"] || []
+  def block(blocker, %User{ap_id: ap_id} = blocked) do
+    # sever any follow relationships to prevent leaks per activitypub (Pleroma issue #213)
+    blocker =
+      if following?(blocker, blocked) do
+        {:ok, blocker, _} = unfollow(blocker, blocked)
+        blocker
+      else
+        blocker
+      end
+
+    if following?(blocked, blocker) do
+      unfollow(blocked, blocker)
+    end
+
+    blocks = blocker.info["blocks"] || []
     new_blocks = Enum.uniq([ap_id | blocks])
-    new_info = Map.put(user.info, "blocks", new_blocks)
+    new_info = Map.put(blocker.info, "blocks", new_blocks)
 
-    cs = User.info_changeset(user, %{info: new_info})
+    cs = User.info_changeset(blocker, %{info: new_info})
     update_and_set_cache(cs)
   end