From: William Pitcock <nenolod@dereferenced.org>
Date: Sat, 23 Mar 2019 00:09:56 +0000 (+0000)
Subject: activity: add with_preloaded_object() convenience
X-Git-Url: https://git.squeep.com/?a=commitdiff_plain;h=092cedede507b3e89134deb6f5d09c5db339dfae;p=akkoma

activity: add with_preloaded_object() convenience
---

diff --git a/lib/pleroma/activity.ex b/lib/pleroma/activity.ex
index 2f91b3c77..370721070 100644
--- a/lib/pleroma/activity.ex
+++ b/lib/pleroma/activity.ex
@@ -44,11 +44,29 @@ defmodule Pleroma.Activity do
     #    fragment("(?->>'id') = COALESCE((? -> 'object'::text) ->> 'id'::text)", o.data, activity.data))
     # |> preload([activity, object], [object: object])
     # ```
+    #
+    # As a convenience, Activity.with_preloaded_object() sets up an inner join and preload for the
+    # typical case.
     has_one(:object, Object, on_delete: :nothing, foreign_key: :id)
 
     timestamps()
   end
 
+  def with_preloaded_object(query) do
+    query
+    |> join(
+      :inner,
+      [activity],
+      o in Object,
+      fragment(
+        "(?->>'id') = COALESCE((? -> 'object'::text) ->> 'id'::text)",
+        o.data,
+        activity.data
+      )
+    )
+    |> preload([activity, object], object: object)
+  end
+
   def get_by_ap_id(ap_id) do
     Repo.one(
       from(