Fix eratic test for POST /api/pleroma/admin/reports/:id/notes
authorIlja <ilja@ilja.space>
Tue, 5 Apr 2022 11:21:09 +0000 (13:21 +0200)
committerFloatingGhost <hannah@coffee-and-dreams.uk>
Wed, 29 Jun 2022 19:47:10 +0000 (20:47 +0100)
It retrieved two ReportNotes and then checked one of them. But the order isn't guaranteed, while the test tested on the content of the first ReportNote.

I made the test on the content more generic

test/pleroma/web/admin_api/controllers/report_controller_test.exs

index 642b05f3f7623e3f0fe651b636801a771bd8b7cc..2d526527b2ee8967730b813e80578484b4efd5f8 100644 (file)
@@ -369,7 +369,8 @@ defmodule Pleroma.Web.AdminAPI.ReportControllerTest do
       refute is_nil(note)
 
       assert note["user"]["nickname"] == admin.nickname
-      assert note["content"] == "this is disgusting!"
+      # We use '=~' because the order of the notes isn't guaranteed
+      assert note["content"] =~ "this is disgusting"
       assert note["created_at"]
       assert response["total"] == 1
     end