Handle cases where we don't get lease_seconds returned.
authorRoger Braun <roger@rogerbraun.net>
Wed, 10 May 2017 17:04:27 +0000 (19:04 +0200)
committerRoger Braun <roger@rogerbraun.net>
Wed, 10 May 2017 17:04:27 +0000 (19:04 +0200)
lib/pleroma/web/websub/websub_controller.ex

index 9d3c1cd01b1061a47fae9a43994305d4be6f7397..c47c820bc93475493f8f0a71397b3172bc8ce311 100644 (file)
@@ -19,9 +19,16 @@ defmodule Pleroma.Web.Websub.WebsubController do
   end
 
   # TODO: Extract this into the Websub module
-  def websub_subscription_confirmation(conn, %{"id" => id, "hub.mode" => "subscribe", "hub.challenge" => challenge, "hub.topic" => topic, "hub.lease_seconds" => lease_seconds}) do
+  def websub_subscription_confirmation(conn, %{"id" => id, "hub.mode" => "subscribe", "hub.challenge" => challenge, "hub.topic" => topic} = params) do
+    lease_seconds = if params["hub.lease_seconds"] do
+      String.to_integer(params["hub.lease_seconds"])
+    else
+      # Guess 3 days
+      60 * 24 * 3
+    end
+
     with %WebsubClientSubscription{} = websub <- Repo.get_by(WebsubClientSubscription, id: id, topic: topic) do
-      valid_until = NaiveDateTime.add(NaiveDateTime.utc_now, String.to_integer(lease_seconds))
+      valid_until = NaiveDateTime.add(NaiveDateTime.utc_now, lease_seconds)
       change = Ecto.Changeset.change(websub, %{state: "accepted", valid_until: valid_until})
       {:ok, _websub} = Repo.update(change)
       conn