Merge branch 'fix/mediaproxy-too-brutal' into 'develop'
authorrinpatch <rinpatch@sdf.org>
Sat, 12 Oct 2019 14:42:55 +0000 (14:42 +0000)
committerrinpatch <rinpatch@sdf.org>
Sat, 12 Oct 2019 14:43:20 +0000 (14:43 +0000)
Make MediaProxy failure tracking less brutal

See merge request pleroma/pleroma!1836

(cherry picked from commit 930cbd6d05653033e9f6d16960d698f5db4ae624)

9bdbf081 Make MediaProxy failure tracking less brutal

lib/pleroma/reverse_proxy/reverse_proxy.ex

index 78144cae31400f82969c4bec9df08253570ef5d2..2ed7193150729b906f1f50ee5fffc9c98e7130e5 100644 (file)
@@ -401,11 +401,9 @@ defmodule Pleroma.ReverseProxy do
 
   defp client, do: Pleroma.ReverseProxy.Client
 
-  defp track_failed_url(url, code, opts) do
-    code = to_string(code)
-
+  defp track_failed_url(url, error, opts) do
     ttl =
-      if code in ["403", "404"] or String.starts_with?(code, "5") do
+      unless error in [:body_too_large, 400, 204] do
         Keyword.get(opts, :failed_request_ttl, @failed_request_ttl)
       else
         nil