Fix never matching clause

`length/1` is only used with lists.

diff --git a/lib/pleroma/clippy.ex b/lib/pleroma/clippy.ex
index bd20952a6952a4c6ee130b620097bd23bb66ae99..6e6121d4e5f958f5d117dfb3b94451bbb7c28ae6 100644 (file)
--- a/lib/pleroma/clippy.ex
+++ b/lib/pleroma/clippy.ex
@@ -4,6 +4,7 @@
 
 defmodule Pleroma.Clippy do
   @moduledoc false
+
   # No software is complete until they have a Clippy implementation.
   # A ballmer peak _may_ be required to change this module.
 

diff --git a/lib/pleroma/html.ex b/lib/pleroma/html.ex
index 997e965f0829afdf4e475a1ecdc16e5f8a9e80b9..71c53ce0ed7f6d827b522a814663882bd3ea15b8 100644 (file)
--- a/lib/pleroma/html.ex
+++ b/lib/pleroma/html.ex
@@ -163,6 +163,7 @@ defmodule Pleroma.HTML.Scrubber.Default do
 
   require FastSanitize.Sanitizer.Meta
   alias FastSanitize.Sanitizer.Meta
+
   # credo:disable-for-previous-line
   # No idea how to fix this one…
 

diff --git a/lib/pleroma/web/activity_pub/transmogrifier.ex b/lib/pleroma/web/activity_pub/transmogrifier.ex
index ce95fb6babf84a0c7ac38359c7bae335f2dea5aa..ecba27bef439060af70ed417d4f080b1af9a56cf 100644 (file)
--- a/lib/pleroma/web/activity_pub/transmogrifier.ex
+++ b/lib/pleroma/web/activity_pub/transmogrifier.ex
@@ -387,7 +387,7 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
   def handle_incoming(%{"id" => nil}, _options), do: :error
   def handle_incoming(%{"id" => ""}, _options), do: :error
   # length of https:// = 8, should validate better, but good enough for now.
-  def handle_incoming(%{"id" => id}, _options) when not (is_binary(id) and length(id) > 8),
+  def handle_incoming(%{"id" => id}, _options) when is_binary(id) and byte_size(id) < 8,
     do: :error
 
   # TODO: validate those with a Ecto scheme