After code review

Use patern matching to see if someone was superuser before

diff --git a/lib/pleroma/user.ex b/lib/pleroma/user.ex
index 809524f560226b91cf8e8074d3d6c9461994a77d..27ed9bbc563d1e99b4f9138032a0972ec54aa761 100644 (file)
--- a/lib/pleroma/user.ex
+++ b/lib/pleroma/user.ex
@@ -1099,11 +1099,8 @@ defmodule Pleroma.User do
     |> maybe_remove_report_notifications(was_superuser_before_update)
   end
 
-  defp maybe_remove_report_notifications(
-         {:ok, %Pleroma.User{} = user} = result,
-         was_superuser_before_update
-       ) do
-    if was_superuser_before_update and not User.superuser?(user),
+  defp maybe_remove_report_notifications({:ok, %Pleroma.User{} = user} = result, true) do
+    if not User.superuser?(user),
       do: user |> Notification.destroy_multiple_from_types(["pleroma:report"])
 
     result