Update clear_config macro
authorRoman Chvanikov <chvanikoff@pm.me>
Wed, 5 Aug 2020 14:46:14 +0000 (17:46 +0300)
committerRoman Chvanikov <chvanikoff@pm.me>
Wed, 5 Aug 2020 14:46:14 +0000 (17:46 +0300)
test/application_requirements_test.exs
test/support/helpers.ex

index e96295955ba8ed440372b63a3baff9500c2fa74a..21d24ddd069514d2aa67f3855e9ecc21ddddd79a 100644 (file)
@@ -127,10 +127,7 @@ defmodule Pleroma.ApplicationRequirementsTest do
       :ok
     end
 
-    setup do
-      Pleroma.Config.get(:i_am_aware_this_may_cause_data_loss, 42) |> IO.inspect()
-      clear_config([:i_am_aware_this_may_cause_data_loss, :disable_migration_check])
-    end
+    setup do: clear_config([:i_am_aware_this_may_cause_data_loss, :disable_migration_check])
 
     test "raises if it detects unapplied migrations" do
       assert_raise Pleroma.ApplicationRequirements.VerifyError,
index 7d729541dc3432ec27dc83e8448050cd508a2c74..ecd4b1e185889cb5b3398511f7fb804a2d2a7aad 100644 (file)
@@ -17,16 +17,16 @@ defmodule Pleroma.Tests.Helpers do
 
   defmacro clear_config(config_path, do: yield) do
     quote do
-      initial_setting = Config.get(unquote(config_path), :__clear_config_absent__)
+      initial_setting = Config.fetch(unquote(config_path))
       unquote(yield)
 
       on_exit(fn ->
         case initial_setting do
-          :__clear_config_absent__ ->
+          :error ->
             Config.delete(unquote(config_path))
 
-          _ ->
-            Config.put(unquote(config_path), initial_setting)
+          {:ok, value} ->
+            Config.put(unquote(config_path), value)
         end
       end)