download-mastofe-build.sh: Proper exit when artifact is missing

diff --git a/installation/download-mastofe-build.sh b/installation/download-mastofe-build.sh
index ee9e1c21782eae3947f48ebe88c7745e5f3a39f8..b8a021ef3dc5ee7f060484013ba7f0134247d23d 100755 (executable)
--- a/installation/download-mastofe-build.sh
+++ b/installation/download-mastofe-build.sh
@@ -9,29 +9,32 @@ static_dir="instance/static"
 # project_branch="pleroma"
 # static_dir="priv/static"
 
-if [[ ! -d "${static_dir}" ]]
+if [ ! -d "${static_dir}" ]
 then
        echo "Error: ${static_dir} directory is missing, are you sure you are running this script at the root of pleroma’s repository?"
        exit 1
 fi
 
-last_modified="$(curl -s -I 'https://git.pleroma.social/api/v4/projects/'${project_id}'/jobs/artifacts/'${project_branch}'/download?job=build' | grep '^Last-Modified:' | cut -d: -f2-)"
+last_modified="$(curl --fail -s -I 'https://git.pleroma.social/api/v4/projects/'${project_id}'/jobs/artifacts/'${project_branch}'/download?job=build' | grep '^Last-Modified:' | cut -d: -f2-)"
 
 echo "branch:${project_branch}"
 echo "Last-Modified:${last_modified}"
 
 artifact="mastofe.zip"
 
-if [[ -e mastofe.timestamp ]] && [[ "${last_modified}" != "" ]]
+if [ "${last_modified}x" = "x" ]
 then
-       if [[ "$(cat mastofe.timestamp)" == "${last_modified}" ]]
-       then
-               echo "MastoFE is up-to-date, exiting…"
-               exit 0
-       fi
+       echo "ERROR: Couldn't get the modification date of the latest build archive, maybe it expired, exiting..."
+       exit 1
+fi
+
+if [ -e mastofe.timestamp ] && [ "$(cat mastofe.timestamp)" = "${last_modified}" ]
+then
+       echo "MastoFE is up-to-date, exiting..."
+       exit 0
 fi
 
-curl -c - "https://git.pleroma.social/api/v4/projects/${project_id}/jobs/artifacts/${project_branch}/download?job=build" -o "${artifact}" || exit
+curl --fail -c - "https://git.pleroma.social/api/v4/projects/${project_id}/jobs/artifacts/${project_branch}/download?job=build" -o "${artifact}" || exit
 
 # TODO: Update the emoji as well
 rm -fr "${static_dir}/sw.js" "${static_dir}/packs" || exit