Remove User.upgrade_changeset in favor of remote_user_creation
authorrinpatch <rinpatch@sdf.org>
Sat, 11 Apr 2020 18:44:52 +0000 (21:44 +0300)
committerrinpatch <rinpatch@sdf.org>
Sat, 11 Apr 2020 19:31:46 +0000 (22:31 +0300)
commitc077ad0b3305e74f5b8d1b9bf38d4f480d76c1a6
treeeb702217459d29b86cbbaecf48e5547729d82152
parentfc4f92c5de54f4a427fb0fccbd4e64a72344ac6f
Remove User.upgrade_changeset in favor of remote_user_creation

The two changesets had the same purpose, yet some changes were updated
in one, but not the other (`uri`, for example).

Also makes `Transmogrifier.upgrade_user_from_ap_id` be called from
`ActivityPub.make_user_from_ap_id` only when the user is actually
not AP enabled yet.

I did not bother rewriting tests that used `User.insert_or_update`
to use the changeset instead because they seemed to just test the implementation,
rather than behavior.
lib/pleroma/user.ex
lib/pleroma/web/activity_pub/activity_pub.ex
lib/pleroma/web/activity_pub/transmogrifier.ex
test/user_test.exs
test/web/activity_pub/views/user_view_test.exs