StatusView: clear MSB on calculated conversation_id
authorHélène <pleroma-dev@helene.moe>
Sun, 7 Aug 2022 18:37:17 +0000 (20:37 +0200)
committerFloatingGhost <hannah@coffee-and-dreams.uk>
Sun, 7 Aug 2022 19:47:59 +0000 (20:47 +0100)
commitb9bb0936001b64c3a693f6d2ac5813b655148322
treef62b1a044c7b8ff1779b34b010157f0f343ec102
parent62e179f446ac7bfada965fac47e9613ce60091b4
StatusView: clear MSB on calculated conversation_id

This field seems to be a left-over from the StatusNet era.
If your application uses `pleroma.conversation_id`: this field is
deprecated.

It is currently stubbed instead by doing a CRC32 of the context, and
clearing the MSB to avoid overflow exceptions with signed integers on
the different clients using this field (Java/Kotlin code, mostly; see
Husky and probably other mobile clients.)

This should be removed in a future version of Pleroma. Pleroma-FE
currently depends on this field, as well.
lib/pleroma/web/mastodon_api/views/status_view.ex
test/pleroma/web/mastodon_api/views/status_view_test.exs