X-Git-Url: https://git.squeep.com/?a=blobdiff_plain;ds=sidebyside;f=test%2Fweb%2Fostatus%2Fostatus_controller_test.exs;h=560305c15ff713bf305c9746d3430bec6adcb4e5;hb=2592b3c81a5af20536c3cc9709e3971d6cfb1e68;hp=20d17d41f1cd4e1b58a147b49df67b337b138987;hpb=41b8a76e969e97aef68e7be1f1cdadcb31ea9b1d;p=akkoma

diff --git a/test/web/ostatus/ostatus_controller_test.exs b/test/web/ostatus/ostatus_controller_test.exs
index 20d17d41f..560305c15 100644
--- a/test/web/ostatus/ostatus_controller_test.exs
+++ b/test/web/ostatus/ostatus_controller_test.exs
@@ -2,14 +2,22 @@ defmodule Pleroma.Web.OStatus.OStatusControllerTest do
   use Pleroma.Web.ConnCase
   import Pleroma.Factory
   alias Pleroma.{User, Repo}
+  alias Pleroma.Web.CommonAPI
   alias Pleroma.Web.OStatus.ActivityRepresenter
 
+  setup_all do
+    Tesla.Mock.mock_global(fn env -> apply(HttpRequestMock, :request, [env]) end)
+    :ok
+  end
+
   test "decodes a salmon", %{conn: conn} do
     user = insert(:user)
     salmon = File.read!("test/fixtures/salmon.xml")
-    conn = conn
-    |> put_req_header("content-type", "application/atom+xml")
-    |> post("/users/#{user.nickname}/salmon", salmon)
+
+    conn =
+      conn
+      |> put_req_header("content-type", "application/atom+xml")
+      |> post("/users/#{user.nickname}/salmon", salmon)
 
     assert response(conn, 200)
   end
@@ -17,21 +25,32 @@ defmodule Pleroma.Web.OStatus.OStatusControllerTest do
   test "decodes a salmon with a changed magic key", %{conn: conn} do
     user = insert(:user)
     salmon = File.read!("test/fixtures/salmon.xml")
-    conn = conn
-    |> put_req_header("content-type", "application/atom+xml")
-    |> post("/users/#{user.nickname}/salmon", salmon)
+
+    conn =
+      conn
+      |> put_req_header("content-type", "application/atom+xml")
+      |> post("/users/#{user.nickname}/salmon", salmon)
 
     assert response(conn, 200)
 
     # Set a wrong magic-key for a user so it has to refetch
     salmon_user = User.get_by_ap_id("http://gs.example.org:4040/index.php/user/1")
-    info = salmon_user.info
-    |> Map.put("magic_key", "RSA.pu0s-halox4tu7wmES1FVSx6u-4wc0YrUFXcqWXZG4-27UmbCOpMQftRCldNRfyA-qLbz-eqiwrong1EwUvjsD4cYbAHNGHwTvDOyx5AKthQUP44ykPv7kjKGh3DWKySJvcs9tlUG87hlo7AvnMo9pwRS_Zz2CacQ-MKaXyDepk=.AQAB") # Wrong key
-    Repo.update(User.info_changeset(salmon_user, %{info: info}))
-
-    conn = build_conn()
-    |> put_req_header("content-type", "application/atom+xml")
-    |> post("/users/#{user.nickname}/salmon", salmon)
+    # Wrong key
+    info_cng =
+      User.Info.remote_user_creation(salmon_user.info, %{
+        magic_key:
+          "RSA.pu0s-halox4tu7wmES1FVSx6u-4wc0YrUFXcqWXZG4-27UmbCOpMQftRCldNRfyA-qLbz-eqiwrong1EwUvjsD4cYbAHNGHwTvDOyx5AKthQUP44ykPv7kjKGh3DWKySJvcs9tlUG87hlo7AvnMo9pwRS_Zz2CacQ-MKaXyDepk=.AQAB"
+      })
+
+    salmon_user
+    |> Ecto.Changeset.change()
+    |> Ecto.Changeset.put_embed(:info, info_cng)
+    |> Repo.update()
+
+    conn =
+      build_conn()
+      |> put_req_header("content-type", "application/atom+xml")
+      |> post("/users/#{user.nickname}/salmon", salmon)
 
     assert response(conn, 200)
   end
@@ -40,44 +59,155 @@ defmodule Pleroma.Web.OStatus.OStatusControllerTest do
     note_activity = insert(:note_activity)
     user = User.get_cached_by_ap_id(note_activity.data["actor"])
 
-    conn = conn
-    |> get("/users/#{user.nickname}/feed.atom")
+    conn =
+      conn
+      |> put_req_header("content-type", "application/atom+xml")
+      |> get("/users/#{user.nickname}/feed.atom")
 
-    assert response(conn, 200)
+    assert response(conn, 200) =~ note_activity.data["object"]["content"]
+  end
+
+  test "returns 404 for a missing feed", %{conn: conn} do
+    conn =
+      conn
+      |> put_req_header("content-type", "application/atom+xml")
+      |> get("/users/nonexisting/feed.atom")
+
+    assert response(conn, 404)
   end
 
   test "gets an object", %{conn: conn} do
     note_activity = insert(:note_activity)
     user = User.get_by_ap_id(note_activity.data["actor"])
-    [_, uuid] = hd Regex.scan(~r/.+\/([\w-]+)$/, note_activity.data["object"]["id"])
+    [_, uuid] = hd(Regex.scan(~r/.+\/([\w-]+)$/, note_activity.data["object"]["id"]))
     url = "/objects/#{uuid}"
 
-    conn = conn
-    |> get(url)
+    conn =
+      conn
+      |> get(url)
 
-    expected = ActivityRepresenter.to_simple_form(note_activity, user, true)
-    |> ActivityRepresenter.wrap_with_entry
-    |> :xmerl.export_simple(:xmerl_xml)
-    |> to_string
+    expected =
+      ActivityRepresenter.to_simple_form(note_activity, user, true)
+      |> ActivityRepresenter.wrap_with_entry()
+      |> :xmerl.export_simple(:xmerl_xml)
+      |> to_string
 
     assert response(conn, 200) == expected
   end
 
+  test "404s on private objects", %{conn: conn} do
+    note_activity = insert(:direct_note_activity)
+    [_, uuid] = hd(Regex.scan(~r/.+\/([\w-]+)$/, note_activity.data["object"]["id"]))
+
+    conn
+    |> get("/objects/#{uuid}")
+    |> response(404)
+  end
+
+  test "404s on nonexisting objects", %{conn: conn} do
+    conn
+    |> get("/objects/123")
+    |> response(404)
+  end
+
   test "gets an activity", %{conn: conn} do
     note_activity = insert(:note_activity)
-    [_, uuid] = hd Regex.scan(~r/.+\/([\w-]+)$/, note_activity.data["id"])
+    [_, uuid] = hd(Regex.scan(~r/.+\/([\w-]+)$/, note_activity.data["id"]))
+
+    conn
+    |> get("/activities/#{uuid}")
+    |> response(200)
+  end
+
+  test "404s on private activities", %{conn: conn} do
+    note_activity = insert(:direct_note_activity)
+    [_, uuid] = hd(Regex.scan(~r/.+\/([\w-]+)$/, note_activity.data["id"]))
+
+    conn
+    |> get("/activities/#{uuid}")
+    |> response(404)
+  end
+
+  test "404s on nonexistent activities", %{conn: conn} do
+    conn
+    |> get("/activities/123")
+    |> response(404)
+  end
+
+  test "gets a notice", %{conn: conn} do
+    note_activity = insert(:note_activity)
+
+    conn
+    |> get("/notice/#{note_activity.id}")
+    |> response(200)
+  end
+
+  test "gets a notice in AS2 format", %{conn: conn} do
+    note_activity = insert(:note_activity)
+
+    conn
+    |> put_req_header("accept", "application/activity+json")
+    |> get("/notice/#{note_activity.id}")
+    |> json_response(200)
+  end
+
+  test "only gets a notice in AS2 format for Create messages", %{conn: conn} do
+    note_activity = insert(:note_activity)
+    url = "/notice/#{note_activity.id}"
+
+    conn =
+      conn
+      |> put_req_header("accept", "application/activity+json")
+      |> get(url)
+
+    assert json_response(conn, 200)
+
+    user = insert(:user)
+
+    {:ok, like_activity, _} = CommonAPI.favorite(note_activity.id, user)
+    url = "/notice/#{like_activity.id}"
+
+    assert like_activity.data["type"] == "Like"
+
+    conn =
+      build_conn()
+      |> put_req_header("accept", "application/activity+json")
+      |> get(url)
+
+    assert response(conn, 404)
+  end
+
+  test "gets an activity in AS2 format", %{conn: conn} do
+    note_activity = insert(:note_activity)
+    [_, uuid] = hd(Regex.scan(~r/.+\/([\w-]+)$/, note_activity.data["id"]))
     url = "/activities/#{uuid}"
 
-    conn = conn
-    |> get(url)
+    conn =
+      conn
+      |> put_req_header("accept", "application/activity+json")
+      |> get(url)
 
-    assert response(conn, 200)
+    assert json_response(conn, 200)
   end
-end
 
-defmodule Pleroma.Web.OStatusMock do
-  import Pleroma.Factory
-  def handle_incoming(_doc) do
-    insert(:note_activity)
+  test "404s a private notice", %{conn: conn} do
+    note_activity = insert(:direct_note_activity)
+    url = "/notice/#{note_activity.id}"
+
+    conn =
+      conn
+      |> get(url)
+
+    assert response(conn, 404)
+  end
+
+  test "404s a nonexisting notice", %{conn: conn} do
+    url = "/notice/123"
+
+    conn =
+      conn
+      |> get(url)
+
+    assert response(conn, 404)
   end
 end