defmodule Pleroma.Web.ActivityPub.MRF.FollowBotPolicy do
@behaviour Pleroma.Web.ActivityPub.MRF
+ alias Pleroma.Activity.Queries
alias Pleroma.Config
+ alias Pleroma.Repo
alias Pleroma.User
alias Pleroma.Web.CommonAPI
require Logger
+ import Ecto.Query
+
@impl true
def filter(message) do
with follower_nickname <- Config.get([:mrf_follow_bot, :follower_nickname]),
- %User{} = follower <- User.get_cached_by_nickname(follower_nickname),
+ %User{actor_type: "Service"} = follower <-
+ User.get_cached_by_nickname(follower_nickname),
%{"type" => "Create", "object" => %{"type" => "Note"}} <- message do
try_follow(follower, message)
else
nil ->
Logger.warn(
- "#{__MODULE__} skipped because of missing :mrf_follow_bot, :follower_nickname configuration or the account
- does not exist."
+ "#{__MODULE__} skipped because of missing `:mrf_follow_bot, :follower_nickname` configuration, the :follower_nickname
+ account does not exist, or the account is not correctly configured as a bot."
)
{:ok, message}
Enum.concat([to, cc, actor])
|> List.flatten()
+ |> Enum.uniq()
|> User.get_all_by_ap_id()
|> Enum.each(fn user ->
- Logger.info("Checking if #{user.nickname} can be followed")
+ since_thirty_days_ago = NaiveDateTime.utc_now() |> NaiveDateTime.add(-(86_400 * 30))
with false <- User.following?(follower, user),
- false <- user.locked,
- false <- (user.bio || "") |> String.downcase() |> String.contains?("nobot") do
- Logger.info("Following #{user.nickname}")
+ false <- User.locked?(user),
+ false <- (user.bio || "") |> String.downcase() |> String.contains?("nobot"),
+ false <- outstanding_follow_request_since?(follower, user, since_thirty_days_ago) do
+ Logger.info(
+ "#{__MODULE__}: Follow request from #{follower.nickname} to #{user.nickname}"
+ )
+
CommonAPI.follow(follower, user)
end
end)
{:ok, message}
end
+ defp outstanding_follow_request_since?(
+ %User{ap_id: follower_id},
+ %User{ap_id: followee_id},
+ since_datetime
+ ) do
+ followee_id
+ |> Queries.by_object_id()
+ |> Queries.by_type("Follow")
+ |> where([a], a.inserted_at > ^since_datetime)
+ |> where([a], fragment("? ->> 'state' != 'accept'", a.data))
+ |> where([a], a.actor == ^follower_id)
+ |> Repo.exists?()
+ end
+
@impl true
def describe do
{:ok, %{}}