1 defmodule Pleroma.Web.ActivityPub.ObjectValidatorTest do
5 alias Pleroma.Web.ActivityPub.ActivityPub
6 alias Pleroma.Web.ActivityPub.Builder
7 alias Pleroma.Web.ActivityPub.ObjectValidator
8 alias Pleroma.Web.ActivityPub.ObjectValidators.AttachmentValidator
9 alias Pleroma.Web.ActivityPub.ObjectValidators.LikeValidator
10 alias Pleroma.Web.ActivityPub.Utils
11 alias Pleroma.Web.CommonAPI
13 import Pleroma.Factory
15 describe "attachments" do
16 test "it turns mastodon attachments into our attachments" do
19 "http://mastodon.example.org/system/media_attachments/files/000/000/002/original/334ce029e7bfb920.jpg",
22 "mediaType" => "image/jpeg"
26 AttachmentValidator.cast_and_validate(attachment)
27 |> Ecto.Changeset.apply_action(:insert)
32 "http://mastodon.example.org/system/media_attachments/files/000/000/002/original/334ce029e7bfb920.jpg",
34 mediaType: "image/jpeg"
40 describe "chat message create activities" do
41 test "it is invalid if the object already exists" do
43 recipient = insert(:user)
44 {:ok, activity} = CommonAPI.post_chat_message(user, recipient, "hey")
45 object = Object.normalize(activity, false)
47 {:ok, create_data, _} = Builder.create(user, object.data, [recipient.ap_id])
49 {:error, cng} = ObjectValidator.validate(create_data, [])
51 assert {:object, {"The object to create already exists", []}} in cng.errors
54 test "it is invalid if the object data has a different `to` or `actor` field" do
56 recipient = insert(:user)
57 {:ok, object_data, _} = Builder.chat_message(recipient, user.ap_id, "Hey")
59 {:ok, create_data, _} = Builder.create(user, object_data, [recipient.ap_id])
61 {:error, cng} = ObjectValidator.validate(create_data, [])
63 assert {:to, {"Recipients don't match with object recipients", []}} in cng.errors
64 assert {:actor, {"Actor doesn't match with object actor", []}} in cng.errors
68 describe "chat messages" do
70 clear_config([:instance, :remote_limit])
72 recipient = insert(:user, local: false)
74 {:ok, valid_chat_message, _} = Builder.chat_message(user, recipient.ap_id, "hey :firefox:")
76 %{user: user, recipient: recipient, valid_chat_message: valid_chat_message}
79 test "validates for a basic object we build", %{valid_chat_message: valid_chat_message} do
80 assert {:ok, object, _meta} = ObjectValidator.validate(valid_chat_message, [])
82 assert Map.put(valid_chat_message, "attachment", nil) == object
85 test "validates for a basic object with an attachment", %{
86 valid_chat_message: valid_chat_message,
90 content_type: "image/jpg",
91 path: Path.absname("test/fixtures/image.jpg"),
92 filename: "an_image.jpg"
95 {:ok, attachment} = ActivityPub.upload(file, actor: user.ap_id)
99 |> Map.put("attachment", attachment.data)
101 assert {:ok, object, _meta} = ObjectValidator.validate(valid_chat_message, [])
103 assert object["attachment"]
106 test "does not validate if the message is longer than the remote_limit", %{
107 valid_chat_message: valid_chat_message
109 Pleroma.Config.put([:instance, :remote_limit], 2)
110 refute match?({:ok, _object, _meta}, ObjectValidator.validate(valid_chat_message, []))
113 test "does not validate if the recipient is blocking the actor", %{
114 valid_chat_message: valid_chat_message,
118 Pleroma.User.block(recipient, user)
119 refute match?({:ok, _object, _meta}, ObjectValidator.validate(valid_chat_message, []))
122 test "does not validate if the actor or the recipient is not in our system", %{
123 valid_chat_message: valid_chat_message
127 |> Map.put("actor", "https://raymoo.com/raymoo")
129 {:error, _} = ObjectValidator.validate(chat_message, [])
133 |> Map.put("to", ["https://raymoo.com/raymoo"])
135 {:error, _} = ObjectValidator.validate(chat_message, [])
138 test "does not validate for a message with multiple recipients", %{
139 valid_chat_message: valid_chat_message,
145 |> Map.put("to", [user.ap_id, recipient.ap_id])
147 assert {:error, _} = ObjectValidator.validate(chat_message, [])
150 test "does not validate if it doesn't concern local users" do
151 user = insert(:user, local: false)
152 recipient = insert(:user, local: false)
154 {:ok, valid_chat_message, _} = Builder.chat_message(user, recipient.ap_id, "hey")
155 assert {:error, _} = ObjectValidator.validate(valid_chat_message, [])
162 {:ok, post_activity} = CommonAPI.post(user, %{"status" => "uguu"})
165 "to" => [user.ap_id],
168 "id" => Utils.generate_activity_id(),
169 "object" => post_activity.data["object"],
170 "actor" => user.ap_id,
171 "context" => "a context"
174 %{valid_like: valid_like, user: user, post_activity: post_activity}
177 test "returns ok when called in the ObjectValidator", %{valid_like: valid_like} do
178 {:ok, object, _meta} = ObjectValidator.validate(valid_like, [])
180 assert "id" in Map.keys(object)
183 test "is valid for a valid object", %{valid_like: valid_like} do
184 assert LikeValidator.cast_and_validate(valid_like).valid?
187 test "sets the 'to' field to the object actor if no recipients are given", %{
188 valid_like: valid_like,
195 {:ok, object, _meta} = ObjectValidator.validate(without_recipients, [])
197 assert object["to"] == [user.ap_id]
200 test "sets the context field to the context of the object if no context is given", %{
201 valid_like: valid_like,
202 post_activity: post_activity
206 |> Map.delete("context")
208 {:ok, object, _meta} = ObjectValidator.validate(without_context, [])
210 assert object["context"] == post_activity.data["context"]
213 test "it errors when the actor is missing or not known", %{valid_like: valid_like} do
214 without_actor = Map.delete(valid_like, "actor")
216 refute LikeValidator.cast_and_validate(without_actor).valid?
218 with_invalid_actor = Map.put(valid_like, "actor", "invalidactor")
220 refute LikeValidator.cast_and_validate(with_invalid_actor).valid?
223 test "it errors when the object is missing or not known", %{valid_like: valid_like} do
224 without_object = Map.delete(valid_like, "object")
226 refute LikeValidator.cast_and_validate(without_object).valid?
228 with_invalid_object = Map.put(valid_like, "object", "invalidobject")
230 refute LikeValidator.cast_and_validate(with_invalid_object).valid?
233 test "it errors when the actor has already like the object", %{
234 valid_like: valid_like,
236 post_activity: post_activity
238 _like = CommonAPI.favorite(user, post_activity.id)
240 refute LikeValidator.cast_and_validate(valid_like).valid?
243 test "it works when actor or object are wrapped in maps", %{valid_like: valid_like} do
246 |> Map.put("actor", %{"id" => valid_like["actor"]})
247 |> Map.put("object", %{"id" => valid_like["object"]})
249 validated = LikeValidator.cast_and_validate(wrapped_like)
251 assert validated.valid?
253 assert {:actor, valid_like["actor"]} in validated.changes
254 assert {:object, valid_like["object"]} in validated.changes