ObjectValidator: Rewrite LikeValidator with Ecto.
[akkoma] / test / web / activity_pub / object_validator_test.exs
1 defmodule Pleroma.Web.ActivityPub.ObjectValidatorTest do
2 use Pleroma.DataCase
3
4 alias Pleroma.Web.CommonAPI
5 alias Pleroma.Web.ActivityPub.ObjectValidator
6 alias Pleroma.Web.ActivityPub.ObjectValidators.LikeValidator
7 alias Pleroma.Web.ActivityPub.Utils
8 import Pleroma.Factory
9
10 describe "likes" do
11 setup do
12 user = insert(:user)
13 {:ok, post_activity} = CommonAPI.post(user, %{"status" => "uguu"})
14
15 valid_like = %{
16 "type" => "Like",
17 "id" => Utils.generate_activity_id(),
18 "object" => post_activity.data["object"],
19 "actor" => user.ap_id,
20 "context" => "a context"
21 }
22
23 %{valid_like: valid_like, user: user, post_activity: post_activity}
24 end
25
26 test "returns ok when called in the ObjectValidator", %{valid_like: valid_like} do
27 {:ok, object, _meta} = ObjectValidator.validate(valid_like, [])
28
29 assert "id" in Map.keys(object)
30 end
31
32 test "is valid for a valid object", %{valid_like: valid_like} do
33 assert LikeValidator.cast_and_validate(valid_like).valid?
34 end
35
36 test "it errors when the actor is missing or not known", %{valid_like: valid_like} do
37 without_actor = Map.delete(valid_like, "actor")
38
39 refute LikeValidator.cast_and_validate(without_actor).valid?
40
41 with_invalid_actor = Map.put(valid_like, "actor", "invalidactor")
42
43 refute LikeValidator.cast_and_validate(with_invalid_actor).valid?
44 end
45
46 test "it errors when the object is missing or not known", %{valid_like: valid_like} do
47 without_object = Map.delete(valid_like, "object")
48
49 refute LikeValidator.cast_and_validate(without_object).valid?
50
51 with_invalid_object = Map.put(valid_like, "object", "invalidobject")
52
53 refute LikeValidator.cast_and_validate(with_invalid_object).valid?
54 end
55
56 test "it errors when the actor has already like the object", %{
57 valid_like: valid_like,
58 user: user,
59 post_activity: post_activity
60 } do
61 _like = CommonAPI.favorite(user, post_activity.id)
62
63 refute LikeValidator.cast_and_validate(valid_like).valid?
64 end
65
66 test "it works when actor or object are wrapped in maps", %{valid_like: valid_like} do
67 wrapped_like =
68 valid_like
69 |> Map.put("actor", %{"id" => valid_like["actor"]})
70 |> Map.put("object", %{"id" => valid_like["object"]})
71
72 validated = LikeValidator.cast_and_validate(wrapped_like)
73
74 assert validated.valid?
75
76 assert {:actor, valid_like["actor"]} in validated.changes
77 assert {:object, valid_like["object"]} in validated.changes
78 end
79 end
80 end