1 defmodule Pleroma.Web.ActivityPub.ObjectValidatorTest do
5 alias Pleroma.Web.ActivityPub.Builder
6 alias Pleroma.Web.ActivityPub.ObjectValidator
7 alias Pleroma.Web.ActivityPub.ObjectValidators.LikeValidator
8 alias Pleroma.Web.ActivityPub.Utils
9 alias Pleroma.Web.CommonAPI
11 import Pleroma.Factory
16 {:ok, post_activity} = CommonAPI.post(user, %{"status" => "uguu"})
17 {:ok, like} = CommonAPI.favorite(user, post_activity.id)
18 {:ok, valid_like_undo, []} = Builder.undo(user, like)
20 %{user: user, like: like, valid_like_undo: valid_like_undo}
23 test "it validates a basic like undo", %{valid_like_undo: valid_like_undo} do
24 assert {:ok, _, _} = ObjectValidator.validate(valid_like_undo, [])
27 test "it does not validate if the actor of the undo is not the actor of the object", %{
28 valid_like_undo: valid_like_undo
30 other_user = insert(:user, ap_id: "https://gensokyo.2hu/users/raymoo")
34 |> Map.put("actor", other_user.ap_id)
36 {:error, cng} = ObjectValidator.validate(bad_actor, [])
38 assert {:actor, {"not the same as object actor", []}} in cng.errors
41 test "it does not validate if the object is missing", %{valid_like_undo: valid_like_undo} do
44 |> Map.put("object", "https://gensokyo.2hu/objects/1")
46 {:error, cng} = ObjectValidator.validate(missing_object, [])
48 assert {:object, {"can't find object", []}} in cng.errors
49 assert length(cng.errors) == 1
56 {:ok, post_activity} = CommonAPI.post(user, %{"status" => "cancel me daddy"})
58 {:ok, valid_post_delete, _} = Builder.delete(user, post_activity.data["object"])
59 {:ok, valid_user_delete, _} = Builder.delete(user, user.ap_id)
61 %{user: user, valid_post_delete: valid_post_delete, valid_user_delete: valid_user_delete}
64 test "it is valid for a post deletion", %{valid_post_delete: valid_post_delete} do
65 {:ok, valid_post_delete, _} = ObjectValidator.validate(valid_post_delete, [])
67 assert valid_post_delete["deleted_activity_id"]
70 test "it is invalid if the object isn't in a list of certain types", %{
71 valid_post_delete: valid_post_delete
73 object = Object.get_by_ap_id(valid_post_delete["object"])
77 |> Map.put("type", "Like")
81 |> Ecto.Changeset.change(%{data: data})
82 |> Object.update_and_set_cache()
84 {:error, cng} = ObjectValidator.validate(valid_post_delete, [])
85 assert {:object, {"object not in allowed types", []}} in cng.errors
88 test "it is valid for a user deletion", %{valid_user_delete: valid_user_delete} do
89 assert match?({:ok, _, _}, ObjectValidator.validate(valid_user_delete, []))
92 test "it's invalid if the id is missing", %{valid_post_delete: valid_post_delete} do
97 {:error, cng} = ObjectValidator.validate(no_id, [])
99 assert {:id, {"can't be blank", [validation: :required]}} in cng.errors
102 test "it's invalid if the object doesn't exist", %{valid_post_delete: valid_post_delete} do
105 |> Map.put("object", "http://does.not/exist")
107 {:error, cng} = ObjectValidator.validate(missing_object, [])
109 assert {:object, {"can't find object", []}} in cng.errors
110 assert length(cng.errors) == 1
113 test "it's invalid if the actor of the object and the actor of delete are from different domains",
114 %{valid_post_delete: valid_post_delete} do
115 valid_user = insert(:user)
119 |> Map.put("actor", valid_user.ap_id)
121 assert match?({:ok, _, _}, ObjectValidator.validate(valid_other_actor, []))
123 invalid_other_actor =
125 |> Map.put("actor", "https://gensokyo.2hu/users/raymoo")
127 {:error, cng} = ObjectValidator.validate(invalid_other_actor, [])
129 assert {:actor, {"is not allowed to delete object", []}} in cng.errors
132 test "it's valid if the actor of the object is a local superuser",
133 %{valid_post_delete: valid_post_delete} do
135 insert(:user, local: true, is_moderator: true, ap_id: "https://gensokyo.2hu/users/raymoo")
139 |> Map.put("actor", user.ap_id)
141 {:ok, _, meta} = ObjectValidator.validate(valid_other_actor, [])
142 assert meta[:do_not_federate]
149 {:ok, post_activity} = CommonAPI.post(user, %{"status" => "uguu"})
152 "to" => [user.ap_id],
155 "id" => Utils.generate_activity_id(),
156 "object" => post_activity.data["object"],
157 "actor" => user.ap_id,
158 "context" => "a context"
161 %{valid_like: valid_like, user: user, post_activity: post_activity}
164 test "returns ok when called in the ObjectValidator", %{valid_like: valid_like} do
165 {:ok, object, _meta} = ObjectValidator.validate(valid_like, [])
167 assert "id" in Map.keys(object)
170 test "is valid for a valid object", %{valid_like: valid_like} do
171 assert LikeValidator.cast_and_validate(valid_like).valid?
174 test "sets the 'to' field to the object actor if no recipients are given", %{
175 valid_like: valid_like,
182 {:ok, object, _meta} = ObjectValidator.validate(without_recipients, [])
184 assert object["to"] == [user.ap_id]
187 test "sets the context field to the context of the object if no context is given", %{
188 valid_like: valid_like,
189 post_activity: post_activity
193 |> Map.delete("context")
195 {:ok, object, _meta} = ObjectValidator.validate(without_context, [])
197 assert object["context"] == post_activity.data["context"]
200 test "it errors when the actor is missing or not known", %{valid_like: valid_like} do
201 without_actor = Map.delete(valid_like, "actor")
203 refute LikeValidator.cast_and_validate(without_actor).valid?
205 with_invalid_actor = Map.put(valid_like, "actor", "invalidactor")
207 refute LikeValidator.cast_and_validate(with_invalid_actor).valid?
210 test "it errors when the object is missing or not known", %{valid_like: valid_like} do
211 without_object = Map.delete(valid_like, "object")
213 refute LikeValidator.cast_and_validate(without_object).valid?
215 with_invalid_object = Map.put(valid_like, "object", "invalidobject")
217 refute LikeValidator.cast_and_validate(with_invalid_object).valid?
220 test "it errors when the actor has already like the object", %{
221 valid_like: valid_like,
223 post_activity: post_activity
225 _like = CommonAPI.favorite(user, post_activity.id)
227 refute LikeValidator.cast_and_validate(valid_like).valid?
230 test "it works when actor or object are wrapped in maps", %{valid_like: valid_like} do
233 |> Map.put("actor", %{"id" => valid_like["actor"]})
234 |> Map.put("object", %{"id" => valid_like["object"]})
236 validated = LikeValidator.cast_and_validate(wrapped_like)
238 assert validated.valid?
240 assert {:actor, valid_like["actor"]} in validated.changes
241 assert {:object, valid_like["object"]} in validated.changes