ObjectValidators.{Announce,EmojiReact,Like}: Fix context, actor & addressing
[akkoma] / test / pleroma / web / activity_pub / object_validators / announce_validation_test.exs
1 # Pleroma: A lightweight social networking server
2 # Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
3 # SPDX-License-Identifier: AGPL-3.0-only
4
5 defmodule Pleroma.Web.ActivityPub.ObjectValidators.AnnounceValidationTest do
6 use Pleroma.DataCase, async: true
7
8 alias Pleroma.Object
9 alias Pleroma.Web.ActivityPub.Builder
10 alias Pleroma.Web.ActivityPub.ObjectValidator
11 alias Pleroma.Web.CommonAPI
12
13 import Pleroma.Factory
14
15 describe "announces" do
16 setup do
17 user = insert(:user)
18 announcer = insert(:user)
19 {:ok, post_activity} = CommonAPI.post(user, %{status: "uguu"})
20
21 object = Object.normalize(post_activity, fetch: false)
22 {:ok, valid_announce, []} = Builder.announce(announcer, object)
23
24 %{
25 valid_announce: valid_announce,
26 user: user,
27 post_activity: post_activity,
28 announcer: announcer
29 }
30 end
31
32 test "returns ok for a valid announce", %{valid_announce: valid_announce} do
33 assert {:ok, _object, _meta} = ObjectValidator.validate(valid_announce, [])
34 end
35
36 test "keeps announced object context", %{valid_announce: valid_announce} do
37 assert %Object{data: %{"context" => object_context}} =
38 Object.get_cached_by_ap_id(valid_announce["object"])
39
40 {:ok, %{"context" => context}, _} =
41 valid_announce
42 |> Map.put("context", "https://example.org/invalid_context_id")
43 |> ObjectValidator.validate([])
44
45 assert context == object_context
46 end
47
48 test "returns an error if the object can't be found", %{valid_announce: valid_announce} do
49 without_object =
50 valid_announce
51 |> Map.delete("object")
52
53 {:error, cng} = ObjectValidator.validate(without_object, [])
54
55 assert {:object, {"can't be blank", [validation: :required]}} in cng.errors
56
57 nonexisting_object =
58 valid_announce
59 |> Map.put("object", "https://gensokyo.2hu/objects/99999999")
60
61 {:error, cng} = ObjectValidator.validate(nonexisting_object, [])
62
63 assert {:object, {"can't find object", []}} in cng.errors
64 end
65
66 test "returns an error if the actor already announced the object", %{
67 valid_announce: valid_announce,
68 announcer: announcer,
69 post_activity: post_activity
70 } do
71 _announce = CommonAPI.repeat(post_activity.id, announcer)
72
73 {:error, cng} = ObjectValidator.validate(valid_announce, [])
74
75 assert {:actor, {"already announced this object", []}} in cng.errors
76 assert {:object, {"already announced by this actor", []}} in cng.errors
77 end
78
79 test "returns an error if the actor can't announce the object", %{
80 announcer: announcer,
81 user: user
82 } do
83 {:ok, post_activity} =
84 CommonAPI.post(user, %{status: "a secret post", visibility: "private"})
85
86 object = Object.normalize(post_activity, fetch: false)
87
88 # Another user can't announce it
89 {:ok, announce, []} = Builder.announce(announcer, object, public: false)
90
91 {:error, cng} = ObjectValidator.validate(announce, [])
92
93 assert {:actor, {"can not announce this object", []}} in cng.errors
94
95 # The actor of the object can announce it
96 {:ok, announce, []} = Builder.announce(user, object, public: false)
97
98 assert {:ok, _, _} = ObjectValidator.validate(announce, [])
99
100 # The actor of the object can not announce it publicly
101 {:ok, announce, []} = Builder.announce(user, object, public: true)
102
103 {:error, cng} = ObjectValidator.validate(announce, [])
104
105 assert {:actor, {"can not announce this object publicly", []}} in cng.errors
106 end
107 end
108 end