Fixed deprecation warning checks
[akkoma] / lib / pleroma / config / deprecation_warnings.ex
1 # Pleroma: A lightweight social networking server
2 # Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
3 # SPDX-License-Identifier: AGPL-3.0-only
4
5 defmodule Pleroma.Config.DeprecationWarnings do
6 alias Pleroma.Config
7
8 require Logger
9 alias Pleroma.Config
10
11 @type config_namespace() :: atom() | [atom()]
12 @type config_map() :: {config_namespace(), config_namespace(), String.t()}
13
14 @mrf_config_map [
15 {[:instance, :rewrite_policy], [:mrf, :policies],
16 "\n* `config :pleroma, :instance, rewrite_policy` is now `config :pleroma, :mrf, policies`"},
17 {[:instance, :mrf_transparency], [:mrf, :transparency],
18 "\n* `config :pleroma, :instance, mrf_transparency` is now `config :pleroma, :mrf, transparency`"},
19 {[:instance, :mrf_transparency_exclusions], [:mrf, :transparency_exclusions],
20 "\n* `config :pleroma, :instance, mrf_transparency_exclusions` is now `config :pleroma, :mrf, transparency_exclusions`"}
21 ]
22
23 def check_simple_policy_tuples do
24 has_strings =
25 Config.get([:mrf_simple])
26 |> Enum.any?(fn {_, v} -> Enum.any?(v, fn e -> is_binary(e) end) end)
27
28 if has_strings do
29 Logger.warn("""
30 !!!DEPRECATION WARNING!!!
31 Your config is using strings in the SimplePolicy configuration instead of tuples. They should work for now, but you are advised to change to the new configuration to prevent possible issues later:
32
33 ```
34 config :pleroma, :mrf_simple,
35 media_removal: ["instance.tld"],
36 media_nsfw: ["instance.tld"],
37 federated_timeline_removal: ["instance.tld"],
38 report_removal: ["instance.tld"],
39 reject: ["instance.tld"],
40 followers_only: ["instance.tld"],
41 accept: ["instance.tld"],
42 avatar_removal: ["instance.tld"],
43 banner_removal: ["instance.tld"],
44 reject_deletes: ["instance.tld"]
45 ```
46
47 Is now
48
49
50 ```
51 config :pleroma, :mrf_simple,
52 media_removal: [{"instance.tld", "Reason for media removal"}],
53 media_nsfw: [{"instance.tld", "Reason for media nsfw"}],
54 federated_timeline_removal: [{"instance.tld", "Reason for federated timeline removal"}],
55 report_removal: [{"instance.tld", "Reason for report removal"}],
56 reject: [{"instance.tld", "Reason for reject"}],
57 followers_only: [{"instance.tld", "Reason for followers only"}],
58 accept: [{"instance.tld", "Reason for accept"}],
59 avatar_removal: [{"instance.tld", "Reason for avatar removal"}],
60 banner_removal: [{"instance.tld", "Reason for banner removal"}],
61 reject_deletes: [{"instance.tld", "Reason for reject deletes"}]
62 ```
63 """)
64
65 new_config =
66 Config.get([:mrf_simple])
67 |> Enum.map(fn {k, v} ->
68 {k,
69 Enum.map(v, fn
70 {instance, reason} -> {instance, reason}
71 instance -> {instance, ""}
72 end)}
73 end)
74
75 Config.put([:mrf_simple], new_config)
76
77 :error
78 else
79 :ok
80 end
81 end
82
83 def check_quarantined_instances_tuples do
84 has_strings =
85 Config.get([:instance, :quarantined_instances]) |> Enum.any?(fn e -> is_binary(e) end)
86
87 if has_strings do
88 Logger.warn("""
89 !!!DEPRECATION WARNING!!!
90 Your config is using strings in the quarantined_instances configuration instead of tuples. They should work for now, but you are advised to change to the new configuration to prevent possible issues later:
91
92 ```
93 config :pleroma, :instance,
94 quarantined_instances: ["instance.tld"]
95 ```
96
97 Is now
98
99
100 ```
101 config :pleroma, :instance,
102 quarantined_instances: [{"instance.tld", "Reason for quarantine"}]
103 ```
104 """)
105
106 new_config =
107 Config.get([:instance, :quarantined_instances])
108 |> Enum.map(fn
109 {instance, reason} -> {instance, reason}
110 instance -> {instance, ""}
111 end)
112
113 Config.put([:instance, :quarantined_instances], new_config)
114
115 :error
116 else
117 :ok
118 end
119 end
120
121 def check_transparency_exclusions_tuples do
122 has_strings =
123 Config.get([:mrf, :transparency_exclusions]) |> Enum.any?(fn e -> is_binary(e) end)
124
125 if has_strings do
126 Logger.warn("""
127 !!!DEPRECATION WARNING!!!
128 Your config is using strings in the transparency_exclusions configuration instead of tuples. They should work for now, but you are advised to change to the new configuration to prevent possible issues later:
129
130 ```
131 config :pleroma, :mrf,
132 transparency_exclusions: ["instance.tld"]
133 ```
134
135 Is now
136
137
138 ```
139 config :pleroma, :mrf,
140 transparency_exclusions: [{"instance.tld", "Reason to exlude transparency"}]
141 ```
142 """)
143
144 new_config =
145 Config.get([:mrf, :transparency_exclusions])
146 |> Enum.map(fn
147 {instance, reason} -> {instance, reason}
148 instance -> {instance, ""}
149 end)
150
151 Config.put([:mrf, :transparency_exclusions], new_config)
152
153 :error
154 else
155 :ok
156 end
157 end
158
159 def check_hellthread_threshold do
160 if Config.get([:mrf_hellthread, :threshold]) do
161 Logger.warn("""
162 !!!DEPRECATION WARNING!!!
163 You are using the old configuration mechanism for the hellthread filter. Please check config.md.
164 """)
165
166 :error
167 else
168 :ok
169 end
170 end
171
172 def warn do
173 [
174 check_hellthread_threshold(),
175 check_old_mrf_config(),
176 check_media_proxy_whitelist_config(),
177 check_welcome_message_config(),
178 check_gun_pool_options(),
179 check_activity_expiration_config(),
180 check_remote_ip_plug_name(),
181 check_uploders_s3_public_endpoint(),
182 check_old_chat_shoutbox(),
183 check_quarantined_instances_tuples(),
184 check_transparency_exclusions_tuples(),
185 check_simple_policy_tuples()
186 ]
187 |> Enum.reduce(:ok, fn
188 :ok, :ok -> :ok
189 _, _ -> :error
190 end)
191 end
192
193 def check_welcome_message_config do
194 instance_config = Pleroma.Config.get([:instance])
195
196 use_old_config =
197 Keyword.has_key?(instance_config, :welcome_user_nickname) or
198 Keyword.has_key?(instance_config, :welcome_message)
199
200 if use_old_config do
201 Logger.error("""
202 !!!DEPRECATION WARNING!!!
203 Your config is using the old namespace for Welcome messages configuration. You need to convert to the new namespace. e.g.,
204 \n* `config :pleroma, :instance, welcome_user_nickname` and `config :pleroma, :instance, welcome_message` are now equal to:
205 \n* `config :pleroma, :welcome, direct_message: [enabled: true, sender_nickname: "NICKNAME", message: "Your welcome message"]`"
206 """)
207
208 :error
209 else
210 :ok
211 end
212 end
213
214 def check_old_mrf_config do
215 warning_preface = """
216 !!!DEPRECATION WARNING!!!
217 Your config is using old namespaces for MRF configuration. They should work for now, but you are advised to change to new namespaces to prevent possible issues later:
218 """
219
220 move_namespace_and_warn(@mrf_config_map, warning_preface)
221 end
222
223 @spec move_namespace_and_warn([config_map()], String.t()) :: :ok | nil
224 def move_namespace_and_warn(config_map, warning_preface) do
225 warning =
226 Enum.reduce(config_map, "", fn
227 {old, new, err_msg}, acc ->
228 old_config = Config.get(old)
229
230 if old_config do
231 Config.put(new, old_config)
232 acc <> err_msg
233 else
234 acc
235 end
236 end)
237
238 if warning == "" do
239 :ok
240 else
241 Logger.warn(warning_preface <> warning)
242 :error
243 end
244 end
245
246 @spec check_media_proxy_whitelist_config() :: :ok | nil
247 def check_media_proxy_whitelist_config do
248 whitelist = Config.get([:media_proxy, :whitelist])
249
250 if Enum.any?(whitelist, &(not String.starts_with?(&1, "http"))) do
251 Logger.warn("""
252 !!!DEPRECATION WARNING!!!
253 Your config is using old format (only domain) for MediaProxy whitelist option. Setting should work for now, but you are advised to change format to scheme with port to prevent possible issues later.
254 """)
255
256 :error
257 else
258 :ok
259 end
260 end
261
262 def check_gun_pool_options do
263 pool_config = Config.get(:connections_pool)
264
265 if timeout = pool_config[:await_up_timeout] do
266 Logger.warn("""
267 !!!DEPRECATION WARNING!!!
268 Your config is using old setting `config :pleroma, :connections_pool, await_up_timeout`. Please change to `config :pleroma, :connections_pool, connect_timeout` to ensure compatibility with future releases.
269 """)
270
271 Config.put(:connections_pool, Keyword.put_new(pool_config, :connect_timeout, timeout))
272 end
273
274 pools_configs = Config.get(:pools)
275
276 warning_preface = """
277 !!!DEPRECATION WARNING!!!
278 Your config is using old setting name `timeout` instead of `recv_timeout` in pool settings. Setting should work for now, but you are advised to change format to scheme with port to prevent possible issues later.
279 """
280
281 updated_config =
282 Enum.reduce(pools_configs, [], fn {pool_name, config}, acc ->
283 if timeout = config[:timeout] do
284 Keyword.put(acc, pool_name, Keyword.put_new(config, :recv_timeout, timeout))
285 else
286 acc
287 end
288 end)
289
290 if updated_config != [] do
291 pool_warnings =
292 updated_config
293 |> Keyword.keys()
294 |> Enum.map(fn pool_name ->
295 "\n* `:timeout` options in #{pool_name} pool is now `:recv_timeout`"
296 end)
297
298 Logger.warn(Enum.join([warning_preface | pool_warnings]))
299
300 Config.put(:pools, updated_config)
301 :error
302 else
303 :ok
304 end
305 end
306
307 @spec check_activity_expiration_config() :: :ok | nil
308 def check_activity_expiration_config do
309 warning_preface = """
310 !!!DEPRECATION WARNING!!!
311 Your config is using old namespace for activity expiration configuration. Setting should work for now, but you are advised to change to new namespace to prevent possible issues later:
312 """
313
314 move_namespace_and_warn(
315 [
316 {Pleroma.ActivityExpiration, Pleroma.Workers.PurgeExpiredActivity,
317 "\n* `config :pleroma, Pleroma.ActivityExpiration` is now `config :pleroma, Pleroma.Workers.PurgeExpiredActivity`"}
318 ],
319 warning_preface
320 )
321 end
322
323 @spec check_remote_ip_plug_name() :: :ok | nil
324 def check_remote_ip_plug_name do
325 warning_preface = """
326 !!!DEPRECATION WARNING!!!
327 Your config is using old namespace for RemoteIp Plug. Setting should work for now, but you are advised to change to new namespace to prevent possible issues later:
328 """
329
330 move_namespace_and_warn(
331 [
332 {Pleroma.Plugs.RemoteIp, Pleroma.Web.Plugs.RemoteIp,
333 "\n* `config :pleroma, Pleroma.Plugs.RemoteIp` is now `config :pleroma, Pleroma.Web.Plugs.RemoteIp`"}
334 ],
335 warning_preface
336 )
337 end
338
339 @spec check_uploders_s3_public_endpoint() :: :ok | nil
340 def check_uploders_s3_public_endpoint do
341 s3_config = Pleroma.Config.get([Pleroma.Uploaders.S3])
342
343 use_old_config = Keyword.has_key?(s3_config, :public_endpoint)
344
345 if use_old_config do
346 Logger.error("""
347 !!!DEPRECATION WARNING!!!
348 Your config is using the old setting for controlling the URL of media uploaded to your S3 bucket.\n
349 Please make the following change at your earliest convenience.\n
350 \n* `config :pleroma, Pleroma.Uploaders.S3, public_endpoint` is now equal to:
351 \n* `config :pleroma, Pleroma.Upload, base_url`
352 """)
353
354 :error
355 else
356 :ok
357 end
358 end
359
360 @spec check_old_chat_shoutbox() :: :ok | nil
361 def check_old_chat_shoutbox do
362 instance_config = Pleroma.Config.get([:instance])
363 chat_config = Pleroma.Config.get([:chat]) || []
364
365 use_old_config =
366 Keyword.has_key?(instance_config, :chat_limit) or
367 Keyword.has_key?(chat_config, :enabled)
368
369 if use_old_config do
370 Logger.error("""
371 !!!DEPRECATION WARNING!!!
372 Your config is using the old namespace for the Shoutbox configuration. You need to convert to the new namespace. e.g.,
373 \n* `config :pleroma, :chat, enabled` and `config :pleroma, :instance, chat_limit` are now equal to:
374 \n* `config :pleroma, :shout, enabled` and `config :pleroma, :shout, limit`
375 """)
376
377 :error
378 else
379 :ok
380 end
381 end
382 end