From: Justin Wind <justin.wind+git@gmail.com>
Date: Sat, 16 Mar 2024 20:51:31 +0000 (-0700)
Subject: use existing auth db method for identifier creation
X-Git-Tag: v1.4.0~3
X-Git-Url: http://git.squeep.com/?p=squeep-authentication-module;a=commitdiff_plain;h=54ca04e330d14a12344ddc2b161c1d9b55bfd7d7

use existing auth db method for identifier creation
---

diff --git a/lib/authenticator.js b/lib/authenticator.js
index 7390db5..36c1574 100644
--- a/lib/authenticator.js
+++ b/lib/authenticator.js
@@ -33,7 +33,7 @@ class Authenticator {
    * @property {(DBContextExec) => Promise<any>} context
    * @property {(dbCtx: any, identifier: String) => Promise<AuthInfo> } authenticationGet
    * @property {(dbCtx: any, identifier: String) => Promise<void>} authenticationSuccess
-   * @property {(dbCtx: any, identifier: String, credential: String, otpKey: String=) => Promise<void>} authenticationInsertIdentifier
+   * @property {(dbCtx: any, identifier: String, credential: String, otpKey: String=) => Promise<void>} authenticationUpsert
    * @property {(dbCtx: any, identifier: String, otpKey: String) => Promise<void>} authenticationUpdateOTPKey
    * @property {(dbCtx: any, identifier: String, credential: AuthInfo) => Promise<void>} authenticationUpdateCredential
    */
@@ -117,7 +117,7 @@ class Authenticator {
     const _scope = _fileScope('createIdentifier');
     try {
       const secureCredential = await this._secureCredential(credential);
-      await this.db.authenticationInsertIdentifier(dbCtx, identifier, secureCredential, otpKey);
+      await this.db.authenticationUpsert(dbCtx, identifier, secureCredential, otpKey);
     } catch (e) {
       this.logger.error(_scope, 'failed', { error: e, identifier });
       throw e;
diff --git a/test/lib/authenticator.js b/test/lib/authenticator.js
index dea4a84..534fd02 100644
--- a/test/lib/authenticator.js
+++ b/test/lib/authenticator.js
@@ -60,18 +60,18 @@ describe('Authenticator', function () {
     it('covers success', async function () {
       const otpKey = '1234567890123456789012';
       await authenticator.createIdentifier(dbCtx, identifier, credential, otpKey);
-      assert(authenticator.db.authenticationInsertIdentifier.called);
+      assert(authenticator.db.authenticationUpsert.called);
     });
     it('covers failure', async function () {
       const expected = new Error('blah');
-      await authenticator.db.authenticationInsertIdentifier.rejects(expected);
+      await authenticator.db.authenticationUpsert.rejects(expected);
       // assert.rejects was not happy to handle this for some reason
       try {
         await authenticator.createIdentifier(dbCtx, identifier, credential);
         assert.fail('no expecte exception');
       } catch (e) {
         assert.deepStrictEqual(e, expected);
-        assert(authenticator.db.authenticationInsertIdentifier.called);
+        assert(authenticator.db.authenticationUpsert.called);
         assert(authenticator.logger.error.called);
         }
     });
diff --git a/test/stub-db.js b/test/stub-db.js
index 62f5f3d..0df6b9e 100644
--- a/test/stub-db.js
+++ b/test/stub-db.js
@@ -10,7 +10,7 @@ const spyFns = [
 
 const stubFns = [
   'authenticationGet',
-  'authenticationInsertIdentifier',
+  'authenticationUpsert',
   'authenticationSuccess',
   'authenticationUpdateCredential',
   'authenticationUpdateOTPKey',