XML: use try/catch with XPath functions
authorWilliam Pitcock <nenolod@dereferenced.org>
Tue, 3 Apr 2018 19:43:59 +0000 (19:43 +0000)
committerWilliam Pitcock <nenolod@dereferenced.org>
Sat, 7 Apr 2018 03:56:09 +0000 (22:56 -0500)
lib/pleroma/web/xml/xml.ex

index b85712d6519f9dfea3138cddc81c608de01db715..8b609f6958b0bb8c6be7daabfeac99904d2eb71c 100644 (file)
@@ -4,14 +4,20 @@ defmodule Pleroma.Web.XML do
   def string_from_xpath(_, :error), do: nil
 
   def string_from_xpath(xpath, doc) do
-    {:xmlObj, :string, res} = :xmerl_xpath.string('string(#{xpath})', doc)
+    try do
+      {:xmlObj, :string, res} = :xmerl_xpath.string('string(#{xpath})', doc)
 
-    res =
-      res
-      |> to_string
-      |> String.trim()
+      res =
+        res
+        |> to_string
+        |> String.trim()
 
-    if res == "", do: nil, else: res
+      if res == "", do: nil, else: res
+    catch
+      e ->
+        Logger.debug("Couldn't find xpath #{xpath} in XML doc")
+        nil
+    end
   end
 
   def parse_document(text) do