Merge branch 'features/cleanup-incoming-actor' into 'develop'
authorrinpatch <rinpatch@sdf.org>
Mon, 20 Jan 2020 10:25:17 +0000 (10:25 +0000)
committerrinpatch <rinpatch@sdf.org>
Mon, 20 Jan 2020 10:25:17 +0000 (10:25 +0000)
transmogrifier.ex: simplify handle_incoming of actors

See merge request pleroma/pleroma!2114

lib/pleroma/web/activity_pub/transmogrifier.ex

index 3fa789d53b3ce2f9836932b095f10d2b0810e441..2b8bfc3bd2c00c179f2af1e3d216f56a8ff7a2be 100644 (file)
@@ -658,24 +658,8 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
     with %User{ap_id: ^actor_id} = actor <- User.get_cached_by_ap_id(object["id"]) do
       {:ok, new_user_data} = ActivityPub.user_data_from_user_object(object)
 
-      locked = new_user_data[:locked] || false
-      attachment = get_in(new_user_data, [:source_data, "attachment"]) || []
-      invisible = new_user_data[:invisible] || false
-
-      fields =
-        attachment
-        |> Enum.filter(fn %{"type" => t} -> t == "PropertyValue" end)
-        |> Enum.map(fn fields -> Map.take(fields, ["name", "value"]) end)
-
-      update_data =
-        new_user_data
-        |> Map.take([:avatar, :banner, :bio, :name, :also_known_as])
-        |> Map.put(:fields, fields)
-        |> Map.put(:locked, locked)
-        |> Map.put(:invisible, invisible)
-
       actor
-      |> User.upgrade_changeset(update_data, true)
+      |> User.upgrade_changeset(new_user_data, true)
       |> User.update_and_set_cache()
 
       ActivityPub.update(%{