Fix a bug where reblogs were displayed under the wrong user.
authorPhil Hagelberg <phil@hagelb.org>
Thu, 31 Oct 2019 03:21:10 +0000 (20:21 -0700)
committerPhil Hagelberg <phil@hagelb.org>
Sun, 10 Nov 2019 02:08:08 +0000 (18:08 -0800)
lib/pleroma/web/static_fe/static_fe_controller.ex

index d2e72b47642da6e50f75639b76b0c6391cba3c63..9b565d07d5fcb1081ae1f5ba8f043de819f5cf96 100644 (file)
@@ -34,7 +34,9 @@ defmodule Pleroma.Web.StaticFE.StaticFEController do
     }
   end
 
-  def represent(%Activity{} = activity, %User{} = user, selected) do
+  def represent(%Activity{} = activity, selected) do
+    {:ok, user} = User.get_or_fetch(activity.object.data["actor"])
+
     %{
       user: user,
       title: get_title(activity.object),
@@ -48,11 +50,6 @@ defmodule Pleroma.Web.StaticFE.StaticFEController do
     }
   end
 
-  def represent(%Activity{} = activity, selected) do
-    {:ok, user} = User.get_or_fetch(activity.data["actor"])
-    represent(activity, user, selected)
-  end
-
   def show_notice(%{assigns: %{notice_id: notice_id}} = conn, _params) do
     instance_name = Pleroma.Config.get([:instance, :name], "Pleroma")
     activity = Activity.get_by_id_with_object(notice_id)
@@ -73,7 +70,7 @@ defmodule Pleroma.Web.StaticFE.StaticFEController do
 
     timeline =
       for activity <- ActivityPub.fetch_user_activities(user, nil, %{}) do
-        represent(activity, user, false)
+        represent(activity, false)
       end
 
     render(conn, "profile.html", %{user: user, timeline: timeline, instance_name: instance_name})