X-Git-Url: http://git.squeep.com/?a=blobdiff_plain;f=test%2Fnotification_test.exs;h=a36ed5bb8471815a3c5a2ca639b2a38eaaacf79e;hb=b4bd5e40e491c8b777c75ec4f096c0c466a6b4e2;hp=0a44622416d3e000b5e7ef67728e7d02c83492a3;hpb=5e37adedfb718264fbc3eb3353ccee5244e82a89;p=akkoma

diff --git a/test/notification_test.exs b/test/notification_test.exs
index 0a4462241..a36ed5bb8 100644
--- a/test/notification_test.exs
+++ b/test/notification_test.exs
@@ -1,7 +1,9 @@
 defmodule Pleroma.NotificationTest do
   use Pleroma.DataCase
   alias Pleroma.Web.TwitterAPI.TwitterAPI
+  alias Pleroma.Web.CommonAPI
   alias Pleroma.{User, Notification}
+  alias Pleroma.Web.ActivityPub.Transmogrifier
   import Pleroma.Factory
 
   describe "create_notifications" do
@@ -10,7 +12,10 @@ defmodule Pleroma.NotificationTest do
       other_user = insert(:user)
       third_user = insert(:user)
 
-      {:ok, activity} = TwitterAPI.create_status(user, %{"status" => "hey @#{other_user.nickname} and @#{third_user.nickname}"})
+      {:ok, activity} =
+        TwitterAPI.create_status(user, %{
+          "status" => "hey @#{other_user.nickname} and @#{third_user.nickname}"
+        })
 
       {:ok, [notification, other_notification]} = Notification.create_notifications(activity)
 
@@ -30,6 +35,13 @@ defmodule Pleroma.NotificationTest do
 
       assert nil == Notification.create_notification(activity, user)
     end
+
+    test "it doesn't create a notification for user if he is the activity author" do
+      activity = insert(:note_activity)
+      author = User.get_by_ap_id(activity.data["actor"])
+
+      assert nil == Notification.create_notification(activity, author)
+    end
   end
 
   describe "get notification" do
@@ -37,7 +49,9 @@ defmodule Pleroma.NotificationTest do
       user = insert(:user)
       other_user = insert(:user)
 
-      {:ok, activity} = TwitterAPI.create_status(user, %{"status" => "hey @#{other_user.nickname}"})
+      {:ok, activity} =
+        TwitterAPI.create_status(user, %{"status" => "hey @#{other_user.nickname}"})
+
       {:ok, [notification]} = Notification.create_notifications(activity)
       {:ok, notification} = Notification.get(other_user, notification.id)
 
@@ -48,9 +62,11 @@ defmodule Pleroma.NotificationTest do
       user = insert(:user)
       other_user = insert(:user)
 
-      {:ok, activity} = TwitterAPI.create_status(user, %{"status" => "hey @#{other_user.nickname}"})
+      {:ok, activity} =
+        TwitterAPI.create_status(user, %{"status" => "hey @#{other_user.nickname}"})
+
       {:ok, [notification]} = Notification.create_notifications(activity)
-      {:error, notification} = Notification.get(user, notification.id)
+      {:error, _notification} = Notification.get(user, notification.id)
     end
   end
 
@@ -59,7 +75,9 @@ defmodule Pleroma.NotificationTest do
       user = insert(:user)
       other_user = insert(:user)
 
-      {:ok, activity} = TwitterAPI.create_status(user, %{"status" => "hey @#{other_user.nickname}"})
+      {:ok, activity} =
+        TwitterAPI.create_status(user, %{"status" => "hey @#{other_user.nickname}"})
+
       {:ok, [notification]} = Notification.create_notifications(activity)
       {:ok, notification} = Notification.dismiss(other_user, notification.id)
 
@@ -70,9 +88,11 @@ defmodule Pleroma.NotificationTest do
       user = insert(:user)
       other_user = insert(:user)
 
-      {:ok, activity} = TwitterAPI.create_status(user, %{"status" => "hey @#{other_user.nickname}"})
+      {:ok, activity} =
+        TwitterAPI.create_status(user, %{"status" => "hey @#{other_user.nickname}"})
+
       {:ok, [notification]} = Notification.create_notifications(activity)
-      {:error, notification} = Notification.dismiss(user, notification.id)
+      {:error, _notification} = Notification.dismiss(user, notification.id)
     end
   end
 
@@ -82,9 +102,18 @@ defmodule Pleroma.NotificationTest do
       other_user = insert(:user)
       third_user = insert(:user)
 
-      {:ok, activity} = TwitterAPI.create_status(user, %{"status" => "hey @#{other_user.nickname} and @#{third_user.nickname} !"})
+      {:ok, activity} =
+        TwitterAPI.create_status(user, %{
+          "status" => "hey @#{other_user.nickname} and @#{third_user.nickname} !"
+        })
+
       {:ok, _notifs} = Notification.create_notifications(activity)
-      {:ok, activity} = TwitterAPI.create_status(user, %{"status" => "hey again @#{other_user.nickname} and @#{third_user.nickname} !"})
+
+      {:ok, activity} =
+        TwitterAPI.create_status(user, %{
+          "status" => "hey again @#{other_user.nickname} and @#{third_user.nickname} !"
+        })
+
       {:ok, _notifs} = Notification.create_notifications(activity)
       Notification.clear(other_user)
 
@@ -92,4 +121,253 @@ defmodule Pleroma.NotificationTest do
       assert Notification.for_user(third_user) != []
     end
   end
+
+  describe "set_read_up_to()" do
+    test "it sets all notifications as read up to a specified notification ID" do
+      user = insert(:user)
+      other_user = insert(:user)
+
+      {:ok, activity} =
+        TwitterAPI.create_status(user, %{
+          "status" => "hey @#{other_user.nickname}!"
+        })
+
+      {:ok, activity} =
+        TwitterAPI.create_status(user, %{
+          "status" => "hey again @#{other_user.nickname}!"
+        })
+
+      [n2, n1] = notifs = Notification.for_user(other_user)
+      assert length(notifs) == 2
+
+      assert n2.id > n1.id
+
+      {:ok, activity} =
+        TwitterAPI.create_status(user, %{
+          "status" => "hey yet again @#{other_user.nickname}!"
+        })
+
+      Notification.set_read_up_to(other_user, n2.id)
+
+      [n3, n2, n1] = notifs = Notification.for_user(other_user)
+
+      assert n1.seen == true
+      assert n2.seen == true
+      assert n3.seen == false
+    end
+  end
+
+  describe "notification target determination" do
+    test "it sends notifications to addressed users in new messages" do
+      user = insert(:user)
+      other_user = insert(:user)
+
+      {:ok, activity} =
+        CommonAPI.post(user, %{
+          "status" => "hey @#{other_user.nickname}!"
+        })
+
+      assert other_user in Notification.get_notified_from_activity(activity)
+    end
+
+    test "it sends notifications to mentioned users in new messages" do
+      user = insert(:user)
+      other_user = insert(:user)
+
+      create_activity = %{
+        "@context" => "https://www.w3.org/ns/activitystreams",
+        "type" => "Create",
+        "to" => ["https://www.w3.org/ns/activitystreams#Public"],
+        "actor" => user.ap_id,
+        "object" => %{
+          "type" => "Note",
+          "content" => "message with a Mention tag, but no explicit tagging",
+          "tag" => [
+            %{
+              "type" => "Mention",
+              "href" => other_user.ap_id,
+              "name" => other_user.nickname
+            }
+          ],
+          "attributedTo" => user.ap_id
+        }
+      }
+
+      {:ok, activity} = Transmogrifier.handle_incoming(create_activity)
+
+      assert other_user in Notification.get_notified_from_activity(activity)
+    end
+
+    test "it does not send notifications to users who are only cc in new messages" do
+      user = insert(:user)
+      other_user = insert(:user)
+
+      create_activity = %{
+        "@context" => "https://www.w3.org/ns/activitystreams",
+        "type" => "Create",
+        "to" => ["https://www.w3.org/ns/activitystreams#Public"],
+        "cc" => [other_user.ap_id],
+        "actor" => user.ap_id,
+        "object" => %{
+          "type" => "Note",
+          "content" => "hi everyone",
+          "attributedTo" => user.ap_id
+        }
+      }
+
+      {:ok, activity} = Transmogrifier.handle_incoming(create_activity)
+
+      assert other_user not in Notification.get_notified_from_activity(activity)
+    end
+
+    test "it does not send notification to mentioned users in likes" do
+      user = insert(:user)
+      other_user = insert(:user)
+      third_user = insert(:user)
+
+      {:ok, activity_one} =
+        CommonAPI.post(user, %{
+          "status" => "hey @#{other_user.nickname}!"
+        })
+
+      {:ok, activity_two, _} = CommonAPI.favorite(activity_one.id, third_user)
+
+      assert other_user not in Notification.get_notified_from_activity(activity_two)
+    end
+
+    test "it does not send notification to mentioned users in announces" do
+      user = insert(:user)
+      other_user = insert(:user)
+      third_user = insert(:user)
+
+      {:ok, activity_one} =
+        CommonAPI.post(user, %{
+          "status" => "hey @#{other_user.nickname}!"
+        })
+
+      {:ok, activity_two, _} = CommonAPI.repeat(activity_one.id, third_user)
+
+      assert other_user not in Notification.get_notified_from_activity(activity_two)
+    end
+  end
+
+  describe "notification lifecycle" do
+    test "liking an activity results in 1 notification, then 0 if the activity is deleted" do
+      user = insert(:user)
+      other_user = insert(:user)
+
+      {:ok, activity} = CommonAPI.post(user, %{"status" => "test post"})
+
+      assert length(Notification.for_user(user)) == 0
+
+      {:ok, _, _} = CommonAPI.favorite(activity.id, other_user)
+
+      assert length(Notification.for_user(user)) == 1
+
+      {:ok, _} = CommonAPI.delete(activity.id, user)
+
+      assert length(Notification.for_user(user)) == 0
+    end
+
+    test "liking an activity results in 1 notification, then 0 if the activity is unliked" do
+      user = insert(:user)
+      other_user = insert(:user)
+
+      {:ok, activity} = CommonAPI.post(user, %{"status" => "test post"})
+
+      assert length(Notification.for_user(user)) == 0
+
+      {:ok, _, _} = CommonAPI.favorite(activity.id, other_user)
+
+      assert length(Notification.for_user(user)) == 1
+
+      {:ok, _, _, _} = CommonAPI.unfavorite(activity.id, other_user)
+
+      assert length(Notification.for_user(user)) == 0
+    end
+
+    test "repeating an activity results in 1 notification, then 0 if the activity is deleted" do
+      user = insert(:user)
+      other_user = insert(:user)
+
+      {:ok, activity} = CommonAPI.post(user, %{"status" => "test post"})
+
+      assert length(Notification.for_user(user)) == 0
+
+      {:ok, _, _} = CommonAPI.repeat(activity.id, other_user)
+
+      assert length(Notification.for_user(user)) == 1
+
+      {:ok, _} = CommonAPI.delete(activity.id, user)
+
+      assert length(Notification.for_user(user)) == 0
+    end
+
+    test "repeating an activity results in 1 notification, then 0 if the activity is unrepeated" do
+      user = insert(:user)
+      other_user = insert(:user)
+
+      {:ok, activity} = CommonAPI.post(user, %{"status" => "test post"})
+
+      assert length(Notification.for_user(user)) == 0
+
+      {:ok, _, _} = CommonAPI.repeat(activity.id, other_user)
+
+      assert length(Notification.for_user(user)) == 1
+
+      {:ok, _, _} = CommonAPI.unrepeat(activity.id, other_user)
+
+      assert length(Notification.for_user(user)) == 0
+    end
+
+    test "liking an activity which is already deleted does not generate a notification" do
+      user = insert(:user)
+      other_user = insert(:user)
+
+      {:ok, activity} = CommonAPI.post(user, %{"status" => "test post"})
+
+      assert length(Notification.for_user(user)) == 0
+
+      {:ok, _deletion_activity} = CommonAPI.delete(activity.id, user)
+
+      assert length(Notification.for_user(user)) == 0
+
+      {:error, _} = CommonAPI.favorite(activity.id, other_user)
+
+      assert length(Notification.for_user(user)) == 0
+    end
+
+    test "repeating an activity which is already deleted does not generate a notification" do
+      user = insert(:user)
+      other_user = insert(:user)
+
+      {:ok, activity} = CommonAPI.post(user, %{"status" => "test post"})
+
+      assert length(Notification.for_user(user)) == 0
+
+      {:ok, _deletion_activity} = CommonAPI.delete(activity.id, user)
+
+      assert length(Notification.for_user(user)) == 0
+
+      {:error, _} = CommonAPI.repeat(activity.id, other_user)
+
+      assert length(Notification.for_user(user)) == 0
+    end
+
+    test "replying to a deleted post without tagging does not generate a notification" do
+      user = insert(:user)
+      other_user = insert(:user)
+
+      {:ok, activity} = CommonAPI.post(user, %{"status" => "test post"})
+      {:ok, _deletion_activity} = CommonAPI.delete(activity.id, user)
+
+      {:ok, _reply_activity} =
+        CommonAPI.post(other_user, %{
+          "status" => "test reply",
+          "in_reply_to_status_id" => activity.id
+        })
+
+      assert length(Notification.for_user(user)) == 0
+    end
+  end
 end