X-Git-Url: http://git.squeep.com/?a=blobdiff_plain;f=lib%2Fpleroma%2Fweb%2Fmetadata%2Fopengraph.ex;h=a48788969431349cb341e7f27038831e51c9986a;hb=0256bd2f1dfb121a4d751906a202e3db482500a6;hp=1e3af947d6755d27b04f0bdd4bd53f5ce779d102;hpb=9aa69e12b87a892d33d1bf4f0d556752391b465a;p=akkoma
diff --git a/lib/pleroma/web/metadata/opengraph.ex b/lib/pleroma/web/metadata/opengraph.ex
index 1e3af947d..a48788969 100644
--- a/lib/pleroma/web/metadata/opengraph.ex
+++ b/lib/pleroma/web/metadata/opengraph.ex
@@ -1,3 +1,6 @@
+# Pleroma: A lightweight social networking server
+# Copyright © 2017-2019 Pleroma Authors
+# SPDX-License-Identifier: AGPL-3.0-only
defmodule Pleroma.Web.Metadata.Providers.OpenGraph do
alias Pleroma.Web.Metadata.Providers.Provider
alias Pleroma.{HTML, Formatter, User}
@@ -6,30 +9,38 @@ defmodule Pleroma.Web.Metadata.Providers.OpenGraph do
@behaviour Provider
@impl Provider
- def build_tags(%{activity: activity, user: user}) do
- with truncated_content = scrub_html_and_truncate(activity.data["object"]["content"]) do
- attachments = build_attachments(activity)
+ def build_tags(%{activity: %{data: %{"object" => %{"id" => object_id}}} = activity, user: user}) do
+ attachments = build_attachments(activity)
- [
- {:meta,
- [
- property: "og:title",
- content: user_name_string(user)
- ], []},
- {:meta, [property: "og:url", content: activity.data["id"]], []},
- {:meta, [property: "og:description", content: truncated_content], []}
- ] ++
- if attachments == [] or
- Enum.any?(activity.data["object"]["tag"], fn tag -> tag == "nsfw" end) do
- [
- {:meta, [property: "og:image", content: attachment_url(User.avatar_url(user))], []},
- {:meta, [property: "og:image:width", content: 120], []},
- {:meta, [property: "og:image:height", content: 120], []}
- ]
- else
- attachments
- end
- end
+ # Most previews only show og:title which is inconvenient. Instagram
+ # hacks this by putting the description in the title and making the
+ # description longer prefixed by how many likes and shares the post
+ # has. Here we use the descriptive nickname in the title, and expand
+ # the full account & nickname in the description. We also use the cute^Wevil
+ # smart quotes around the status text like Instagram, too.
+ [
+ {:meta,
+ [
+ property: "og:title",
+ content: "#{user.name}: " <> "â" <> scrub_html_and_truncate(activity) <> "â"
+ ], []},
+ {:meta, [property: "og:url", content: object_id], []},
+ {:meta,
+ [
+ property: "og:description",
+ content: "#{user_name_string(user)}: " <> "â" <> scrub_html_and_truncate(activity) <> "â"
+ ], []},
+ {:meta, [property: "og:type", content: "website"], []}
+ ] ++
+ if attachments == [] do
+ [
+ {:meta, [property: "og:image", content: attachment_url(User.avatar_url(user))], []},
+ {:meta, [property: "og:image:width", content: 150], []},
+ {:meta, [property: "og:image:height", content: 150], []}
+ ]
+ else
+ attachments
+ end
end
@impl Provider
@@ -43,35 +54,67 @@ defmodule Pleroma.Web.Metadata.Providers.OpenGraph do
], []},
{:meta, [property: "og:url", content: User.profile_url(user)], []},
{:meta, [property: "og:description", content: truncated_bio], []},
+ {:meta, [property: "og:type", content: "website"], []},
{:meta, [property: "og:image", content: attachment_url(User.avatar_url(user))], []},
- {:meta, [property: "og:image:width", content: 120], []},
- {:meta, [property: "og:image:height", content: 120], []}
+ {:meta, [property: "og:image:width", content: 150], []},
+ {:meta, [property: "og:image:height", content: 150], []}
]
end
end
- defp build_attachments(activity) do
- Enum.reduce(activity.data["object"]["attachment"], [], fn attachment, acc ->
+ defp build_attachments(%{data: %{"object" => %{"attachment" => attachments}}} = _activity) do
+ Enum.reduce(attachments, [], fn attachment, acc ->
rendered_tags =
- Enum.map(attachment["url"], fn url ->
+ Enum.reduce(attachment["url"], [], fn url, acc ->
media_type =
Enum.find(["image", "audio", "video"], fn media_type ->
String.starts_with?(url["mediaType"], media_type)
end)
- if media_type do
- {:meta, [property: "og:" <> media_type, content: attachment_url(url["href"])], []}
- else
- nil
+ # TODO: Add additional properties to objects when we have the data available.
+ # Also, Whatsapp only wants JPEG or PNGs. It seems that if we add a second og:image
+ # object when a Video or GIF is attached it will display that in the Whatsapp Rich Preview.
+ case media_type do
+ "audio" ->
+ [
+ {:meta, [property: "og:" <> media_type, content: attachment_url(url["href"])], []}
+ | acc
+ ]
+
+ "image" ->
+ [
+ {:meta, [property: "og:" <> media_type, content: attachment_url(url["href"])],
+ []},
+ {:meta, [property: "og:image:width", content: 150], []},
+ {:meta, [property: "og:image:height", content: 150], []}
+ | acc
+ ]
+
+ "video" ->
+ [
+ {:meta, [property: "og:" <> media_type, content: attachment_url(url["href"])], []}
+ | acc
+ ]
+
+ _ ->
+ acc
end
end)
- Enum.reject(rendered_tags, &is_nil/1)
acc ++ rendered_tags
end)
end
- defp scrub_html_and_truncate(content) do
+ defp scrub_html_and_truncate(%{data: %{"object" => %{"content" => content}}} = activity) do
+ content
+ # html content comes from DB already encoded, decode first and scrub after
+ |> HtmlEntities.decode()
+ |> String.replace(~r/
/, " ")
+ |> HTML.get_cached_stripped_html_for_object(activity, __MODULE__)
+ |> Formatter.truncate()
+ end
+
+ defp scrub_html_and_truncate(content) when is_binary(content) do
content
# html content comes from DB already encoded, decode first and scrub after
|> HtmlEntities.decode()