X-Git-Url: http://git.squeep.com/?a=blobdiff_plain;f=lib%2Fpleroma%2Fplugs%2Fhttp_signature.ex;h=21c1957135c0e5542847e7e2e4aa58682e5972b2;hb=8f93d4c42366ccce1949717ad2a9e1de0f91011b;hp=af160f3ee4fe3ec979795e32f12eb14c830bfa3f;hpb=a9f78fe8e07df1fdd51f235090cd35b09c73aa34;p=akkoma diff --git a/lib/pleroma/plugs/http_signature.ex b/lib/pleroma/plugs/http_signature.ex index af160f3ee..21c195713 100644 --- a/lib/pleroma/plugs/http_signature.ex +++ b/lib/pleroma/plugs/http_signature.ex @@ -1,4 +1,9 @@ +# Pleroma: A lightweight social networking server +# Copyright © 2017-2019 Pleroma Authors +# SPDX-License-Identifier: AGPL-3.0-only + defmodule Pleroma.Web.Plugs.HTTPSignaturePlug do + alias Pleroma.Web.ActivityPub.Utils alias Pleroma.Web.HTTPSignatures import Plug.Conn require Logger @@ -7,26 +12,43 @@ defmodule Pleroma.Web.Plugs.HTTPSignaturePlug do options end - def call(%{assigns: %{valid_signature: true}} = conn, opts) do + def call(%{assigns: %{valid_signature: true}} = conn, _opts) do conn end - def call(conn, opts) do - user = conn.params["actor"] + def call(conn, _opts) do + user = Utils.get_ap_id(conn.params["actor"]) Logger.debug("Checking sig for #{user}") + [signature | _] = get_req_header(conn, "signature") + + cond do + signature && String.contains?(signature, user) -> + # set (request-target) header to the appropriate value + # we also replace the digest header with the one we computed + conn = + conn + |> put_req_header( + "(request-target)", + String.downcase("#{conn.method}") <> " #{conn.request_path}" + ) + + conn = + if conn.assigns[:digest] do + conn + |> put_req_header("digest", conn.assigns[:digest]) + else + conn + end + + assign(conn, :valid_signature, HTTPSignatures.validate_conn(conn)) + + signature -> + Logger.debug("Signature not from actor") + assign(conn, :valid_signature, false) - if get_req_header(conn, "signature") do - conn = + true -> + Logger.debug("No signature header!") conn - |> put_req_header( - "(request-target)", - String.downcase("#{conn.method}") <> " #{conn.request_path}" - ) - - assign(conn, :valid_signature, HTTPSignatures.validate_conn(conn)) - else - Logger.debug("No signature header!") - conn end end end