X-Git-Url: http://git.squeep.com/?a=blobdiff_plain;ds=sidebyside;f=lib%2Fpleroma%2Fweb%2Fmastodon_api%2Fcontrollers%2Fmastodon_api_controller.ex;h=9cf682c7b8a5dd163b35701ef805c2c8d927fffd;hb=755f58168bb2b6b979c6f5d36f7eff56d2305911;hp=32077d4205b793abfe378de463abf53d3e1cea68;hpb=06b3bb54c5567fe82ad2a015673fffba667997ee;p=akkoma
diff --git a/lib/pleroma/web/mastodon_api/controllers/mastodon_api_controller.ex b/lib/pleroma/web/mastodon_api/controllers/mastodon_api_controller.ex
index 32077d420..9cf682c7b 100644
--- a/lib/pleroma/web/mastodon_api/controllers/mastodon_api_controller.ex
+++ b/lib/pleroma/web/mastodon_api/controllers/mastodon_api_controller.ex
@@ -1,86 +1,35 @@
# Pleroma: A lightweight social networking server
-# Copyright © 2017-2019 Pleroma Authors
+# Copyright © 2017-2020 Pleroma Authors
# SPDX-License-Identifier: AGPL-3.0-only
defmodule Pleroma.Web.MastodonAPI.MastodonAPIController do
- use Pleroma.Web, :controller
-
- require Logger
-
- alias Pleroma.Plugs.OAuthScopesPlug
- @unauthenticated_access %{fallback: :proceed_unauthenticated, scopes: []}
-
- # Note: :index action handles attempt of unauthenticated access to private instance with redirect
- plug(
- OAuthScopesPlug,
- Map.merge(@unauthenticated_access, %{scopes: ["read"], skip_instance_privacy_check: true})
- when action == :index
- )
-
- plug(
- OAuthScopesPlug,
- %{scopes: ["read"]} when action in [:suggestions, :verify_app_credentials]
- )
-
- plug(OAuthScopesPlug, %{scopes: ["write:accounts"]} when action == :put_settings)
-
- plug(
- OAuthScopesPlug,
- %{@unauthenticated_access | scopes: ["read:statuses"]} when action == :get_poll
- )
-
- plug(OAuthScopesPlug, %{scopes: ["write:statuses"]} when action == :poll_vote)
+ @moduledoc """
+ Contains stubs for unimplemented Mastodon API endpoints.
- plug(OAuthScopesPlug, %{scopes: ["read:favourites"]} when action == :favourites)
+ Note: instead of routing directly to this controller's action,
+ it's preferable to define an action in relevant (non-generic) controller,
+ set up OAuth rules for it and call this controller's function from it.
+ """
- plug(OAuthScopesPlug, %{scopes: ["write:media"]} when action in [:upload, :update_media])
-
- plug(
- OAuthScopesPlug,
- %{scopes: ["follow", "read:blocks"]} when action == :blocks
- )
-
- # To do: POST /api/v1/follows is not present in Mastodon; consider removing the action
- plug(
- OAuthScopesPlug,
- %{scopes: ["follow", "write:follows"]} when action == :follows
- )
-
- plug(OAuthScopesPlug, %{scopes: ["follow", "read:mutes"]} when action == :mutes)
+ use Pleroma.Web, :controller
- # Note: scope not present in Mastodon: read:bookmarks
- plug(OAuthScopesPlug, %{scopes: ["read:bookmarks"]} when action == :bookmarks)
+ require Logger
- # An extra safety measure for possible actions not guarded by OAuth permissions specification
plug(
- Pleroma.Plugs.EnsurePublicOrAuthenticatedPlug
- when action not in [
- :create_app,
- :index,
- :login,
- :logout,
- :password_reset,
- :masto_instance,
- :peers,
- :custom_emojis
- ]
+ :skip_plug,
+ [Pleroma.Web.Plugs.OAuthScopesPlug, Pleroma.Web.Plugs.EnsurePublicOrAuthenticatedPlug]
+ when action in [:empty_array, :empty_object]
)
- plug(RateLimiter, :password_reset when action == :password_reset)
-
- @local_mastodon_name "Mastodon-Local"
-
action_fallback(Pleroma.Web.MastodonAPI.FallbackController)
- # Stubs for unimplemented mastodon api
- #
def empty_array(conn, _) do
- Logger.debug("Unimplemented, returning an empty array")
+ Logger.debug("Unimplemented, returning an empty array (list)")
json(conn, [])
end
def empty_object(conn, _) do
- Logger.debug("Unimplemented, returning an empty object")
+ Logger.debug("Unimplemented, returning an empty object (map)")
json(conn, %{})
end
end