Merge branch 'feature/hellthread-filter-improvements' into 'develop'
[akkoma] / test / web / twitter_api / twitter_api_test.exs
index d4341a867d2208497e857f80cae7d1f1b4523c2d..48ddbcf506ecd76ef79b1853df6ea95c08b784a8 100644 (file)
@@ -1,17 +1,19 @@
+# Pleroma: A lightweight social networking server
+# Copyright © 2017-2018 Pleroma Authors <https://pleroma.social/>
+# SPDX-License-Identifier: AGPL-3.0-only
+
 defmodule Pleroma.Web.TwitterAPI.TwitterAPITest do
   use Pleroma.DataCase
-  alias Pleroma.Builders.{UserBuilder, ActivityBuilder}
   alias Pleroma.Web.TwitterAPI.{TwitterAPI, UserView}
-  alias Pleroma.Web.CommonAPI.Utils
-  alias Pleroma.{Activity, User, Object, Repo}
-  alias Pleroma.Web.TwitterAPI.Representers.ActivityRepresenter
+  alias Pleroma.{Activity, User, Object, Repo, UserInviteToken}
   alias Pleroma.Web.ActivityPub.ActivityPub
+  alias Pleroma.Web.TwitterAPI.ActivityView
 
   import Pleroma.Factory
 
   test "create a status" do
     user = insert(:user)
-    _mentioned_user = UserBuilder.insert(%{nickname: "shp", ap_id: "shp"})
+    mentioned_user = insert(:user, %{nickname: "shp", ap_id: "shp"})
 
     object_data = %{
       "type" => "Image",
@@ -36,7 +38,7 @@ defmodule Pleroma.Web.TwitterAPI.TwitterAPITest do
     {:ok, activity = %Activity{}} = TwitterAPI.create_status(user, input)
 
     expected_text =
-      "Hello again, <span><a href='shp'>@<span>shp</span></a></span>.&lt;script&gt;&lt;/script&gt;<br>This is on another :moominmamma: line. <a href='http://localhost:4001/tag/2hu' rel='tag'>#2hu</a> <a href='http://localhost:4001/tag/epic' rel='tag'>#epic</a> <a href='http://localhost:4001/tag/phantasmagoric' rel='tag'>#phantasmagoric</a><br><a href=\"http://example.org/image.jpg\" class='attachment'>image.jpg</a>"
+      "Hello again, <span class='h-card'><a data-user='#{mentioned_user.id}' class='u-url mention' href='shp'>@<span>shp</span></a></span>.&lt;script&gt;&lt;/script&gt;<br>This is on another :moominmamma: line. <a class='hashtag' data-tag='2hu' href='http://localhost:4001/tag/2hu' rel='tag'>#2hu</a> <a class='hashtag' data-tag='epic' href='http://localhost:4001/tag/epic' rel='tag'>#epic</a> <a class='hashtag' data-tag='phantasmagoric' href='http://localhost:4001/tag/phantasmagoric' rel='tag'>#phantasmagoric</a><br><a href=\"http://example.org/image.jpg\" class='attachment'>image.jpg</a>"
 
     assert get_in(activity.data, ["object", "content"]) == expected_text
     assert get_in(activity.data, ["object", "type"]) == "Note"
@@ -49,7 +51,7 @@ defmodule Pleroma.Web.TwitterAPI.TwitterAPITest do
              "https://www.w3.org/ns/activitystreams#Public"
            )
 
-    assert Enum.member?(get_in(activity.data, ["cc"]), "shp")
+    assert Enum.member?(get_in(activity.data, ["to"]), "shp")
     assert activity.local == true
 
     assert %{"moominmamma" => "http://localhost:4001/finmoji/128px/moominmamma-128.png"} =
@@ -68,7 +70,7 @@ defmodule Pleroma.Web.TwitterAPI.TwitterAPITest do
 
     user = User.get_by_ap_id(user.ap_id)
 
-    assert user.info["note_count"] == 1
+    assert user.info.note_count == 1
   end
 
   test "create a status that is a reply" do
@@ -96,117 +98,6 @@ defmodule Pleroma.Web.TwitterAPI.TwitterAPITest do
     assert get_in(reply.data, ["object", "inReplyToStatusId"]) == activity.id
   end
 
-  test "fetch public statuses, excluding remote ones." do
-    %{public: activity, user: user} = ActivityBuilder.public_and_non_public()
-    insert(:note_activity, %{local: false})
-
-    follower = insert(:user, following: [User.ap_followers(user)])
-
-    statuses = TwitterAPI.fetch_public_statuses(follower)
-
-    assert length(statuses) == 1
-
-    assert Enum.at(statuses, 0) ==
-             ActivityRepresenter.to_map(activity, %{user: user, for: follower})
-  end
-
-  test "fetch whole known network statuses" do
-    %{public: activity, user: user} = ActivityBuilder.public_and_non_public()
-    insert(:note_activity, %{local: false})
-
-    follower = insert(:user, following: [user.follower_address])
-
-    statuses = TwitterAPI.fetch_public_and_external_statuses(follower)
-
-    assert length(statuses) == 2
-
-    assert Enum.at(statuses, 0) ==
-             ActivityRepresenter.to_map(activity, %{user: user, for: follower})
-  end
-
-  test "fetch friends' statuses" do
-    user = insert(:user, %{following: ["someguy/followers"]})
-    {:ok, activity} = ActivityBuilder.insert(%{"to" => ["someguy/followers"]})
-    {:ok, direct_activity} = ActivityBuilder.insert(%{"to" => [user.ap_id]})
-
-    statuses = TwitterAPI.fetch_friend_statuses(user)
-
-    activity_user = Repo.get_by(User, ap_id: activity.data["actor"])
-    direct_activity_user = Repo.get_by(User, ap_id: direct_activity.data["actor"])
-
-    assert length(statuses) == 2
-    assert Enum.at(statuses, 0) == ActivityRepresenter.to_map(activity, %{user: activity_user})
-
-    assert Enum.at(statuses, 1) ==
-             ActivityRepresenter.to_map(direct_activity, %{
-               user: direct_activity_user,
-               mentioned: [user]
-             })
-  end
-
-  test "fetch user's mentions" do
-    user = insert(:user)
-    {:ok, activity} = ActivityBuilder.insert(%{"to" => [user.ap_id]})
-    activity_user = Repo.get_by(User, ap_id: activity.data["actor"])
-
-    statuses = TwitterAPI.fetch_mentions(user)
-
-    assert length(statuses) == 1
-
-    assert Enum.at(statuses, 0) ==
-             ActivityRepresenter.to_map(activity, %{user: activity_user, mentioned: [user]})
-  end
-
-  test "get a user by params" do
-    user1_result = {:ok, user1} = UserBuilder.insert(%{ap_id: "some id", email: "test@pleroma"})
-
-    {:ok, user2} =
-      UserBuilder.insert(%{ap_id: "some other id", nickname: "testname2", email: "test2@pleroma"})
-
-    assert {:error, "You need to specify screen_name or user_id"} == TwitterAPI.get_user(nil, nil)
-    assert user1_result == TwitterAPI.get_user(nil, %{"user_id" => user1.id})
-    assert user1_result == TwitterAPI.get_user(nil, %{"user_id" => user1.nickname})
-    assert user1_result == TwitterAPI.get_user(nil, %{"screen_name" => user1.nickname})
-    assert user1_result == TwitterAPI.get_user(user1, nil)
-    assert user1_result == TwitterAPI.get_user(user2, %{"user_id" => user1.id})
-    assert user1_result == TwitterAPI.get_user(user2, %{"screen_name" => user1.nickname})
-
-    assert {:error, "No user with such screen_name"} ==
-             TwitterAPI.get_user(nil, %{"screen_name" => "Satan"})
-
-    assert {:error, "No user with such user_id"} == TwitterAPI.get_user(nil, %{"user_id" => 666})
-  end
-
-  test "fetch user's statuses" do
-    {:ok, user1} = UserBuilder.insert(%{ap_id: "some id", email: "test@pleroma"})
-
-    {:ok, user2} =
-      UserBuilder.insert(%{ap_id: "some other id", nickname: "testname2", email: "test2@pleroma"})
-
-    {:ok, status1} = ActivityBuilder.insert(%{"id" => 1}, %{user: user1})
-    {:ok, status2} = ActivityBuilder.insert(%{"id" => 2}, %{user: user2})
-
-    user1_statuses = TwitterAPI.fetch_user_statuses(user1, %{"actor_id" => user1.ap_id})
-
-    assert length(user1_statuses) == 1
-    assert Enum.at(user1_statuses, 0) == ActivityRepresenter.to_map(status1, %{user: user1})
-
-    user2_statuses = TwitterAPI.fetch_user_statuses(user1, %{"actor_id" => user2.ap_id})
-
-    assert length(user2_statuses) == 1
-    assert Enum.at(user2_statuses, 0) == ActivityRepresenter.to_map(status2, %{user: user2})
-  end
-
-  test "fetch a single status" do
-    {:ok, activity} = ActivityBuilder.insert()
-    {:ok, user} = UserBuilder.insert()
-    actor = Repo.get_by!(User, ap_id: activity.data["actor"])
-
-    status = TwitterAPI.fetch_status(user, activity.id)
-
-    assert status == ActivityRepresenter.to_map(activity, %{for: user, user: actor})
-  end
-
   test "Follow another user using user_id" do
     user = insert(:user)
     followed = insert(:user)
@@ -228,7 +119,7 @@ defmodule Pleroma.Web.TwitterAPI.TwitterAPITest do
     assert User.ap_followers(followed) in user.following
 
     followed = User.get_by_ap_id(followed.ap_id)
-    assert followed.info["follower_count"] == 1
+    assert followed.info.follower_count == 1
 
     {:error, msg} = TwitterAPI.follow(user, %{"screen_name" => followed.nickname})
     assert msg == "Could not follow user: #{followed.nickname} is already on your list."
@@ -278,88 +169,94 @@ defmodule Pleroma.Web.TwitterAPI.TwitterAPITest do
   test "Unblock another user using user_id" do
     unblocked = insert(:user)
     user = insert(:user)
-    User.block(user, unblocked)
+    {:ok, user, _unblocked} = TwitterAPI.block(user, %{"user_id" => unblocked.id})
 
     {:ok, user, _unblocked} = TwitterAPI.unblock(user, %{"user_id" => unblocked.id})
-    assert user.info["blocks"] == []
+    assert user.info.blocks == []
   end
 
   test "Unblock another user using screen_name" do
     unblocked = insert(:user)
     user = insert(:user)
-    User.block(user, unblocked)
+    {:ok, user, _unblocked} = TwitterAPI.block(user, %{"screen_name" => unblocked.nickname})
 
     {:ok, user, _unblocked} = TwitterAPI.unblock(user, %{"screen_name" => unblocked.nickname})
-    assert user.info["blocks"] == []
-  end
-
-  test "fetch statuses in a context using the conversation id" do
-    {:ok, user} = UserBuilder.insert()
-    {:ok, activity} = ActivityBuilder.insert(%{"type" => "Create", "context" => "2hu"})
-    {:ok, activity_two} = ActivityBuilder.insert(%{"type" => "Create", "context" => "2hu"})
-    {:ok, _activity_three} = ActivityBuilder.insert(%{"type" => "Create", "context" => "3hu"})
-
-    {:ok, object} = Object.context_mapping("2hu") |> Repo.insert()
-
-    statuses = TwitterAPI.fetch_conversation(user, object.id)
-
-    assert length(statuses) == 2
-    assert Enum.at(statuses, 1)["id"] == activity.id
-    assert Enum.at(statuses, 0)["id"] == activity_two.id
+    assert user.info.blocks == []
   end
 
   test "upload a file" do
+    user = insert(:user)
+
     file = %Plug.Upload{
       content_type: "image/jpg",
       path: Path.absname("test/fixtures/image.jpg"),
       filename: "an_image.jpg"
     }
 
-    response = TwitterAPI.upload(file)
+    response = TwitterAPI.upload(file, user)
 
     assert is_binary(response)
   end
 
-  test "it favorites a status, returns the updated status" do
+  test "it favorites a status, returns the updated activity" do
     user = insert(:user)
+    other_user = insert(:user)
     note_activity = insert(:note_activity)
-    activity_user = Repo.get_by!(User, ap_id: note_activity.data["actor"])
 
     {:ok, status} = TwitterAPI.fav(user, note_activity.id)
     updated_activity = Activity.get_by_ap_id(note_activity.data["id"])
+    assert ActivityView.render("activity.json", %{activity: updated_activity})["fave_num"] == 1
+
+    object = Object.normalize(note_activity.data["object"])
+
+    assert object.data["like_count"] == 1
+
+    assert status == updated_activity
 
-    assert status ==
-             ActivityRepresenter.to_map(updated_activity, %{user: activity_user, for: user})
+    {:ok, _status} = TwitterAPI.fav(other_user, note_activity.id)
+
+    object = Object.normalize(note_activity.data["object"])
+
+    assert object.data["like_count"] == 2
+
+    updated_activity = Activity.get_by_ap_id(note_activity.data["id"])
+    assert ActivityView.render("activity.json", %{activity: updated_activity})["fave_num"] == 2
   end
 
-  test "it unfavorites a status, returns the updated status" do
+  test "it unfavorites a status, returns the updated activity" do
     user = insert(:user)
     note_activity = insert(:note_activity)
-    activity_user = Repo.get_by!(User, ap_id: note_activity.data["actor"])
     object = Object.get_by_ap_id(note_activity.data["object"]["id"])
 
     {:ok, _like_activity, _object} = ActivityPub.like(user, object)
     updated_activity = Activity.get_by_ap_id(note_activity.data["id"])
 
-    assert ActivityRepresenter.to_map(updated_activity, %{user: activity_user, for: user})[
-             "fave_num"
-           ] == 1
+    assert ActivityView.render("activity.json", activity: updated_activity)["fave_num"] == 1
 
-    {:ok, status} = TwitterAPI.unfav(user, note_activity.id)
+    {:ok, activity} = TwitterAPI.unfav(user, note_activity.id)
 
-    assert status["fave_num"] == 0
+    assert ActivityView.render("activity.json", activity: activity)["fave_num"] == 0
   end
 
   test "it retweets a status and returns the retweet" do
     user = insert(:user)
     note_activity = insert(:note_activity)
-    activity_user = Repo.get_by!(User, ap_id: note_activity.data["actor"])
 
     {:ok, status} = TwitterAPI.repeat(user, note_activity.id)
     updated_activity = Activity.get_by_ap_id(note_activity.data["id"])
 
-    assert status ==
-             ActivityRepresenter.to_map(updated_activity, %{user: activity_user, for: user})
+    assert status == updated_activity
+  end
+
+  test "it unretweets an already retweeted status" do
+    user = insert(:user)
+    note_activity = insert(:note_activity)
+
+    {:ok, _status} = TwitterAPI.repeat(user, note_activity.id)
+    {:ok, status} = TwitterAPI.unrepeat(user, note_activity.id)
+    updated_activity = Activity.get_by_ap_id(note_activity.data["id"])
+
+    assert status == updated_activity
   end
 
   test "it registers a new user and returns the user." do
@@ -367,7 +264,6 @@ defmodule Pleroma.Web.TwitterAPI.TwitterAPITest do
       "nickname" => "lain",
       "email" => "lain@wired.jp",
       "fullname" => "lain iwakura",
-      "bio" => "close the world.",
       "password" => "bear",
       "confirm" => "bear"
     }
@@ -380,6 +276,142 @@ defmodule Pleroma.Web.TwitterAPI.TwitterAPITest do
              UserView.render("show.json", %{user: fetched_user})
   end
 
+  test "it registers a new user with empty string in bio and returns the user." do
+    data = %{
+      "nickname" => "lain",
+      "email" => "lain@wired.jp",
+      "fullname" => "lain iwakura",
+      "bio" => "",
+      "password" => "bear",
+      "confirm" => "bear"
+    }
+
+    {:ok, user} = TwitterAPI.register_user(data)
+
+    fetched_user = Repo.get_by(User, nickname: "lain")
+
+    assert UserView.render("show.json", %{user: user}) ==
+             UserView.render("show.json", %{user: fetched_user})
+  end
+
+  @moduletag skip: "needs 'account_activation_required: true' in config"
+  test "it sends confirmation email if :account_activation_required is specified in instance config" do
+    setting = Pleroma.Config.get([:instance, :account_activation_required])
+
+    unless setting do
+      Pleroma.Config.put([:instance, :account_activation_required], true)
+      on_exit(fn -> Pleroma.Config.put([:instance, :account_activation_required], setting) end)
+    end
+
+    data = %{
+      "nickname" => "lain",
+      "email" => "lain@wired.jp",
+      "fullname" => "lain iwakura",
+      "bio" => "",
+      "password" => "bear",
+      "confirm" => "bear"
+    }
+
+    {:ok, user} = TwitterAPI.register_user(data)
+
+    assert user.info.confirmation_pending
+
+    Swoosh.TestAssertions.assert_email_sent(Pleroma.UserEmail.account_confirmation_email(user))
+  end
+
+  test "it registers a new user and parses mentions in the bio" do
+    data1 = %{
+      "nickname" => "john",
+      "email" => "john@gmail.com",
+      "fullname" => "John Doe",
+      "bio" => "test",
+      "password" => "bear",
+      "confirm" => "bear"
+    }
+
+    {:ok, user1} = TwitterAPI.register_user(data1)
+
+    data2 = %{
+      "nickname" => "lain",
+      "email" => "lain@wired.jp",
+      "fullname" => "lain iwakura",
+      "bio" => "@john test",
+      "password" => "bear",
+      "confirm" => "bear"
+    }
+
+    {:ok, user2} = TwitterAPI.register_user(data2)
+
+    expected_text =
+      "<span class='h-card'><a data-user='#{user1.id}' class='u-url mention' href='#{user1.ap_id}'>@<span>john</span></a></span> test"
+
+    assert user2.bio == expected_text
+  end
+
+  @moduletag skip: "needs 'registrations_open: false' in config"
+  test "it registers a new user via invite token and returns the user." do
+    {:ok, token} = UserInviteToken.create_token()
+
+    data = %{
+      "nickname" => "vinny",
+      "email" => "pasta@pizza.vs",
+      "fullname" => "Vinny Vinesauce",
+      "bio" => "streamer",
+      "password" => "hiptofbees",
+      "confirm" => "hiptofbees",
+      "token" => token.token
+    }
+
+    {:ok, user} = TwitterAPI.register_user(data)
+
+    fetched_user = Repo.get_by(User, nickname: "vinny")
+    token = Repo.get_by(UserInviteToken, token: token.token)
+
+    assert token.used == true
+
+    assert UserView.render("show.json", %{user: user}) ==
+             UserView.render("show.json", %{user: fetched_user})
+  end
+
+  @moduletag skip: "needs 'registrations_open: false' in config"
+  test "it returns an error if invalid token submitted" do
+    data = %{
+      "nickname" => "GrimReaper",
+      "email" => "death@reapers.afterlife",
+      "fullname" => "Reaper Grim",
+      "bio" => "Your time has come",
+      "password" => "scythe",
+      "confirm" => "scythe",
+      "token" => "DudeLetMeInImAFairy"
+    }
+
+    {:error, msg} = TwitterAPI.register_user(data)
+
+    assert msg == "Invalid token"
+    refute Repo.get_by(User, nickname: "GrimReaper")
+  end
+
+  @moduletag skip: "needs 'registrations_open: false' in config"
+  test "it returns an error if expired token submitted" do
+    {:ok, token} = UserInviteToken.create_token()
+    UserInviteToken.mark_as_used(token.token)
+
+    data = %{
+      "nickname" => "GrimReaper",
+      "email" => "death@reapers.afterlife",
+      "fullname" => "Reaper Grim",
+      "bio" => "Your time has come",
+      "password" => "scythe",
+      "confirm" => "scythe",
+      "token" => token.token
+    }
+
+    {:error, msg} = TwitterAPI.register_user(data)
+
+    assert msg == "Expired token"
+    refute Repo.get_by(User, nickname: "GrimReaper")
+  end
+
   test "it returns the error on registration problems" do
     data = %{
       "nickname" => "lain",
@@ -397,8 +429,7 @@ defmodule Pleroma.Web.TwitterAPI.TwitterAPITest do
 
   test "it assigns an integer conversation_id" do
     note_activity = insert(:note_activity)
-    user = User.get_cached_by_ap_id(note_activity.data["actor"])
-    status = ActivityRepresenter.to_map(note_activity, %{user: user})
+    status = ActivityView.render("activity.json", activity: note_activity)
 
     assert is_number(status["statusnet_conversation_id"])
   end
@@ -435,7 +466,7 @@ defmodule Pleroma.Web.TwitterAPI.TwitterAPITest do
       assert represented["id"] == UserView.render("show.json", %{user: remote, for: user})["id"]
 
       # Also fetches the feed.
-      # assert Activity.get_create_activity_by_object_ap_id("tag:mastodon.social,2017-04-05:objectId=1641750:objectType=Status")
+      # assert Activity.get_create_by_object_ap_id("tag:mastodon.social,2017-04-05:objectId=1641750:objectType=Status")
     end
   end
 end