Also fetch atom links.

[akkoma] / test / web / ostatus / activity_representer_test.exs

diff --git a/test/web/ostatus/activity_representer_test.exs b/test/web/ostatus/activity_representer_test.exs
index 7179cfb710155d6120baa74d963dc6d20a93f3a1..0129e375855625fb72ffd668823a50cf3837167e 100644 (file)
--- a/test/web/ostatus/activity_representer_test.exs
+++ b/test/web/ostatus/activity_representer_test.exs
@@ -4,15 +4,25 @@ defmodule Pleroma.Web.OStatus.ActivityRepresenterTest do
   alias Pleroma.Web.OStatus.ActivityRepresenter
   alias Pleroma.{User, Activity, Object}
   alias Pleroma.Web.ActivityPub.ActivityPub
+  alias Pleroma.Web.OStatus
 
   import Pleroma.Factory
 
+  test "an external note activity" do
+    incoming = File.read!("test/fixtures/mastodon-note-cw.xml")
+    {:ok, [activity]} = OStatus.handle_incoming(incoming)
+
+    user = User.get_cached_by_ap_id(activity.data["actor"])
+
+    tuple = ActivityRepresenter.to_simple_form(activity, user)
+
+    res = :xmerl.export_simple_content(tuple, :xmerl_xml) |> IO.iodata_to_binary
+
+    assert String.contains?(res, ~s{<link type="text/html" href="https://mastodon.social/users/lambadalambda/updates/2314748" rel="alternate"/>})
+  end
+
   test "a note activity" do
     note_activity = insert(:note_activity)
-    updated_at = note_activity.updated_at
-    |> NaiveDateTime.to_iso8601
-    inserted_at = note_activity.inserted_at
-    |> NaiveDateTime.to_iso8601
 
     user = User.get_cached_by_ap_id(note_activity.data["actor"])
 
@@ -22,11 +32,12 @@ defmodule Pleroma.Web.OStatus.ActivityRepresenterTest do
     <id>#{note_activity.data["object"]["id"]}</id>
     <title>New note by #{user.nickname}</title>
     <content type="html">#{note_activity.data["object"]["content"]}</content>
-    <published>#{inserted_at}</published>
-    <updated>#{updated_at}</updated>
+    <published>#{note_activity.data["object"]["published"]}</published>
+    <updated>#{note_activity.data["object"]["published"]}</updated>
     <ostatus:conversation>#{note_activity.data["context"]}</ostatus:conversation>
-    <link href="#{note_activity.data["context"]}" rel="ostatus:conversation" />
+    <link ref="#{note_activity.data["context"]}" rel="ostatus:conversation" />
     <link type="application/atom+xml" href="#{note_activity.data["object"]["id"]}" rel="self" />
+    <link type="text/html" href="#{note_activity.data["object"]["id"]}" rel="alternate" />
     <category term="2hu"/>
     <link rel="mentioned" ostatus:object-type="http://activitystrea.ms/schema/1.0/collection" href="http://activityschema.org/collection/public"/>
     """
@@ -47,10 +58,8 @@ defmodule Pleroma.Web.OStatus.ActivityRepresenterTest do
     data = %{answer.data | "object" => object}
     answer = %{answer | data: data}
 
-    updated_at = answer.updated_at
-    |> NaiveDateTime.to_iso8601
-    inserted_at = answer.inserted_at
-    |> NaiveDateTime.to_iso8601
+    note_object = Object.get_by_ap_id(note.data["object"]["id"])
+    Repo.update!(Object.change(note_object, %{ data: Map.put(note_object.data, "external_url", "someurl") }))
 
     user = User.get_cached_by_ap_id(answer.data["actor"])
 
@@ -60,12 +69,14 @@ defmodule Pleroma.Web.OStatus.ActivityRepresenterTest do
     <id>#{answer.data["object"]["id"]}</id>
     <title>New note by #{user.nickname}</title>
     <content type="html">#{answer.data["object"]["content"]}</content>
-    <published>#{inserted_at}</published>
-    <updated>#{updated_at}</updated>
+    <published>#{answer.data["object"]["published"]}</published>
+    <updated>#{answer.data["object"]["published"]}</updated>
     <ostatus:conversation>#{answer.data["context"]}</ostatus:conversation>
-    <link href="#{answer.data["context"]}" rel="ostatus:conversation" />
+    <link ref="#{answer.data["context"]}" rel="ostatus:conversation" />
     <link type="application/atom+xml" href="#{answer.data["object"]["id"]}" rel="self" />
-    <thr:in-reply-to ref="#{note.data["object"]["id"]}" />
+    <link type="text/html" href="#{answer.data["object"]["id"]}" rel="alternate" />
+    <category term="2hu"/>
+    <thr:in-reply-to ref="#{note.data["object"]["id"]}" href="someurl" />
     <link rel="mentioned" ostatus:object-type="http://activitystrea.ms/schema/1.0/collection" href="http://activityschema.org/collection/public"/>
     """
 
@@ -91,21 +102,16 @@ defmodule Pleroma.Web.OStatus.ActivityRepresenterTest do
     |> :xmerl.export_simple_content(:xmerl_xml)
     |> to_string
 
-    updated_at = announce.updated_at
-    |> NaiveDateTime.to_iso8601
-    inserted_at = announce.inserted_at
-    |> NaiveDateTime.to_iso8601
-
     expected = """
     <activity:object-type>http://activitystrea.ms/schema/1.0/activity</activity:object-type>
     <activity:verb>http://activitystrea.ms/schema/1.0/share</activity:verb>
     <id>#{announce.data["id"]}</id>
     <title>#{user.nickname} repeated a notice</title>
     <content type="html">RT #{note.data["object"]["content"]}</content>
-    <published>#{inserted_at}</published>
-    <updated>#{updated_at}</updated>
+    <published>#{announce.data["published"]}</published>
+    <updated>#{announce.data["published"]}</updated>
     <ostatus:conversation>#{announce.data["context"]}</ostatus:conversation>
-    <link href="#{announce.data["context"]}" rel="ostatus:conversation" />
+    <link ref="#{announce.data["context"]}" rel="ostatus:conversation" />
     <link rel="self" type="application/atom+xml" href="#{announce.data["id"]}"/>
     <activity:object>
       #{note_xml}
@@ -125,12 +131,6 @@ defmodule Pleroma.Web.OStatus.ActivityRepresenterTest do
     user = insert(:user)
     {:ok, like, _note} = ActivityPub.like(user, note)
 
-    # TODO: Are these the correct dates?
-    updated_at = like.updated_at
-    |> NaiveDateTime.to_iso8601
-    inserted_at = like.inserted_at
-    |> NaiveDateTime.to_iso8601
-
     tuple = ActivityRepresenter.to_simple_form(like, user)
     refute is_nil(tuple)
 
@@ -141,14 +141,14 @@ defmodule Pleroma.Web.OStatus.ActivityRepresenterTest do
     <id>#{like.data["id"]}</id>
     <title>New favorite by #{user.nickname}</title>
     <content type="html">#{user.nickname} favorited something</content>
-    <published>#{inserted_at}</published>
-    <updated>#{updated_at}</updated>
+    <published>#{like.data["published"]}</published>
+    <updated>#{like.data["published"]}</updated>
     <activity:object>
       <activity:object-type>http://activitystrea.ms/schema/1.0/note</activity:object-type>
       <id>#{note.data["id"]}</id>
     </activity:object>
     <ostatus:conversation>#{like.data["context"]}</ostatus:conversation>
-    <link href="#{like.data["context"]}" rel="ostatus:conversation" />
+    <link ref="#{like.data["context"]}" rel="ostatus:conversation" />
     <link rel="self" type="application/atom+xml" href="#{like.data["id"]}"/>
     <thr:in-reply-to ref="#{note.data["id"]}" />
     <link rel="mentioned" ostatus:object-type="http://activitystrea.ms/schema/1.0/person" href="#{note.data["actor"]}"/>
@@ -167,13 +167,6 @@ defmodule Pleroma.Web.OStatus.ActivityRepresenterTest do
           "to" => [followed.ap_id]
     })
 
-
-    # TODO: Are these the correct dates?
-    updated_at = activity.updated_at
-    |> NaiveDateTime.to_iso8601
-    inserted_at = activity.inserted_at
-    |> NaiveDateTime.to_iso8601
-
     tuple = ActivityRepresenter.to_simple_form(activity, follower)
 
     refute is_nil(tuple)
@@ -186,8 +179,8 @@ defmodule Pleroma.Web.OStatus.ActivityRepresenterTest do
     <id>#{activity.data["id"]}</id>
     <title>#{follower.nickname} started following #{activity.data["object"]}</title>
     <content type="html"> #{follower.nickname} started following #{activity.data["object"]}</content>
-    <published>#{inserted_at}</published>
-    <updated>#{updated_at}</updated>
+    <published>#{activity.data["published"]}</published>
+    <updated>#{activity.data["published"]}</updated>
     <activity:object>
       <activity:object-type>http://activitystrea.ms/schema/1.0/person</activity:object-type>
       <id>#{activity.data["object"]}</id>
@@ -206,12 +199,6 @@ defmodule Pleroma.Web.OStatus.ActivityRepresenterTest do
     {:ok, _activity} = ActivityPub.follow(follower, followed)
     {:ok, activity} = ActivityPub.unfollow(follower, followed)
 
-    # TODO: Are these the correct dates?
-    updated_at = activity.updated_at
-    |> NaiveDateTime.to_iso8601
-    inserted_at = activity.inserted_at
-    |> NaiveDateTime.to_iso8601
-
     tuple = ActivityRepresenter.to_simple_form(activity, follower)
 
     refute is_nil(tuple)
@@ -224,8 +211,8 @@ defmodule Pleroma.Web.OStatus.ActivityRepresenterTest do
     <id>#{activity.data["id"]}</id>
     <title>#{follower.nickname} stopped following #{followed.ap_id}</title>
     <content type="html"> #{follower.nickname} stopped following #{followed.ap_id}</content>
-    <published>#{inserted_at}</published>
-    <updated>#{updated_at}</updated>
+    <published>#{activity.data["published"]}</published>
+    <updated>#{activity.data["published"]}</updated>
     <activity:object>
       <activity:object-type>http://activitystrea.ms/schema/1.0/person</activity:object-type>
       <id>#{followed.ap_id}</id>