Preload bookmarks wherever the object is preloaded

[akkoma] / test / activity_test.exs

diff --git a/test/activity_test.exs b/test/activity_test.exs
index dc9c56a21b1b25efe2145509eb8dee6d83817b16..e2a8baada672a8a1be45d5bf1a663b7735ce8daa 100644 (file)
--- a/test/activity_test.exs
+++ b/test/activity_test.exs
@@ -5,6 +5,8 @@
 defmodule Pleroma.ActivityTest do
   use Pleroma.DataCase
   alias Pleroma.Activity
+  alias Pleroma.Bookmark
+  alias Pleroma.Object
   import Pleroma.Factory
 
   test "returns an activity by it's AP id" do
@@ -29,17 +31,30 @@ defmodule Pleroma.ActivityTest do
     assert activity == found_activity
   end
 
-  test "reply count" do
-    %{id: id, data: %{"object" => %{"id" => object_ap_id}}} = activity = insert(:note_activity)
-
-    replies_count = activity.data["object"]["repliesCount"] || 0
-    expected_increase = replies_count + 1
-    Activity.increase_replies_count(object_ap_id)
-    %{data: %{"object" => %{"repliesCount" => actual_increase}}} = Activity.get_by_id(id)
-    assert expected_increase == actual_increase
-    expected_decrease = expected_increase - 1
-    Activity.decrease_replies_count(object_ap_id)
-    %{data: %{"object" => %{"repliesCount" => actual_decrease}}} = Activity.get_by_id(id)
-    assert expected_decrease == actual_decrease
+  test "preloading object preloads bookmarks" do
+    user1 = insert(:user)
+    user2 = insert(:user)
+    activity = insert(:note_activity)
+    {:ok, bookmark1} = Bookmark.create(user1.id, activity.id)
+    {:ok, bookmark2} = Bookmark.create(user2.id, activity.id)
+    bookmarks = Enum.sort([bookmark1, bookmark2])
+
+    queried_activity =
+      Ecto.Query.from(a in Activity, where: a.id == ^activity.id)
+      |> Activity.with_preloaded_object()
+      |> Repo.one()
+
+    assert Enum.sort(queried_activity.bookmarks) == bookmarks
+
+    queried_activity = Activity.get_by_ap_id_with_object(activity.data["id"])
+    assert Enum.sort(queried_activity.bookmarks) == bookmarks
+
+    queried_activity = Activity.get_by_id_with_object(activity.id)
+    assert Enum.sort(queried_activity.bookmarks) == bookmarks
+
+    queried_activity =
+      Activity.get_create_by_object_ap_id_with_object(Object.normalize(activity).data["id"])
+
+    assert Enum.sort(queried_activity.bookmarks) == bookmarks
   end
 end