Revert "Simplify query."
[akkoma] / lib / pleroma / web / activity_pub / activity_pub.ex
index 75a34c58096ae4f65665590ebd9d691ef62b1b3a..31aa2c4f127798be671ffc9c4ba4ce204c2afdcb 100644 (file)
 defmodule Pleroma.Web.ActivityPub.ActivityPub do
-  alias Pleroma.{Activity, Repo, Object, Upload, User, Web}
+  alias Pleroma.{Activity, Repo, Object, Upload, User, Web, Notification}
   alias Ecto.{Changeset, UUID}
   import Ecto.Query
+  import Pleroma.Web.ActivityPub.Utils
   require Logger
 
   def insert(map, local \\ true) when is_map(map) do
-    map = map
-    |> Map.put_new_lazy("id", &generate_activity_id/0)
-    |> Map.put_new_lazy("published", &make_date/0)
-
-    with %Activity{} = activity <- Activity.get_by_ap_id(map["id"]) do
-      Logger.debug(fn -> "Already have activity, #{activity.id}, not inserting." end)
+    with nil <- Activity.get_by_ap_id(map["id"]),
+         map <- lazy_put_activity_defaults(map),
+         :ok <- insert_full_object(map) do
+      {:ok, activity} = Repo.insert(%Activity{data: map, local: local})
+      Notification.create_notifications(activity)
       {:ok, activity}
-    else _e ->
-      map = if is_map(map["object"]) do
-        object = Map.put_new_lazy(map["object"], "id", &generate_object_id/0)
-        Repo.insert!(%Object{data: object})
-        Map.put(map, "object", object)
-      else
-        map
-      end
-
-      Repo.insert(%Activity{data: map, local: local})
+    else
+      %Activity{} = activity -> {:ok, activity}
+      error -> {:error, error}
     end
   end
 
   def create(to, actor, context, object, additional \\ %{}, published \\ nil, local \\ true) do
-    published = published || make_date()
-
-    activity = %{
-      "type" => "Create",
-      "to" => to |> Enum.uniq,
-      "actor" => actor.ap_id,
-      "object" => object,
-      "published" => published,
-      "context" => context
-    }
-    |> Map.merge(additional)
-
-    with {:ok, activity} <- insert(activity, local) do
-      if actor.local do
-        Pleroma.Web.Federator.enqueue(:publish, activity)
-       end
-
+    with create_data <- make_create_data(%{to: to, actor: actor, published: published, context: context, object: object}, additional),
+         {:ok, activity} <- insert(create_data, local),
+         :ok <- maybe_federate(activity) do
       {:ok, activity}
     end
   end
 
+  # TODO: This is weird, maybe we shouldn't check here if we can make the activity.
   def like(%User{ap_id: ap_id} = user, %Object{data: %{"id" => id}} = object, activity_id \\ nil, local \\ true) do
-    cond do
-      # There's already a like here, so return the original activity.
-      ap_id in (object.data["likes"] || []) ->
-        query = from activity in Activity,
-          where: fragment("? @> ?", activity.data, ^%{actor: ap_id, object: id, type: "Like"})
-
-        activity = Repo.one(query)
-        {:ok, activity, object}
-      true ->
-        data = %{
-          "type" => "Like",
-          "actor" => ap_id,
-          "object" => id,
-          "to" => [User.ap_followers(user), object.data["actor"]],
-          "context" => object.data["context"]
-        }
-
-        data = if activity_id, do: Map.put(data, "id", activity_id), else: data
-
-        {:ok, activity} = insert(data, local)
-
-        likes = [ap_id | (object.data["likes"] || [])] |> Enum.uniq
-
-        new_data = object.data
-        |> Map.put("like_count", length(likes))
-        |> Map.put("likes", likes)
-
-        changeset = Changeset.change(object, data: new_data)
-        {:ok, object} = Repo.update(changeset)
-
-        update_object_in_activities(object)
-
-        if user.local do
-          Pleroma.Web.Federator.enqueue(:publish, activity)
-        end
-
-        {:ok, activity, object}
+    with nil <- get_existing_like(ap_id, object),
+         like_data <- make_like_data(user, object, activity_id),
+         {:ok, activity} <- insert(like_data, local),
+         {:ok, object} <- add_like_to_object(activity, object),
+         :ok <- maybe_federate(activity) do
+      {:ok, activity, object}
+    else
+      %Activity{} = activity -> {:ok, activity, object}
+      error -> {:error, error}
     end
   end
 
-  defp update_object_in_activities(%{data: %{"id" => id}} = object) do
-    # TODO
-    # Update activities that already had this. Could be done in a seperate process.
-    # Alternatively, just don't do this and fetch the current object each time. Most
-    # could probably be taken from cache.
-    relevant_activities = Activity.all_by_object_ap_id(id)
-    Enum.map(relevant_activities, fn (activity) ->
-      new_activity_data = activity.data |> Map.put("object", object.data)
-      changeset = Changeset.change(activity, data: new_activity_data)
-      Repo.update(changeset)
-    end)
+  def unlike(%User{} = actor, %Object{} = object) do
+    with %Activity{} = activity <- get_existing_like(actor.ap_id, object),
+         {:ok, _activity} <- Repo.delete(activity),
+         {:ok, object} <- remove_like_from_object(activity, object) do
+      {:ok, object}
+      else _e -> {:ok, object}
+    end
   end
 
-  def unlike(%User{ap_id: ap_id}, %Object{data: %{ "id" => id}} = object) do
-    query = from activity in Activity,
-      where: fragment("? @> ?", activity.data, ^%{actor: ap_id, object: id, type: "Like"})
-
-    activity = Repo.one(query)
-
-    if activity do
-      # just delete for now...
-      {:ok, _activity} = Repo.delete(activity)
-
-      likes = (object.data["likes"] || []) |> List.delete(ap_id)
-
-      new_data = object.data
-      |> Map.put("like_count", length(likes))
-      |> Map.put("likes", likes)
-
-      changeset = Changeset.change(object, data: new_data)
-      {:ok, object} = Repo.update(changeset)
-
-      update_object_in_activities(object)
-
-      {:ok, object}
+  def announce(%User{ap_id: ap_id} = user, %Object{data: %{"id" => id}} = object, activity_id \\ nil, local \\ true) do
+    with announce_data <- make_announce_data(user, object, activity_id),
+         {:ok, activity} <- insert(announce_data, local),
+         {:ok, object} <- add_announce_to_object(activity, object),
+         :ok <- maybe_federate(activity) do
+      {:ok, activity, object}
     else
-      {:ok, object}
+      error -> {:error, error}
     end
   end
 
-  def generate_activity_id do
-    generate_id("activities")
+  def follow(follower, followed, activity_id \\ nil, local \\ true) do
+    with data <- make_follow_data(follower, followed, activity_id),
+         {:ok, activity} <- insert(data, local),
+         :ok <- maybe_federate(activity) do
+      {:ok, activity}
+    end
   end
 
-  def generate_context_id do
-    generate_id("contexts")
+  def unfollow(follower, followed, local \\ true) do
+    with %Activity{} = follow_activity <- fetch_latest_follow(follower, followed),
+         unfollow_data <- make_unfollow_data(follower, followed, follow_activity),
+         {:ok, activity} <- insert(unfollow_data, local),
+         :ok, maybe_federate(activity) do
+      {:ok, activity}
+    end
   end
 
-  def generate_object_id do
-    Pleroma.Web.Router.Helpers.o_status_url(Pleroma.Web.Endpoint, :object, Ecto.UUID.generate)
+  def delete(%Object{data: %{"id" => id, "actor" => actor}} = object, local \\ true) do
+    user = User.get_cached_by_ap_id(actor)
+    data = %{
+      "type" => "Delete",
+      "actor" => actor,
+      "object" => id,
+      "to" => [user.follower_address, "https://www.w3.org/ns/activitystreams#Public"]
+    }
+    with Repo.delete(object),
+         Repo.delete_all(Activity.all_non_create_by_object_ap_id_q(id)),
+         Repo.delete_all(Activity.all_by_object_ap_id_q(id)),
+         {:ok, activity} <- insert(data, local),
+         :ok <- maybe_federate(activity) do
+      {:ok, activity}
+    end
   end
 
-  def generate_id(type) do
-    "#{Web.base_url()}/#{type}/#{UUID.generate}"
+  def fetch_activities_for_context(context) do
+    query = from activity in Activity,
+      where: fragment("?->>'type' = ? and ?->>'context' = ?", activity.data, "Create", activity.data, ^context),
+      order_by: [desc: :id]
+    Repo.all(query)
   end
 
   def fetch_public_activities(opts \\ %{}) do
@@ -149,137 +106,76 @@ defmodule Pleroma.Web.ActivityPub.ActivityPub do
     fetch_activities(public, opts)
   end
 
-  def fetch_activities(recipients, opts \\ %{}) do
-    since_id = opts["since_id"] || 0
+  defp restrict_since(query, %{"since_id" => since_id}) do
+    from activity in query, where: activity.id > ^since_id
+  end
+  defp restrict_since(query, _), do: query
 
-    query = from activity in Activity,
-      limit: 20,
-      order_by: [desc: :inserted_at]
+  defp restrict_tag(query, %{"tag" => tag}) do
+    from activity in query,
+      where: fragment("? <@ (? #> '{\"object\",\"tag\"}')", ^tag, activity.data)
+  end
+  defp restrict_tag(query, _), do: query
 
-    query = Enum.reduce(recipients, query, fn (recipient, q) ->
+  defp restrict_recipients(query, recipients) do
+    Enum.reduce(recipients, query, fn (recipient, q) ->
       map = %{ to: [recipient] }
       from activity in q,
       or_where: fragment(~s(? @> ?), activity.data, ^map)
     end)
-
-    query = from activity in query,
-      where: activity.id > ^since_id
-
-    query = if opts["local_only"] do
-      from activity in query, where: activity.local == true
-    else
-      query
-    end
-
-    query = if opts["max_id"] do
-      from activity in query, where: activity.id < ^opts["max_id"]
-    else
-      query
-    end
-
-    query = if opts["actor_id"] do
-      from activity in query,
-        where: fragment("? @> ?", activity.data, ^%{actor: opts["actor_id"]})
-    else
-      query
-    end
-
-    Enum.reverse(Repo.all(query))
   end
 
-  def announce(%User{ap_id: ap_id} = user, %Object{data: %{"id" => id}} = object, activity_id \\ nil, local \\ true) do
-    data = %{
-      "type" => "Announce",
-      "actor" => ap_id,
-      "object" => id,
-      "to" => [User.ap_followers(user), object.data["actor"]],
-      "context" => object.data["context"]
-    }
-
-    data = if activity_id, do: Map.put(data, "id", activity_id), else: data
-
-    {:ok, activity} = insert(data, local)
-
-    announcements = [ap_id | (object.data["announcements"] || [])] |> Enum.uniq
-
-    new_data = object.data
-    |> Map.put("announcement_count", length(announcements))
-    |> Map.put("announcements", announcements)
-
-    changeset = Changeset.change(object, data: new_data)
-    {:ok, object} = Repo.update(changeset)
-
-    update_object_in_activities(object)
-
-    if user.local do
-      Pleroma.Web.Federator.enqueue(:publish, activity)
-    end
-
-    {:ok, activity, object}
+  defp restrict_local(query, %{"local_only" => true}) do
+    from activity in query, where: activity.local == true
   end
+  defp restrict_local(query, _), do: query
 
-  def follow(%User{ap_id: follower_id, local: actor_local}, %User{ap_id: followed_id}, activity_id \\ nil, local \\ true) do
-    data = %{
-      "type" => "Follow",
-      "actor" => follower_id,
-      "to" => [followed_id],
-      "object" => followed_id,
-      "published" => make_date()
-    }
-
-    data = if activity_id, do: Map.put(data, "id", activity_id), else: data
-
-    with {:ok, activity} <- insert(data, local) do
-      if actor_local do
-        Pleroma.Web.Federator.enqueue(:publish, activity)
-       end
-
-      {:ok, activity}
-    end
+  defp restrict_max(query, %{"max_id" => max_id}) do
+    from activity in query, where: activity.id < ^max_id
   end
+  defp restrict_max(query, _), do: query
 
-  def unfollow(follower, followed, local \\ true) do
-    with follow_activity when not is_nil(follow_activity) <- fetch_latest_follow(follower, followed) do
-      data = %{
-        "type" => "Undo",
-        "actor" => follower.ap_id,
-        "to" => [followed.ap_id],
-        "object" => follow_activity.data["id"],
-        "published" => make_date()
-      }
-
-      with {:ok, activity} <- insert(data, local) do
-        if follower.local do
-          Pleroma.Web.Federator.enqueue(:publish, activity)
-        end
+  defp restrict_actor(query, %{"actor_id" => actor_id}) do
+    from activity in query,
+      where: fragment("?->>'actor' = ?", activity.data, ^actor_id)
+  end
+  defp restrict_actor(query, _), do: query
 
-        {:ok, activity}
-      end
-    end
+  defp restrict_type(query, %{"type" => type}) when is_binary(type) do
+    restrict_type(query, %{"type" => [type]})
+  end
+  defp restrict_type(query, %{"type" => type}) do
+    from activity in query,
+      where: fragment("?->>'type' = ANY(?)", activity.data, ^type)
   end
+  defp restrict_type(query, _), do: query
 
-  def fetch_activities_for_context(context) do
-    query = from activity in Activity,
-      where: fragment("? @> ?", activity.data, ^%{ context: context })
-    Repo.all(query)
+  defp restrict_favorited_by(query, %{"favorited_by" => ap_id}) do
+    from activity in query,
+      where: fragment("? <@ (? #> '{\"object\",\"likes\"}')", ^ap_id, activity.data)
   end
+  defp restrict_favorited_by(query, _), do: query
 
-  def fetch_latest_follow(%User{ap_id: follower_id},
-                          %User{ap_id: followed_id}) do
-    query = from activity in Activity,
-      where: fragment("? @> ?", activity.data, ^%{type: "Follow", actor: follower_id,
-                                                  object: followed_id}),
-      order_by: [desc: :inserted_at],
-      limit: 1
-    Repo.one(query)
+  def fetch_activities(recipients, opts \\ %{}) do
+    base_query = from activity in Activity,
+      limit: 20,
+      order_by: [desc: :id]
+
+    base_query
+    |> restrict_recipients(recipients)
+    |> restrict_tag(opts)
+    |> restrict_since(opts)
+    |> restrict_local(opts)
+    |> restrict_max(opts)
+    |> restrict_actor(opts)
+    |> restrict_type(opts)
+    |> restrict_favorited_by(opts)
+    |> Repo.all
+    |> Enum.reverse
   end
 
   def upload(file) do
     data = Upload.store(file)
     Repo.insert(%Object{data: data})
   end
-
-  defp make_date do
-    DateTime.utc_now() |> DateTime.to_iso8601
-  end
 end