activitypub transmogrifier: cleanups and tests for incoming accepts/rejects
[akkoma] / test / web / activity_pub / transmogrifier_test.exs
1 defmodule Pleroma.Web.ActivityPub.TransmogrifierTest do
2 use Pleroma.DataCase
3 alias Pleroma.Web.ActivityPub.Transmogrifier
4 alias Pleroma.Web.ActivityPub.Utils
5 alias Pleroma.Web.ActivityPub.ActivityPub
6 alias Pleroma.Web.OStatus
7 alias Pleroma.Activity
8 alias Pleroma.User
9 alias Pleroma.Repo
10 alias Pleroma.Web.Websub.WebsubClientSubscription
11 alias Pleroma.Web.Websub.WebsubServerSubscription
12 import Ecto.Query
13
14 import Pleroma.Factory
15 alias Pleroma.Web.CommonAPI
16
17 describe "handle_incoming" do
18 test "it ignores an incoming notice if we already have it" do
19 activity = insert(:note_activity)
20
21 data =
22 File.read!("test/fixtures/mastodon-post-activity.json")
23 |> Poison.decode!()
24 |> Map.put("object", activity.data["object"])
25
26 {:ok, returned_activity} = Transmogrifier.handle_incoming(data)
27
28 assert activity == returned_activity
29 end
30
31 test "it fetches replied-to activities if we don't have them" do
32 data =
33 File.read!("test/fixtures/mastodon-post-activity.json")
34 |> Poison.decode!()
35
36 object =
37 data["object"]
38 |> Map.put("inReplyTo", "https://shitposter.club/notice/2827873")
39
40 data =
41 data
42 |> Map.put("object", object)
43
44 {:ok, returned_activity} = Transmogrifier.handle_incoming(data)
45
46 assert activity =
47 Activity.get_create_activity_by_object_ap_id(
48 "tag:shitposter.club,2017-05-05:noticeId=2827873:objectType=comment"
49 )
50
51 assert returned_activity.data["object"]["inReplyToAtomUri"] ==
52 "https://shitposter.club/notice/2827873"
53
54 assert returned_activity.data["object"]["inReplyToStatusId"] == activity.id
55 end
56
57 test "it works for incoming notices" do
58 data = File.read!("test/fixtures/mastodon-post-activity.json") |> Poison.decode!()
59
60 {:ok, %Activity{data: data, local: false}} = Transmogrifier.handle_incoming(data)
61
62 assert data["id"] ==
63 "http://mastodon.example.org/users/admin/statuses/99512778738411822/activity"
64
65 assert data["context"] ==
66 "tag:mastodon.example.org,2018-02-12:objectId=20:objectType=Conversation"
67
68 assert data["to"] == ["https://www.w3.org/ns/activitystreams#Public"]
69
70 assert data["cc"] == [
71 "http://mastodon.example.org/users/admin/followers",
72 "http://localtesting.pleroma.lol/users/lain"
73 ]
74
75 assert data["actor"] == "http://mastodon.example.org/users/admin"
76
77 object = data["object"]
78 assert object["id"] == "http://mastodon.example.org/users/admin/statuses/99512778738411822"
79
80 assert object["to"] == ["https://www.w3.org/ns/activitystreams#Public"]
81
82 assert object["cc"] == [
83 "http://mastodon.example.org/users/admin/followers",
84 "http://localtesting.pleroma.lol/users/lain"
85 ]
86
87 assert object["actor"] == "http://mastodon.example.org/users/admin"
88 assert object["attributedTo"] == "http://mastodon.example.org/users/admin"
89
90 assert object["context"] ==
91 "tag:mastodon.example.org,2018-02-12:objectId=20:objectType=Conversation"
92
93 assert object["sensitive"] == true
94
95 user = User.get_by_ap_id(object["actor"])
96
97 assert user.info["note_count"] == 1
98 end
99
100 test "it works for incoming notices with hashtags" do
101 data = File.read!("test/fixtures/mastodon-post-activity-hashtag.json") |> Poison.decode!()
102
103 {:ok, %Activity{data: data, local: false}} = Transmogrifier.handle_incoming(data)
104 assert Enum.at(data["object"]["tag"], 2) == "moo"
105 end
106
107 test "it works for incoming follow requests" do
108 user = insert(:user)
109
110 data =
111 File.read!("test/fixtures/mastodon-follow-activity.json")
112 |> Poison.decode!()
113 |> Map.put("object", user.ap_id)
114
115 {:ok, %Activity{data: data, local: false}} = Transmogrifier.handle_incoming(data)
116
117 assert data["actor"] == "http://mastodon.example.org/users/admin"
118 assert data["type"] == "Follow"
119 assert data["id"] == "http://mastodon.example.org/users/admin#follows/2"
120 assert User.following?(User.get_by_ap_id(data["actor"]), user)
121 end
122
123 test "it works for incoming follow requests from hubzilla" do
124 user = insert(:user)
125
126 data =
127 File.read!("test/fixtures/hubzilla-follow-activity.json")
128 |> Poison.decode!()
129 |> Map.put("object", user.ap_id)
130 |> Utils.normalize_params()
131
132 {:ok, %Activity{data: data, local: false}} = Transmogrifier.handle_incoming(data)
133
134 assert data["actor"] == "https://hubzilla.example.org/channel/kaniini"
135 assert data["type"] == "Follow"
136 assert data["id"] == "https://hubzilla.example.org/channel/kaniini#follows/2"
137 assert User.following?(User.get_by_ap_id(data["actor"]), user)
138 end
139
140 test "it works for incoming likes" do
141 user = insert(:user)
142 {:ok, activity} = CommonAPI.post(user, %{"status" => "hello"})
143
144 data =
145 File.read!("test/fixtures/mastodon-like.json")
146 |> Poison.decode!()
147 |> Map.put("object", activity.data["object"]["id"])
148
149 {:ok, %Activity{data: data, local: false}} = Transmogrifier.handle_incoming(data)
150
151 assert data["actor"] == "http://mastodon.example.org/users/admin"
152 assert data["type"] == "Like"
153 assert data["id"] == "http://mastodon.example.org/users/admin#likes/2"
154 assert data["object"] == activity.data["object"]["id"]
155 end
156
157 test "it returns an error for incoming unlikes wihout a like activity" do
158 user = insert(:user)
159 {:ok, activity} = CommonAPI.post(user, %{"status" => "leave a like pls"})
160
161 data =
162 File.read!("test/fixtures/mastodon-undo-like.json")
163 |> Poison.decode!()
164 |> Map.put("object", activity.data["object"]["id"])
165
166 assert Transmogrifier.handle_incoming(data) == :error
167 end
168
169 test "it works for incoming unlikes with an existing like activity" do
170 user = insert(:user)
171 {:ok, activity} = CommonAPI.post(user, %{"status" => "leave a like pls"})
172
173 like_data =
174 File.read!("test/fixtures/mastodon-like.json")
175 |> Poison.decode!()
176 |> Map.put("object", activity.data["object"]["id"])
177
178 {:ok, %Activity{data: like_data, local: false}} = Transmogrifier.handle_incoming(like_data)
179
180 data =
181 File.read!("test/fixtures/mastodon-undo-like.json")
182 |> Poison.decode!()
183 |> Map.put("object", like_data)
184 |> Map.put("actor", like_data["actor"])
185
186 {:ok, %Activity{data: data, local: false}} = Transmogrifier.handle_incoming(data)
187
188 assert data["actor"] == "http://mastodon.example.org/users/admin"
189 assert data["type"] == "Undo"
190 assert data["id"] == "http://mastodon.example.org/users/admin#likes/2/undo"
191 assert data["object"]["id"] == "http://mastodon.example.org/users/admin#likes/2"
192 end
193
194 test "it works for incoming announces" do
195 data = File.read!("test/fixtures/mastodon-announce.json") |> Poison.decode!()
196
197 {:ok, %Activity{data: data, local: false}} = Transmogrifier.handle_incoming(data)
198
199 assert data["actor"] == "http://mastodon.example.org/users/admin"
200 assert data["type"] == "Announce"
201
202 assert data["id"] ==
203 "http://mastodon.example.org/users/admin/statuses/99542391527669785/activity"
204
205 assert data["object"] ==
206 "http://mastodon.example.org/users/admin/statuses/99541947525187367"
207
208 assert Activity.get_create_activity_by_object_ap_id(data["object"])
209 end
210
211 test "it works for incoming announces with an existing activity" do
212 user = insert(:user)
213 {:ok, activity} = CommonAPI.post(user, %{"status" => "hey"})
214
215 data =
216 File.read!("test/fixtures/mastodon-announce.json")
217 |> Poison.decode!()
218 |> Map.put("object", activity.data["object"]["id"])
219
220 {:ok, %Activity{data: data, local: false}} = Transmogrifier.handle_incoming(data)
221
222 assert data["actor"] == "http://mastodon.example.org/users/admin"
223 assert data["type"] == "Announce"
224
225 assert data["id"] ==
226 "http://mastodon.example.org/users/admin/statuses/99542391527669785/activity"
227
228 assert data["object"] == activity.data["object"]["id"]
229
230 assert Activity.get_create_activity_by_object_ap_id(data["object"]).id == activity.id
231 end
232
233 test "it works for incoming update activities" do
234 data = File.read!("test/fixtures/mastodon-post-activity.json") |> Poison.decode!()
235
236 {:ok, %Activity{data: data, local: false}} = Transmogrifier.handle_incoming(data)
237 update_data = File.read!("test/fixtures/mastodon-update.json") |> Poison.decode!()
238
239 object =
240 update_data["object"]
241 |> Map.put("actor", data["actor"])
242 |> Map.put("id", data["actor"])
243
244 update_data =
245 update_data
246 |> Map.put("actor", data["actor"])
247 |> Map.put("object", object)
248
249 {:ok, %Activity{data: data, local: false}} = Transmogrifier.handle_incoming(update_data)
250
251 user = User.get_cached_by_ap_id(data["actor"])
252 assert user.name == "gargle"
253
254 assert user.avatar["url"] == [
255 %{
256 "href" =>
257 "https://cd.niu.moe/accounts/avatars/000/033/323/original/fd7f8ae0b3ffedc9.jpeg"
258 }
259 ]
260
261 assert user.info["banner"]["url"] == [
262 %{
263 "href" =>
264 "https://cd.niu.moe/accounts/headers/000/033/323/original/850b3448fa5fd477.png"
265 }
266 ]
267
268 assert user.bio == "<p>Some bio</p>"
269 end
270
271 test "it works for incoming deletes" do
272 activity = insert(:note_activity)
273
274 data =
275 File.read!("test/fixtures/mastodon-delete.json")
276 |> Poison.decode!()
277
278 object =
279 data["object"]
280 |> Map.put("id", activity.data["object"]["id"])
281
282 data =
283 data
284 |> Map.put("object", object)
285 |> Map.put("actor", activity.data["actor"])
286
287 {:ok, %Activity{data: data, local: false}} = Transmogrifier.handle_incoming(data)
288
289 refute Repo.get(Activity, activity.id)
290 end
291
292 test "it works for incoming unannounces with an existing notice" do
293 user = insert(:user)
294 {:ok, activity} = CommonAPI.post(user, %{"status" => "hey"})
295
296 announce_data =
297 File.read!("test/fixtures/mastodon-announce.json")
298 |> Poison.decode!()
299 |> Map.put("object", activity.data["object"]["id"])
300
301 {:ok, %Activity{data: announce_data, local: false}} =
302 Transmogrifier.handle_incoming(announce_data)
303
304 data =
305 File.read!("test/fixtures/mastodon-undo-announce.json")
306 |> Poison.decode!()
307 |> Map.put("object", announce_data)
308 |> Map.put("actor", announce_data["actor"])
309
310 {:ok, %Activity{data: data, local: false}} = Transmogrifier.handle_incoming(data)
311
312 assert data["type"] == "Undo"
313 assert data["object"]["type"] == "Announce"
314 assert data["object"]["object"] == activity.data["object"]["id"]
315
316 assert data["object"]["id"] ==
317 "http://mastodon.example.org/users/admin/statuses/99542391527669785/activity"
318 end
319
320 test "it works for incomming unfollows with an existing follow" do
321 user = insert(:user)
322
323 follow_data =
324 File.read!("test/fixtures/mastodon-follow-activity.json")
325 |> Poison.decode!()
326 |> Map.put("object", user.ap_id)
327
328 {:ok, %Activity{data: _, local: false}} = Transmogrifier.handle_incoming(follow_data)
329
330 data =
331 File.read!("test/fixtures/mastodon-unfollow-activity.json")
332 |> Poison.decode!()
333 |> Map.put("object", follow_data)
334
335 {:ok, %Activity{data: data, local: false}} = Transmogrifier.handle_incoming(data)
336
337 assert data["type"] == "Undo"
338 assert data["object"]["type"] == "Follow"
339 assert data["object"]["object"] == user.ap_id
340 assert data["actor"] == "http://mastodon.example.org/users/admin"
341
342 refute User.following?(User.get_by_ap_id(data["actor"]), user)
343 end
344
345 test "it works for incoming blocks" do
346 user = insert(:user)
347
348 data =
349 File.read!("test/fixtures/mastodon-block-activity.json")
350 |> Poison.decode!()
351 |> Map.put("object", user.ap_id)
352
353 {:ok, %Activity{data: data, local: false}} = Transmogrifier.handle_incoming(data)
354
355 assert data["type"] == "Block"
356 assert data["object"] == user.ap_id
357 assert data["actor"] == "http://mastodon.example.org/users/admin"
358
359 blocker = User.get_by_ap_id(data["actor"])
360
361 assert User.blocks?(blocker, user)
362 end
363
364 test "it works for incoming unblocks with an existing block" do
365 user = insert(:user)
366
367 block_data =
368 File.read!("test/fixtures/mastodon-block-activity.json")
369 |> Poison.decode!()
370 |> Map.put("object", user.ap_id)
371
372 {:ok, %Activity{data: _, local: false}} = Transmogrifier.handle_incoming(block_data)
373
374 data =
375 File.read!("test/fixtures/mastodon-unblock-activity.json")
376 |> Poison.decode!()
377 |> Map.put("object", block_data)
378
379 {:ok, %Activity{data: data, local: false}} = Transmogrifier.handle_incoming(data)
380 assert data["type"] == "Undo"
381 assert data["object"]["type"] == "Block"
382 assert data["object"]["object"] == user.ap_id
383 assert data["actor"] == "http://mastodon.example.org/users/admin"
384
385 blocker = User.get_by_ap_id(data["actor"])
386
387 refute User.blocks?(blocker, user)
388 end
389
390 test "it works for incoming accepts which were pre-accepted" do
391 follower = insert(:user)
392 followed = insert(:user)
393
394 {:ok, follower} = User.follow(follower, followed)
395 assert User.following?(follower, followed) == true
396
397 accept_data =
398 File.read!("test/fixtures/mastodon-accept-activity.json")
399 |> Poison.decode!()
400 |> Map.put("actor", followed.ap_id)
401
402 accept_data =
403 Map.put(accept_data, "object", Map.put(accept_data["object"], "actor", follower.ap_id))
404
405 {:ok, %Activity{data: _}} = Transmogrifier.handle_incoming(accept_data)
406
407 follower = Repo.get(User, follower.id)
408
409 assert User.following?(follower, followed) == true
410 end
411
412 test "it works for incoming accepts which were orphaned" do
413 follower = insert(:user)
414 followed = insert(:user, %{info: %{"locked" => true}})
415
416 {:ok, follow_activity} = ActivityPub.follow(follower, followed)
417
418 accept_data =
419 File.read!("test/fixtures/mastodon-accept-activity.json")
420 |> Poison.decode!()
421 |> Map.put("actor", followed.ap_id)
422
423 accept_data =
424 Map.put(accept_data, "object", Map.put(accept_data["object"], "actor", follower.ap_id))
425
426 {:ok, %Activity{data: _}} = Transmogrifier.handle_incoming(accept_data)
427
428 follower = Repo.get(User, follower.id)
429
430 assert User.following?(follower, followed) == true
431 end
432
433 test "it works for incoming accepts which are referenced by IRI only" do
434 follower = insert(:user)
435 followed = insert(:user, %{info: %{"locked" => true}})
436
437 {:ok, follow_activity} = ActivityPub.follow(follower, followed)
438
439 accept_data =
440 File.read!("test/fixtures/mastodon-accept-activity.json")
441 |> Poison.decode!()
442 |> Map.put("actor", followed.ap_id)
443 |> Map.put("object", follow_activity.data["id"])
444
445 {:ok, %Activity{data: _}} = Transmogrifier.handle_incoming(accept_data)
446
447 follower = Repo.get(User, follower.id)
448
449 assert User.following?(follower, followed) == true
450 end
451
452 test "it works for incoming rejects which are orphaned" do
453 follower = insert(:user)
454 followed = insert(:user, %{info: %{"locked" => true}})
455
456 {:ok, follower} = User.follow(follower, followed)
457 {:ok, follow_activity} = ActivityPub.follow(follower, followed)
458
459 assert User.following?(follower, followed) == true
460
461 reject_data =
462 File.read!("test/fixtures/mastodon-reject-activity.json")
463 |> Poison.decode!()
464 |> Map.put("actor", followed.ap_id)
465
466 reject_data =
467 Map.put(reject_data, "object", Map.put(reject_data["object"], "actor", follower.ap_id))
468
469 {:ok, %Activity{data: _}} = Transmogrifier.handle_incoming(reject_data)
470
471 follower = Repo.get(User, follower.id)
472
473 assert User.following?(follower, followed) == false
474 end
475
476 test "it works for incoming rejects which are referenced by IRI only" do
477 follower = insert(:user)
478 followed = insert(:user, %{info: %{"locked" => true}})
479
480 {:ok, follower} = User.follow(follower, followed)
481 {:ok, follow_activity} = ActivityPub.follow(follower, followed)
482
483 assert User.following?(follower, followed) == true
484
485 reject_data =
486 File.read!("test/fixtures/mastodon-reject-activity.json")
487 |> Poison.decode!()
488 |> Map.put("actor", followed.ap_id)
489 |> Map.put("object", follow_activity.data["id"])
490
491 {:ok, %Activity{data: _}} = Transmogrifier.handle_incoming(reject_data)
492
493 follower = Repo.get(User, follower.id)
494
495 assert User.following?(follower, followed) == false
496 end
497 end
498
499 describe "prepare outgoing" do
500 test "it turns mentions into tags" do
501 user = insert(:user)
502 other_user = insert(:user)
503
504 {:ok, activity} =
505 CommonAPI.post(user, %{"status" => "hey, @#{other_user.nickname}, how are ya? #2hu"})
506
507 {:ok, modified} = Transmogrifier.prepare_outgoing(activity.data)
508 object = modified["object"]
509
510 expected_mention = %{
511 "href" => other_user.ap_id,
512 "name" => "@#{other_user.nickname}",
513 "type" => "Mention"
514 }
515
516 expected_tag = %{
517 "href" => Pleroma.Web.Endpoint.url() <> "/tags/2hu",
518 "type" => "Hashtag",
519 "name" => "#2hu"
520 }
521
522 assert Enum.member?(object["tag"], expected_tag)
523 assert Enum.member?(object["tag"], expected_mention)
524 end
525
526 test "it adds the sensitive property" do
527 user = insert(:user)
528
529 {:ok, activity} = CommonAPI.post(user, %{"status" => "#nsfw hey"})
530 {:ok, modified} = Transmogrifier.prepare_outgoing(activity.data)
531
532 assert modified["object"]["sensitive"]
533 end
534
535 test "it adds the json-ld context and the conversation property" do
536 user = insert(:user)
537
538 {:ok, activity} = CommonAPI.post(user, %{"status" => "hey"})
539 {:ok, modified} = Transmogrifier.prepare_outgoing(activity.data)
540
541 assert modified["@context"] == "https://www.w3.org/ns/activitystreams"
542 assert modified["object"]["conversation"] == modified["context"]
543 end
544
545 test "it sets the 'attributedTo' property to the actor of the object if it doesn't have one" do
546 user = insert(:user)
547
548 {:ok, activity} = CommonAPI.post(user, %{"status" => "hey"})
549 {:ok, modified} = Transmogrifier.prepare_outgoing(activity.data)
550
551 assert modified["object"]["actor"] == modified["object"]["attributedTo"]
552 end
553
554 test "it translates ostatus IDs to external URLs" do
555 incoming = File.read!("test/fixtures/incoming_note_activity.xml")
556 {:ok, [referent_activity]} = OStatus.handle_incoming(incoming)
557
558 user = insert(:user)
559
560 {:ok, activity, _} = CommonAPI.favorite(referent_activity.id, user)
561 {:ok, modified} = Transmogrifier.prepare_outgoing(activity.data)
562
563 assert modified["object"] == "http://gs.example.org:4040/index.php/notice/29"
564 end
565
566 test "it translates ostatus reply_to IDs to external URLs" do
567 incoming = File.read!("test/fixtures/incoming_note_activity.xml")
568 {:ok, [referred_activity]} = OStatus.handle_incoming(incoming)
569
570 user = insert(:user)
571
572 {:ok, activity} =
573 CommonAPI.post(user, %{"status" => "HI!", "in_reply_to_status_id" => referred_activity.id})
574
575 {:ok, modified} = Transmogrifier.prepare_outgoing(activity.data)
576
577 assert modified["object"]["inReplyTo"] == "http://gs.example.org:4040/index.php/notice/29"
578 end
579 end
580
581 describe "user upgrade" do
582 test "it upgrades a user to activitypub" do
583 user =
584 insert(:user, %{
585 nickname: "rye@niu.moe",
586 local: false,
587 ap_id: "https://niu.moe/users/rye",
588 follower_address: User.ap_followers(%User{nickname: "rye@niu.moe"})
589 })
590
591 user_two = insert(:user, %{following: [user.follower_address]})
592
593 {:ok, activity} = CommonAPI.post(user, %{"status" => "test"})
594 {:ok, unrelated_activity} = CommonAPI.post(user_two, %{"status" => "test"})
595 assert "http://localhost:4001/users/rye@niu.moe/followers" in activity.recipients
596
597 user = Repo.get(User, user.id)
598 assert user.info["note_count"] == 1
599
600 {:ok, user} = Transmogrifier.upgrade_user_from_ap_id("https://niu.moe/users/rye")
601 assert user.info["ap_enabled"]
602 assert user.info["note_count"] == 1
603 assert user.follower_address == "https://niu.moe/users/rye/followers"
604
605 # Wait for the background task
606 :timer.sleep(1000)
607
608 user = Repo.get(User, user.id)
609 assert user.info["note_count"] == 1
610
611 activity = Repo.get(Activity, activity.id)
612 assert user.follower_address in activity.recipients
613
614 assert %{
615 "url" => [
616 %{
617 "href" =>
618 "https://cdn.niu.moe/accounts/avatars/000/033/323/original/fd7f8ae0b3ffedc9.jpeg"
619 }
620 ]
621 } = user.avatar
622
623 assert %{
624 "url" => [
625 %{
626 "href" =>
627 "https://cdn.niu.moe/accounts/headers/000/033/323/original/850b3448fa5fd477.png"
628 }
629 ]
630 } = user.info["banner"]
631
632 refute "..." in activity.recipients
633
634 unrelated_activity = Repo.get(Activity, unrelated_activity.id)
635 refute user.follower_address in unrelated_activity.recipients
636
637 user_two = Repo.get(User, user_two.id)
638 assert user.follower_address in user_two.following
639 refute "..." in user_two.following
640 end
641 end
642
643 describe "maybe_retire_websub" do
644 test "it deletes all websub client subscripitions with the user as topic" do
645 subscription = %WebsubClientSubscription{topic: "https://niu.moe/users/rye.atom"}
646 {:ok, ws} = Repo.insert(subscription)
647
648 subscription = %WebsubClientSubscription{topic: "https://niu.moe/users/pasty.atom"}
649 {:ok, ws2} = Repo.insert(subscription)
650
651 Transmogrifier.maybe_retire_websub("https://niu.moe/users/rye")
652
653 refute Repo.get(WebsubClientSubscription, ws.id)
654 assert Repo.get(WebsubClientSubscription, ws2.id)
655 end
656 end
657
658 describe "actor rewriting" do
659 test "it fixes the actor URL property to be a proper URI" do
660 data = %{
661 "url" => %{"href" => "http://example.com"}
662 }
663
664 rewritten = Transmogrifier.maybe_fix_user_object(data)
665 assert rewritten["url"] == "http://example.com"
666 end
667 end
668 end