1 defmodule Pleroma.Web.ActivityPub.ObjectValidatorTest do
5 alias Pleroma.Web.ActivityPub.Builder
6 alias Pleroma.Web.ActivityPub.ObjectValidator
7 alias Pleroma.Web.ActivityPub.ObjectValidators.LikeValidator
8 alias Pleroma.Web.ActivityPub.Utils
9 alias Pleroma.Web.CommonAPI
11 import Pleroma.Factory
13 describe "chat message create activities" do
14 test "it is invalid if the object already exists" do
16 recipient = insert(:user)
17 {:ok, activity} = CommonAPI.post_chat_message(user, recipient, "hey")
18 object = Object.normalize(activity, false)
20 {:ok, create_data, _} = Builder.create(user, object.data, [recipient.ap_id])
22 {:error, cng} = ObjectValidator.validate(create_data, [])
24 assert {:object, {"The object to create already exists", []}} in cng.errors
27 test "it is invalid if the object data has a different `to` or `actor` field" do
29 recipient = insert(:user)
30 {:ok, object_data, _} = Builder.chat_message(recipient, user.ap_id, "Hey")
32 {:ok, create_data, _} = Builder.create(user, object_data, [recipient.ap_id])
34 {:error, cng} = ObjectValidator.validate(create_data, [])
36 assert {:to, {"Recipients don't match with object recipients", []}} in cng.errors
37 assert {:actor, {"Actor doesn't match with object actor", []}} in cng.errors
41 describe "chat messages" do
43 clear_config([:instance, :remote_limit])
45 recipient = insert(:user, local: false)
47 {:ok, valid_chat_message, _} = Builder.chat_message(user, recipient.ap_id, "hey :firefox:")
49 %{user: user, recipient: recipient, valid_chat_message: valid_chat_message}
52 test "validates for a basic object we build", %{valid_chat_message: valid_chat_message} do
53 assert {:ok, object, _meta} = ObjectValidator.validate(valid_chat_message, [])
55 assert object == valid_chat_message
58 test "does not validate if the message is longer than the remote_limit", %{
59 valid_chat_message: valid_chat_message
61 Pleroma.Config.put([:instance, :remote_limit], 2)
62 refute match?({:ok, _object, _meta}, ObjectValidator.validate(valid_chat_message, []))
65 test "does not validate if the recipient is blocking the actor", %{
66 valid_chat_message: valid_chat_message,
70 Pleroma.User.block(recipient, user)
71 refute match?({:ok, _object, _meta}, ObjectValidator.validate(valid_chat_message, []))
74 test "does not validate if the actor or the recipient is not in our system", %{
75 valid_chat_message: valid_chat_message
79 |> Map.put("actor", "https://raymoo.com/raymoo")
81 {:error, _} = ObjectValidator.validate(chat_message, [])
85 |> Map.put("to", ["https://raymoo.com/raymoo"])
87 {:error, _} = ObjectValidator.validate(chat_message, [])
90 test "does not validate for a message with multiple recipients", %{
91 valid_chat_message: valid_chat_message,
97 |> Map.put("to", [user.ap_id, recipient.ap_id])
99 assert {:error, _} = ObjectValidator.validate(chat_message, [])
102 test "does not validate if it doesn't concern local users" do
103 user = insert(:user, local: false)
104 recipient = insert(:user, local: false)
106 {:ok, valid_chat_message, _} = Builder.chat_message(user, recipient.ap_id, "hey")
107 assert {:error, _} = ObjectValidator.validate(valid_chat_message, [])
114 {:ok, post_activity} = CommonAPI.post(user, %{"status" => "uguu"})
117 "to" => [user.ap_id],
120 "id" => Utils.generate_activity_id(),
121 "object" => post_activity.data["object"],
122 "actor" => user.ap_id,
123 "context" => "a context"
126 %{valid_like: valid_like, user: user, post_activity: post_activity}
129 test "returns ok when called in the ObjectValidator", %{valid_like: valid_like} do
130 {:ok, object, _meta} = ObjectValidator.validate(valid_like, [])
132 assert "id" in Map.keys(object)
135 test "is valid for a valid object", %{valid_like: valid_like} do
136 assert LikeValidator.cast_and_validate(valid_like).valid?
139 test "it errors when the actor is missing or not known", %{valid_like: valid_like} do
140 without_actor = Map.delete(valid_like, "actor")
142 refute LikeValidator.cast_and_validate(without_actor).valid?
144 with_invalid_actor = Map.put(valid_like, "actor", "invalidactor")
146 refute LikeValidator.cast_and_validate(with_invalid_actor).valid?
149 test "it errors when the object is missing or not known", %{valid_like: valid_like} do
150 without_object = Map.delete(valid_like, "object")
152 refute LikeValidator.cast_and_validate(without_object).valid?
154 with_invalid_object = Map.put(valid_like, "object", "invalidobject")
156 refute LikeValidator.cast_and_validate(with_invalid_object).valid?
159 test "it errors when the actor has already like the object", %{
160 valid_like: valid_like,
162 post_activity: post_activity
164 _like = CommonAPI.favorite(user, post_activity.id)
166 refute LikeValidator.cast_and_validate(valid_like).valid?
169 test "it works when actor or object are wrapped in maps", %{valid_like: valid_like} do
172 |> Map.put("actor", %{"id" => valid_like["actor"]})
173 |> Map.put("object", %{"id" => valid_like["object"]})
175 validated = LikeValidator.cast_and_validate(wrapped_like)
177 assert validated.valid?
179 assert {:actor, valid_like["actor"]} in validated.changes
180 assert {:object, valid_like["object"]} in validated.changes