1 # Pleroma: A lightweight social networking server
2 # Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
3 # SPDX-License-Identifier: AGPL-3.0-only
5 defmodule Pleroma.Web.ActivityPub.ObjectValidators.UpdateHandlingTest do
6 use Pleroma.DataCase, async: true
8 alias Pleroma.Web.ActivityPub.Builder
9 alias Pleroma.Web.ActivityPub.ObjectValidator
11 import Pleroma.Factory
19 "name" => "A new name",
20 "summary" => "A new bio"
23 {:ok, valid_update, []} = Builder.update(user, object)
25 %{user: user, valid_update: valid_update}
28 test "validates a basic object", %{valid_update: valid_update} do
29 assert {:ok, _update, []} = ObjectValidator.validate(valid_update, [])
32 test "returns an error if the object can't be updated by the actor", %{
33 valid_update: valid_update
35 other_user = insert(:user, local: false)
39 |> Map.put("actor", other_user.ap_id)
41 assert {:error, _cng} = ObjectValidator.validate(update, [])
44 test "validates as long as the object is same-origin with the actor", %{
45 valid_update: valid_update
47 other_user = insert(:user)
51 |> Map.put("actor", other_user.ap_id)
53 assert {:ok, _update, []} = ObjectValidator.validate(update, [])
56 test "validates if the object is not of an Actor type" do
58 updated_note = note.data |> Map.put("content", "edited content")
59 other_user = insert(:user)
61 {:ok, update, _} = Builder.update(other_user, updated_note)
63 assert {:ok, _update, _} = ObjectValidator.validate(update, [])
67 describe "update note" do
68 test "converts object into Pleroma's format" do
72 "mediaType" => "image/png",
74 "url" => "https://somewhere.org/emoji/url/1.png"
76 "id" => "https://somewhere.org/emoji/1",
77 "name" => ":some_emoji:",
79 "updated" => "2021-04-07T11:00:00Z"
84 note = insert(:note, user: user)
88 |> Map.put("content", "edited content")
89 |> Map.put("tag", mastodon_tags)
91 {:ok, update, _} = Builder.update(user, updated_note)
93 assert {:ok, _update, meta} = ObjectValidator.validate(update, [])
95 assert %{"emoji" => %{"some_emoji" => "https://somewhere.org/emoji/url/1.png"}} =
99 test "returns no object_data in meta for a local Update" do
101 note = insert(:note, user: user)
105 |> Map.put("content", "edited content")
107 {:ok, update, _} = Builder.update(user, updated_note)
109 assert {:ok, _update, meta} = ObjectValidator.validate(update, local: true)
110 assert is_nil(meta[:object_data])
113 test "returns object_data in meta for a remote Update" do
115 note = insert(:note, user: user)
119 |> Map.put("content", "edited content")
121 {:ok, update, _} = Builder.update(user, updated_note)
123 assert {:ok, _update, meta} = ObjectValidator.validate(update, local: false)
124 assert meta[:object_data]
126 assert {:ok, _update, meta} = ObjectValidator.validate(update, [])
127 assert meta[:object_data]
131 describe "update with history" do
134 {:ok, activity} = Pleroma.Web.CommonAPI.post(user, %{status: "mew mew :dinosaur:"})
135 {:ok, edit} = Pleroma.Web.CommonAPI.update(user, activity, %{status: "edited :blank:"})
136 {:ok, external_rep} = Pleroma.Web.ActivityPub.Transmogrifier.prepare_outgoing(edit.data)
137 %{external_rep: external_rep}
140 test "edited note", %{external_rep: external_rep} do
141 {:ok, _validate_res, meta} = ObjectValidator.validate(external_rep, [])
143 assert %{"formerRepresentations" => %{"orderedItems" => [%{"emoji" => %{"dinosaur" => _}}]}} =
147 test "edited note, badly-formed formerRepresentations", %{external_rep: external_rep} do
148 external_rep = put_in(external_rep, ["object", "formerRepresentations"], %{})
150 assert {:error, _} = ObjectValidator.validate(external_rep, [])
153 test "edited note, badly-formed history item", %{external_rep: external_rep} do
155 Enum.at(external_rep["object"]["formerRepresentations"]["orderedItems"], 0)
156 |> Map.put("type", "Foo")
161 ["object", "formerRepresentations", "orderedItems"],
165 assert {:error, _} = ObjectValidator.validate(external_rep, [])