1 # Pleroma: A lightweight social networking server
2 # Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
3 # SPDX-License-Identifier: AGPL-3.0-only
5 defmodule Pleroma.Web.ActivityPub.ActivityPubTest do
7 use Oban.Testing, repo: Pleroma.Repo
10 alias Pleroma.Builders.ActivityBuilder
12 alias Pleroma.Notification
15 alias Pleroma.Web.ActivityPub.ActivityPub
16 alias Pleroma.Web.ActivityPub.Utils
17 alias Pleroma.Web.AdminAPI.AccountView
18 alias Pleroma.Web.CommonAPI
20 import ExUnit.CaptureLog
22 import Pleroma.Factory
26 clear_config([Pleroma.Upload, :uploader], Pleroma.Uploaders.Local)
27 clear_config([Pleroma.Uploaders.Local, :uploads], "uploads")
28 mock(fn env -> apply(HttpRequestMock, :request, [env]) end)
32 setup do: clear_config([:instance, :federating])
34 describe "streaming out participations" do
35 test "it streams them out" do
37 {:ok, activity} = CommonAPI.post(user, %{status: ".", visibility: "direct"})
39 {:ok, conversation} = Pleroma.Conversation.create_or_bump_for(activity)
42 conversation.participations
43 |> Repo.preload(:user)
45 with_mock Pleroma.Web.Streamer,
46 stream: fn _, _ -> nil end do
47 ActivityPub.stream_out_participations(conversation.participations)
49 assert called(Pleroma.Web.Streamer.stream("participation", participations))
53 test "streams them out on activity creation" do
54 user_one = insert(:user)
55 user_two = insert(:user)
57 with_mock Pleroma.Web.Streamer,
58 stream: fn _, _ -> nil end do
60 CommonAPI.post(user_one, %{
61 status: "@#{user_two.nickname}",
66 activity.data["context"]
67 |> Pleroma.Conversation.get_for_ap_id()
68 |> Repo.preload(participations: :user)
70 assert called(Pleroma.Web.Streamer.stream("participation", conversation.participations))
75 describe "fetching restricted by visibility" do
76 test "it restricts by the appropriate visibility" do
79 {:ok, public_activity} = CommonAPI.post(user, %{status: ".", visibility: "public"})
81 {:ok, direct_activity} = CommonAPI.post(user, %{status: ".", visibility: "direct"})
83 {:ok, unlisted_activity} = CommonAPI.post(user, %{status: ".", visibility: "unlisted"})
85 {:ok, private_activity} = CommonAPI.post(user, %{status: ".", visibility: "private"})
87 activities = ActivityPub.fetch_activities([], %{visibility: "direct", actor_id: user.ap_id})
89 assert activities == [direct_activity]
92 ActivityPub.fetch_activities([], %{visibility: "unlisted", actor_id: user.ap_id})
94 assert activities == [unlisted_activity]
97 ActivityPub.fetch_activities([], %{visibility: "private", actor_id: user.ap_id})
99 assert activities == [private_activity]
101 activities = ActivityPub.fetch_activities([], %{visibility: "public", actor_id: user.ap_id})
103 assert activities == [public_activity]
106 ActivityPub.fetch_activities([], %{
107 visibility: ~w[private public],
111 assert activities == [public_activity, private_activity]
115 describe "fetching excluded by visibility" do
116 test "it excludes by the appropriate visibility" do
119 {:ok, public_activity} = CommonAPI.post(user, %{status: ".", visibility: "public"})
121 {:ok, direct_activity} = CommonAPI.post(user, %{status: ".", visibility: "direct"})
123 {:ok, unlisted_activity} = CommonAPI.post(user, %{status: ".", visibility: "unlisted"})
125 {:ok, private_activity} = CommonAPI.post(user, %{status: ".", visibility: "private"})
128 ActivityPub.fetch_activities([], %{
129 exclude_visibilities: "direct",
133 assert public_activity in activities
134 assert unlisted_activity in activities
135 assert private_activity in activities
136 refute direct_activity in activities
139 ActivityPub.fetch_activities([], %{
140 exclude_visibilities: "unlisted",
144 assert public_activity in activities
145 refute unlisted_activity in activities
146 assert private_activity in activities
147 assert direct_activity in activities
150 ActivityPub.fetch_activities([], %{
151 exclude_visibilities: "private",
155 assert public_activity in activities
156 assert unlisted_activity in activities
157 refute private_activity in activities
158 assert direct_activity in activities
161 ActivityPub.fetch_activities([], %{
162 exclude_visibilities: "public",
166 refute public_activity in activities
167 assert unlisted_activity in activities
168 assert private_activity in activities
169 assert direct_activity in activities
173 describe "building a user from his ap id" do
174 test "it returns a user" do
175 user_id = "http://mastodon.example.org/users/admin"
176 {:ok, user} = ActivityPub.make_user_from_ap_id(user_id)
177 assert user.ap_id == user_id
178 assert user.nickname == "admin@mastodon.example.org"
179 assert user.ap_enabled
180 assert user.follower_address == "http://mastodon.example.org/users/admin/followers"
183 test "it returns a user that is invisible" do
184 user_id = "http://mastodon.example.org/users/relay"
185 {:ok, user} = ActivityPub.make_user_from_ap_id(user_id)
186 assert User.invisible?(user)
189 test "it returns a user that accepts chat messages" do
190 user_id = "http://mastodon.example.org/users/admin"
191 {:ok, user} = ActivityPub.make_user_from_ap_id(user_id)
193 assert user.accepts_chat_messages
196 test "works for guppe actors" do
197 user_id = "https://gup.pe/u/bernie2020"
200 %{method: :get, url: ^user_id} ->
203 body: File.read!("test/fixtures/guppe-actor.json"),
204 headers: [{"content-type", "application/activity+json"}]
208 {:ok, user} = ActivityPub.make_user_from_ap_id(user_id)
210 assert user.name == "Bernie2020 group"
211 assert user.actor_type == "Group"
214 test "works for bridgy actors" do
215 user_id = "https://fed.brid.gy/jk.nipponalba.scot"
218 %{method: :get, url: ^user_id} ->
221 body: File.read!("test/fixtures/bridgy/actor.json"),
222 headers: [{"content-type", "application/activity+json"}]
226 {:ok, user} = ActivityPub.make_user_from_ap_id(user_id)
228 assert user.actor_type == "Person"
230 assert user.avatar == %{
232 "url" => [%{"href" => "https://jk.nipponalba.scot/images/profile.jpg"}]
235 assert user.banner == %{
237 "url" => [%{"href" => "https://jk.nipponalba.scot/images/profile.jpg"}]
241 test "fetches user featured collection" do
242 ap_id = "https://example.com/users/lain"
244 featured_url = "https://example.com/users/lain/collections/featured"
247 "test/fixtures/users_mock/user.json"
249 |> String.replace("{{nickname}}", "lain")
251 |> Map.put("featured", featured_url)
254 object_id = Ecto.UUID.generate()
257 "test/fixtures/mastodon/collections/featured.json"
259 |> String.replace("{{domain}}", "example.com")
260 |> String.replace("{{nickname}}", "lain")
261 |> String.replace("{{object_id}}", object_id)
263 object_url = "https://example.com/objects/#{object_id}"
266 "test/fixtures/statuses/note.json"
268 |> String.replace("{{object_id}}", object_id)
269 |> String.replace("{{nickname}}", "lain")
279 headers: [{"content-type", "application/activity+json"}]
289 headers: [{"content-type", "application/activity+json"}]
293 Tesla.Mock.mock_global(fn
301 headers: [{"content-type", "application/activity+json"}]
305 {:ok, user} = ActivityPub.make_user_from_ap_id(ap_id)
308 assert user.featured_address == featured_url
309 assert Map.has_key?(user.pinned_objects, object_url)
311 in_db = Pleroma.User.get_by_ap_id(ap_id)
312 assert in_db.featured_address == featured_url
313 assert Map.has_key?(user.pinned_objects, object_url)
315 assert %{data: %{"id" => ^object_url}} = Object.get_by_ap_id(object_url)
319 test "fetches user featured collection using the first property" do
320 featured_url = "https://friendica.example.com/raha/collections/featured"
321 first_url = "https://friendica.example.com/featured/raha?page=1"
324 "test/fixtures/friendica/friendica_featured_collection.json"
328 "test/fixtures/friendica/friendica_featured_collection_first.json"
339 headers: [{"content-type", "application/activity+json"}]
349 headers: [{"content-type", "application/activity+json"}]
353 {:ok, data} = ActivityPub.fetch_and_prepare_featured_from_ap_id(featured_url)
354 assert Map.has_key?(data, "http://inserted")
357 test "it fetches the appropriate tag-restricted posts" do
360 {:ok, status_one} = CommonAPI.post(user, %{status: ". #TEST"})
361 {:ok, status_two} = CommonAPI.post(user, %{status: ". #essais"})
362 {:ok, status_three} = CommonAPI.post(user, %{status: ". #test #Reject"})
364 {:ok, status_four} = CommonAPI.post(user, %{status: ". #Any1 #any2"})
365 {:ok, status_five} = CommonAPI.post(user, %{status: ". #Any2 #any1"})
367 for hashtag_timeline_strategy <- [:enabled, :disabled] do
368 clear_config([:features, :improved_hashtag_timeline], hashtag_timeline_strategy)
370 fetch_one = ActivityPub.fetch_activities([], %{type: "Create", tag: "test"})
372 fetch_two = ActivityPub.fetch_activities([], %{type: "Create", tag: ["TEST", "essais"]})
375 ActivityPub.fetch_activities([], %{
377 tag: ["test", "Essais"],
378 tag_reject: ["reject"]
382 ActivityPub.fetch_activities([], %{
385 tag_all: ["test", "REJECT"]
388 # Testing that deduplication (if needed) is done on DB (not Ecto) level; :limit is important
390 ActivityPub.fetch_activities([], %{
392 tag: ["ANY1", "any2"],
397 ActivityPub.fetch_activities([], %{
399 tag: ["any1", "Any2"],
404 # Regression test: passing empty lists as filter options shouldn't affect the results
405 assert fetch_five == fetch_six
407 [fetch_one, fetch_two, fetch_three, fetch_four, fetch_five] =
408 Enum.map([fetch_one, fetch_two, fetch_three, fetch_four, fetch_five], fn statuses ->
409 Enum.map(statuses, fn s -> Repo.preload(s, object: :hashtags) end)
412 assert fetch_one == [status_one, status_three]
413 assert fetch_two == [status_one, status_two, status_three]
414 assert fetch_three == [status_one, status_two]
415 assert fetch_four == [status_three]
416 assert fetch_five == [status_four, status_five]
420 describe "insertion" do
421 test "drops activities beyond a certain limit" do
422 limit = Config.get([:instance, :remote_limit])
425 :crypto.strong_rand_bytes(limit + 1)
427 |> binary_part(0, limit + 1)
432 "content" => random_text
436 assert {:error, :remote_limit} = ActivityPub.insert(data)
439 test "doesn't drop activities with content being null" do
443 "actor" => user.ap_id,
446 "actor" => user.ap_id,
453 assert {:ok, _} = ActivityPub.insert(data)
456 test "returns the activity if one with the same id is already in" do
457 activity = insert(:note_activity)
458 {:ok, new_activity} = ActivityPub.insert(activity.data)
460 assert activity.id == new_activity.id
463 test "inserts a given map into the activity database, giving it an id if it has none." do
467 "actor" => user.ap_id,
470 "actor" => user.ap_id,
477 {:ok, %Activity{} = activity} = ActivityPub.insert(data)
478 assert activity.data["ok"] == data["ok"]
479 assert is_binary(activity.data["id"])
485 "actor" => user.ap_id,
487 "context" => "blabla",
489 "actor" => user.ap_id,
496 {:ok, %Activity{} = activity} = ActivityPub.insert(data)
497 assert activity.data["ok"] == data["ok"]
498 assert activity.data["id"] == given_id
499 assert activity.data["context"] == "blabla"
500 assert activity.data["context_id"]
503 test "adds a context when none is there" do
507 "actor" => user.ap_id,
510 "actor" => user.ap_id,
517 {:ok, %Activity{} = activity} = ActivityPub.insert(data)
518 object = Pleroma.Object.normalize(activity, fetch: false)
520 assert is_binary(activity.data["context"])
521 assert is_binary(object.data["context"])
522 assert activity.data["context_id"]
523 assert object.data["context_id"]
526 test "adds an id to a given object if it lacks one and is a note and inserts it to the object database" do
530 "actor" => user.ap_id,
533 "actor" => user.ap_id,
540 {:ok, %Activity{} = activity} = ActivityPub.insert(data)
541 assert object = Object.normalize(activity, fetch: false)
542 assert is_binary(object.data["id"])
546 describe "create activities" do
548 [user: insert(:user)]
551 test "it reverts create", %{user: user} do
552 with_mock(Utils, [:passthrough], maybe_federate: fn _ -> {:error, :reverted} end) do
553 assert {:error, :reverted} =
554 ActivityPub.create(%{
555 to: ["user1", "user2"],
559 "to" => ["user1", "user2"],
561 "content" => "testing"
566 assert Repo.aggregate(Activity, :count, :id) == 0
567 assert Repo.aggregate(Object, :count, :id) == 0
570 test "creates activity if expiration is not configured and expires_at is not passed", %{
573 clear_config([Pleroma.Workers.PurgeExpiredActivity, :enabled], false)
576 ActivityPub.create(%{
577 to: ["user1", "user2"],
581 "to" => ["user1", "user2"],
583 "content" => "testing"
588 test "rejects activity if expires_at present but expiration is not configured", %{user: user} do
589 clear_config([Pleroma.Workers.PurgeExpiredActivity, :enabled], false)
591 assert {:error, :expired_activities_disabled} =
592 ActivityPub.create(%{
593 to: ["user1", "user2"],
597 "to" => ["user1", "user2"],
599 "content" => "testing"
602 "expires_at" => DateTime.utc_now()
606 assert Repo.aggregate(Activity, :count, :id) == 0
607 assert Repo.aggregate(Object, :count, :id) == 0
610 test "removes doubled 'to' recipients", %{user: user} do
612 ActivityPub.create(%{
613 to: ["user1", "user1", "user2"],
617 "to" => ["user1", "user1", "user2"],
619 "content" => "testing"
623 assert activity.data["to"] == ["user1", "user2"]
624 assert activity.actor == user.ap_id
625 assert activity.recipients == ["user1", "user2", user.ap_id]
628 test "increases user note count only for public activities", %{user: user} do
630 CommonAPI.post(User.get_cached_by_id(user.id), %{
636 CommonAPI.post(User.get_cached_by_id(user.id), %{
638 visibility: "unlisted"
642 CommonAPI.post(User.get_cached_by_id(user.id), %{
644 visibility: "private"
648 CommonAPI.post(User.get_cached_by_id(user.id), %{
653 user = User.get_cached_by_id(user.id)
654 assert user.note_count == 2
657 test "increases replies count", %{user: user} do
658 user2 = insert(:user)
660 {:ok, activity} = CommonAPI.post(user, %{status: "1", visibility: "public"})
661 ap_id = activity.data["id"]
662 reply_data = %{status: "1", in_reply_to_status_id: activity.id}
665 {:ok, _} = CommonAPI.post(user2, Map.put(reply_data, :visibility, "public"))
666 assert %{data: _data, object: object} = Activity.get_by_ap_id_with_object(ap_id)
667 assert object.data["repliesCount"] == 1
670 {:ok, _} = CommonAPI.post(user2, Map.put(reply_data, :visibility, "unlisted"))
671 assert %{data: _data, object: object} = Activity.get_by_ap_id_with_object(ap_id)
672 assert object.data["repliesCount"] == 2
675 {:ok, _} = CommonAPI.post(user2, Map.put(reply_data, :visibility, "private"))
676 assert %{data: _data, object: object} = Activity.get_by_ap_id_with_object(ap_id)
677 assert object.data["repliesCount"] == 2
680 {:ok, _} = CommonAPI.post(user2, Map.put(reply_data, :visibility, "direct"))
681 assert %{data: _data, object: object} = Activity.get_by_ap_id_with_object(ap_id)
682 assert object.data["repliesCount"] == 2
686 describe "fetch activities for recipients" do
687 test "retrieve the activities for certain recipients" do
688 {:ok, activity_one} = ActivityBuilder.insert(%{"to" => ["someone"]})
689 {:ok, activity_two} = ActivityBuilder.insert(%{"to" => ["someone_else"]})
690 {:ok, _activity_three} = ActivityBuilder.insert(%{"to" => ["noone"]})
692 activities = ActivityPub.fetch_activities(["someone", "someone_else"])
693 assert length(activities) == 2
694 assert activities == [activity_one, activity_two]
698 describe "fetch activities in context" do
699 test "retrieves activities that have a given context" do
700 {:ok, activity} = ActivityBuilder.insert(%{"type" => "Create", "context" => "2hu"})
701 {:ok, activity_two} = ActivityBuilder.insert(%{"type" => "Create", "context" => "2hu"})
702 {:ok, _activity_three} = ActivityBuilder.insert(%{"type" => "Create", "context" => "3hu"})
703 {:ok, _activity_four} = ActivityBuilder.insert(%{"type" => "Announce", "context" => "2hu"})
704 activity_five = insert(:note_activity)
707 {:ok, _user_relationship} = User.block(user, %{ap_id: activity_five.data["actor"]})
709 activities = ActivityPub.fetch_activities_for_context("2hu", %{blocking_user: user})
710 assert activities == [activity_two, activity]
713 test "doesn't return activities with filtered words" do
715 user_two = insert(:user)
716 insert(:filter, user: user, phrase: "test", hide: true)
718 {:ok, %{id: id1, data: %{"context" => context}}} = CommonAPI.post(user, %{status: "1"})
720 {:ok, %{id: id2}} = CommonAPI.post(user_two, %{status: "2", in_reply_to_status_id: id1})
722 {:ok, %{id: id3} = user_activity} =
723 CommonAPI.post(user, %{status: "3 test?", in_reply_to_status_id: id2})
725 {:ok, %{id: id4} = filtered_activity} =
726 CommonAPI.post(user_two, %{status: "4 test!", in_reply_to_status_id: id3})
728 {:ok, _} = CommonAPI.post(user, %{status: "5", in_reply_to_status_id: id4})
732 |> ActivityPub.fetch_activities_for_context(%{user: user})
735 assert length(activities) == 4
736 assert user_activity.id in activities
737 refute filtered_activity.id in activities
741 test "doesn't return blocked activities" do
742 activity_one = insert(:note_activity)
743 activity_two = insert(:note_activity)
744 activity_three = insert(:note_activity)
746 booster = insert(:user)
747 {:ok, _user_relationship} = User.block(user, %{ap_id: activity_one.data["actor"]})
749 activities = ActivityPub.fetch_activities([], %{blocking_user: user, skip_preload: true})
751 assert Enum.member?(activities, activity_two)
752 assert Enum.member?(activities, activity_three)
753 refute Enum.member?(activities, activity_one)
755 {:ok, _user_block} = User.unblock(user, %{ap_id: activity_one.data["actor"]})
757 activities = ActivityPub.fetch_activities([], %{blocking_user: user, skip_preload: true})
759 assert Enum.member?(activities, activity_two)
760 assert Enum.member?(activities, activity_three)
761 assert Enum.member?(activities, activity_one)
763 {:ok, _user_relationship} = User.block(user, %{ap_id: activity_three.data["actor"]})
764 {:ok, %{data: %{"object" => id}}} = CommonAPI.repeat(activity_three.id, booster)
765 %Activity{} = boost_activity = Activity.get_create_by_object_ap_id(id)
766 activity_three = Activity.get_by_id(activity_three.id)
768 activities = ActivityPub.fetch_activities([], %{blocking_user: user, skip_preload: true})
770 assert Enum.member?(activities, activity_two)
771 refute Enum.member?(activities, activity_three)
772 refute Enum.member?(activities, boost_activity)
773 assert Enum.member?(activities, activity_one)
775 activities = ActivityPub.fetch_activities([], %{blocking_user: nil, skip_preload: true})
777 assert Enum.member?(activities, activity_two)
778 assert Enum.member?(activities, activity_three)
779 assert Enum.member?(activities, boost_activity)
780 assert Enum.member?(activities, activity_one)
783 test "doesn't return activities from deactivated users" do
784 _user = insert(:user)
785 deactivated = insert(:user)
786 active = insert(:user)
787 {:ok, activity_one} = CommonAPI.post(deactivated, %{status: "hey!"})
788 {:ok, activity_two} = CommonAPI.post(active, %{status: "yay!"})
789 {:ok, _updated_user} = User.set_activation(deactivated, false)
791 activities = ActivityPub.fetch_activities([], %{})
793 refute Enum.member?(activities, activity_one)
794 assert Enum.member?(activities, activity_two)
797 test "always see your own posts even when they address people you block" do
799 blockee = insert(:user)
801 {:ok, _} = User.block(user, blockee)
802 {:ok, activity} = CommonAPI.post(user, %{status: "hey! @#{blockee.nickname}"})
804 activities = ActivityPub.fetch_activities([], %{blocking_user: user})
806 assert Enum.member?(activities, activity)
809 test "doesn't return transitive interactions concerning blocked users" do
810 blocker = insert(:user)
811 blockee = insert(:user)
812 friend = insert(:user)
814 {:ok, _user_relationship} = User.block(blocker, blockee)
816 {:ok, activity_one} = CommonAPI.post(friend, %{status: "hey!"})
818 {:ok, activity_two} = CommonAPI.post(friend, %{status: "hey! @#{blockee.nickname}"})
820 {:ok, activity_three} = CommonAPI.post(blockee, %{status: "hey! @#{friend.nickname}"})
822 {:ok, activity_four} = CommonAPI.post(blockee, %{status: "hey! @#{blocker.nickname}"})
824 activities = ActivityPub.fetch_activities([], %{blocking_user: blocker})
826 assert Enum.member?(activities, activity_one)
827 refute Enum.member?(activities, activity_two)
828 refute Enum.member?(activities, activity_three)
829 refute Enum.member?(activities, activity_four)
832 test "doesn't return announce activities with blocked users in 'to'" do
833 blocker = insert(:user)
834 blockee = insert(:user)
835 friend = insert(:user)
837 {:ok, _user_relationship} = User.block(blocker, blockee)
839 {:ok, activity_one} = CommonAPI.post(friend, %{status: "hey!"})
841 {:ok, activity_two} = CommonAPI.post(blockee, %{status: "hey! @#{friend.nickname}"})
843 {:ok, activity_three} = CommonAPI.repeat(activity_two.id, friend)
846 ActivityPub.fetch_activities([], %{blocking_user: blocker})
847 |> Enum.map(fn act -> act.id end)
849 assert Enum.member?(activities, activity_one.id)
850 refute Enum.member?(activities, activity_two.id)
851 refute Enum.member?(activities, activity_three.id)
854 test "doesn't return announce activities with blocked users in 'cc'" do
855 blocker = insert(:user)
856 blockee = insert(:user)
857 friend = insert(:user)
859 {:ok, _user_relationship} = User.block(blocker, blockee)
861 {:ok, activity_one} = CommonAPI.post(friend, %{status: "hey!"})
863 {:ok, activity_two} = CommonAPI.post(blockee, %{status: "hey! @#{friend.nickname}"})
865 assert object = Pleroma.Object.normalize(activity_two, fetch: false)
868 "actor" => friend.ap_id,
869 "object" => object.data["id"],
870 "context" => object.data["context"],
871 "type" => "Announce",
872 "to" => ["https://www.w3.org/ns/activitystreams#Public"],
873 "cc" => [blockee.ap_id]
876 assert {:ok, activity_three} = ActivityPub.insert(data)
879 ActivityPub.fetch_activities([], %{blocking_user: blocker})
880 |> Enum.map(fn act -> act.id end)
882 assert Enum.member?(activities, activity_one.id)
883 refute Enum.member?(activities, activity_two.id)
884 refute Enum.member?(activities, activity_three.id)
887 test "doesn't return activities from blocked domains" do
888 domain = "dogwhistle.zone"
889 domain_user = insert(:user, %{ap_id: "https://#{domain}/@pundit"})
890 note = insert(:note, %{data: %{"actor" => domain_user.ap_id}})
891 activity = insert(:note_activity, %{note: note})
893 {:ok, user} = User.block_domain(user, domain)
895 activities = ActivityPub.fetch_activities([], %{blocking_user: user, skip_preload: true})
897 refute activity in activities
899 followed_user = insert(:user)
900 CommonAPI.follow(user, followed_user)
901 {:ok, repeat_activity} = CommonAPI.repeat(activity.id, followed_user)
903 activities = ActivityPub.fetch_activities([], %{blocking_user: user, skip_preload: true})
905 refute repeat_activity in activities
908 test "see your own posts even when they adress actors from blocked domains" do
911 domain = "dogwhistle.zone"
912 domain_user = insert(:user, %{ap_id: "https://#{domain}/@pundit"})
914 {:ok, user} = User.block_domain(user, domain)
916 {:ok, activity} = CommonAPI.post(user, %{status: "hey! @#{domain_user.nickname}"})
918 activities = ActivityPub.fetch_activities([], %{blocking_user: user})
920 assert Enum.member?(activities, activity)
923 test "does return activities from followed users on blocked domains" do
924 domain = "meanies.social"
925 domain_user = insert(:user, %{ap_id: "https://#{domain}/@pundit"})
926 blocker = insert(:user)
928 {:ok, blocker, domain_user} = User.follow(blocker, domain_user)
929 {:ok, blocker} = User.block_domain(blocker, domain)
931 assert User.following?(blocker, domain_user)
932 assert User.blocks_domain?(blocker, domain_user)
933 refute User.blocks?(blocker, domain_user)
935 note = insert(:note, %{data: %{"actor" => domain_user.ap_id}})
936 activity = insert(:note_activity, %{note: note})
938 activities = ActivityPub.fetch_activities([], %{blocking_user: blocker, skip_preload: true})
940 assert activity in activities
942 # And check that if the guy we DO follow boosts someone else from their domain,
943 # that should be hidden
944 another_user = insert(:user, %{ap_id: "https://#{domain}/@meanie2"})
945 bad_note = insert(:note, %{data: %{"actor" => another_user.ap_id}})
946 bad_activity = insert(:note_activity, %{note: bad_note})
947 {:ok, repeat_activity} = CommonAPI.repeat(bad_activity.id, domain_user)
949 activities = ActivityPub.fetch_activities([], %{blocking_user: blocker, skip_preload: true})
951 refute repeat_activity in activities
954 test "returns your own posts regardless of mute" do
956 muted = insert(:user)
958 {:ok, muted_post} = CommonAPI.post(muted, %{status: "Im stupid"})
961 CommonAPI.post(user, %{status: "I'm muting you", in_reply_to_status_id: muted_post.id})
963 {:ok, _} = User.mute(user, muted)
965 [activity] = ActivityPub.fetch_activities([], %{muting_user: user, skip_preload: true})
967 assert activity.id == reply.id
970 test "doesn't return muted activities" do
971 activity_one = insert(:note_activity)
972 activity_two = insert(:note_activity)
973 activity_three = insert(:note_activity)
975 booster = insert(:user)
977 activity_one_actor = User.get_by_ap_id(activity_one.data["actor"])
978 {:ok, _user_relationships} = User.mute(user, activity_one_actor)
980 activities = ActivityPub.fetch_activities([], %{muting_user: user, skip_preload: true})
982 assert Enum.member?(activities, activity_two)
983 assert Enum.member?(activities, activity_three)
984 refute Enum.member?(activities, activity_one)
986 # Calling with 'with_muted' will deliver muted activities, too.
988 ActivityPub.fetch_activities([], %{
994 assert Enum.member?(activities, activity_two)
995 assert Enum.member?(activities, activity_three)
996 assert Enum.member?(activities, activity_one)
998 {:ok, _user_mute} = User.unmute(user, activity_one_actor)
1000 activities = ActivityPub.fetch_activities([], %{muting_user: user, skip_preload: true})
1002 assert Enum.member?(activities, activity_two)
1003 assert Enum.member?(activities, activity_three)
1004 assert Enum.member?(activities, activity_one)
1006 activity_three_actor = User.get_by_ap_id(activity_three.data["actor"])
1007 {:ok, _user_relationships} = User.mute(user, activity_three_actor)
1008 {:ok, %{data: %{"object" => id}}} = CommonAPI.repeat(activity_three.id, booster)
1009 %Activity{} = boost_activity = Activity.get_create_by_object_ap_id(id)
1010 activity_three = Activity.get_by_id(activity_three.id)
1012 activities = ActivityPub.fetch_activities([], %{muting_user: user, skip_preload: true})
1014 assert Enum.member?(activities, activity_two)
1015 refute Enum.member?(activities, activity_three)
1016 refute Enum.member?(activities, boost_activity)
1017 assert Enum.member?(activities, activity_one)
1019 activities = ActivityPub.fetch_activities([], %{muting_user: nil, skip_preload: true})
1021 assert Enum.member?(activities, activity_two)
1022 assert Enum.member?(activities, activity_three)
1023 assert Enum.member?(activities, boost_activity)
1024 assert Enum.member?(activities, activity_one)
1027 test "doesn't return thread muted activities" do
1028 user = insert(:user)
1029 _activity_one = insert(:note_activity)
1030 note_two = insert(:note, data: %{"context" => "suya.."})
1031 activity_two = insert(:note_activity, note: note_two)
1033 {:ok, _activity_two} = CommonAPI.add_mute(user, activity_two)
1035 assert [_activity_one] = ActivityPub.fetch_activities([], %{muting_user: user})
1038 test "returns thread muted activities when with_muted is set" do
1039 user = insert(:user)
1040 _activity_one = insert(:note_activity)
1041 note_two = insert(:note, data: %{"context" => "suya.."})
1042 activity_two = insert(:note_activity, note: note_two)
1044 {:ok, _activity_two} = CommonAPI.add_mute(user, activity_two)
1046 assert [_activity_two, _activity_one] =
1047 ActivityPub.fetch_activities([], %{muting_user: user, with_muted: true})
1050 test "does include announces on request" do
1051 activity_three = insert(:note_activity)
1052 user = insert(:user)
1053 booster = insert(:user)
1055 {:ok, user, booster} = User.follow(user, booster)
1057 {:ok, announce} = CommonAPI.repeat(activity_three.id, booster)
1059 [announce_activity] = ActivityPub.fetch_activities([user.ap_id | User.following(user)])
1061 assert announce_activity.id == announce.id
1064 test "excludes reblogs on request" do
1065 user = insert(:user)
1066 {:ok, expected_activity} = ActivityBuilder.insert(%{"type" => "Create"}, %{:user => user})
1067 {:ok, _} = ActivityBuilder.insert(%{"type" => "Announce"}, %{:user => user})
1069 [activity] = ActivityPub.fetch_user_activities(user, nil, %{exclude_reblogs: true})
1071 assert activity == expected_activity
1074 describe "irreversible filters" do
1076 user = insert(:user)
1077 user_two = insert(:user)
1079 insert(:filter, user: user_two, phrase: "cofe", hide: true)
1080 insert(:filter, user: user_two, phrase: "ok boomer", hide: true)
1081 insert(:filter, user: user_two, phrase: "test", hide: false)
1084 type: ["Create", "Announce"],
1088 {:ok, %{user: user, user_two: user_two, params: params}}
1091 test "it returns statuses if they don't contain exact filter words", %{
1095 {:ok, _} = CommonAPI.post(user, %{status: "hey"})
1096 {:ok, _} = CommonAPI.post(user, %{status: "got cofefe?"})
1097 {:ok, _} = CommonAPI.post(user, %{status: "I am not a boomer"})
1098 {:ok, _} = CommonAPI.post(user, %{status: "ok boomers"})
1099 {:ok, _} = CommonAPI.post(user, %{status: "ccofee is not a word"})
1100 {:ok, _} = CommonAPI.post(user, %{status: "this is a test"})
1102 activities = ActivityPub.fetch_activities([], params)
1104 assert Enum.count(activities) == 6
1107 test "it does not filter user's own statuses", %{user_two: user_two, params: params} do
1108 {:ok, _} = CommonAPI.post(user_two, %{status: "Give me some cofe!"})
1109 {:ok, _} = CommonAPI.post(user_two, %{status: "ok boomer"})
1111 activities = ActivityPub.fetch_activities([], params)
1113 assert Enum.count(activities) == 2
1116 test "it excludes statuses with filter words", %{user: user, params: params} do
1117 {:ok, _} = CommonAPI.post(user, %{status: "Give me some cofe!"})
1118 {:ok, _} = CommonAPI.post(user, %{status: "ok boomer"})
1119 {:ok, _} = CommonAPI.post(user, %{status: "is it a cOfE?"})
1120 {:ok, _} = CommonAPI.post(user, %{status: "cofe is all I need"})
1121 {:ok, _} = CommonAPI.post(user, %{status: "— ok BOOMER\n"})
1123 activities = ActivityPub.fetch_activities([], params)
1125 assert Enum.empty?(activities)
1128 test "it returns all statuses if user does not have any filters" do
1129 another_user = insert(:user)
1130 {:ok, _} = CommonAPI.post(another_user, %{status: "got cofe?"})
1131 {:ok, _} = CommonAPI.post(another_user, %{status: "test!"})
1134 ActivityPub.fetch_activities([], %{
1135 type: ["Create", "Announce"],
1139 assert Enum.count(activities) == 2
1143 describe "public fetch activities" do
1144 test "doesn't retrieve unlisted activities" do
1145 user = insert(:user)
1147 {:ok, _unlisted_activity} = CommonAPI.post(user, %{status: "yeah", visibility: "unlisted"})
1149 {:ok, listed_activity} = CommonAPI.post(user, %{status: "yeah"})
1151 [activity] = ActivityPub.fetch_public_activities()
1153 assert activity == listed_activity
1156 test "retrieves public activities" do
1157 _activities = ActivityPub.fetch_public_activities()
1159 %{public: public} = ActivityBuilder.public_and_non_public()
1161 activities = ActivityPub.fetch_public_activities()
1162 assert length(activities) == 1
1163 assert Enum.at(activities, 0) == public
1166 test "retrieves a maximum of 20 activities" do
1167 ActivityBuilder.insert_list(10)
1168 expected_activities = ActivityBuilder.insert_list(20)
1170 activities = ActivityPub.fetch_public_activities()
1172 assert collect_ids(activities) == collect_ids(expected_activities)
1173 assert length(activities) == 20
1176 test "retrieves ids starting from a since_id" do
1177 activities = ActivityBuilder.insert_list(30)
1178 expected_activities = ActivityBuilder.insert_list(10)
1179 since_id = List.last(activities).id
1181 activities = ActivityPub.fetch_public_activities(%{since_id: since_id})
1183 assert collect_ids(activities) == collect_ids(expected_activities)
1184 assert length(activities) == 10
1187 test "retrieves ids up to max_id" do
1188 ActivityBuilder.insert_list(10)
1189 expected_activities = ActivityBuilder.insert_list(20)
1193 |> ActivityBuilder.insert_list()
1196 activities = ActivityPub.fetch_public_activities(%{max_id: max_id})
1198 assert length(activities) == 20
1199 assert collect_ids(activities) == collect_ids(expected_activities)
1202 test "paginates via offset/limit" do
1203 _first_part_activities = ActivityBuilder.insert_list(10)
1204 second_part_activities = ActivityBuilder.insert_list(10)
1206 later_activities = ActivityBuilder.insert_list(10)
1208 activities = ActivityPub.fetch_public_activities(%{page: "2", page_size: "20"}, :offset)
1210 assert length(activities) == 20
1212 assert collect_ids(activities) ==
1213 collect_ids(second_part_activities) ++ collect_ids(later_activities)
1216 test "doesn't return reblogs for users for whom reblogs have been muted" do
1217 activity = insert(:note_activity)
1218 user = insert(:user)
1219 booster = insert(:user)
1220 {:ok, _reblog_mute} = CommonAPI.hide_reblogs(user, booster)
1222 {:ok, activity} = CommonAPI.repeat(activity.id, booster)
1224 activities = ActivityPub.fetch_activities([], %{muting_user: user})
1226 refute Enum.any?(activities, fn %{id: id} -> id == activity.id end)
1229 test "returns reblogs for users for whom reblogs have not been muted" do
1230 activity = insert(:note_activity)
1231 user = insert(:user)
1232 booster = insert(:user)
1233 {:ok, _reblog_mute} = CommonAPI.hide_reblogs(user, booster)
1234 {:ok, _reblog_mute} = CommonAPI.show_reblogs(user, booster)
1236 {:ok, activity} = CommonAPI.repeat(activity.id, booster)
1238 activities = ActivityPub.fetch_activities([], %{muting_user: user})
1240 assert Enum.any?(activities, fn %{id: id} -> id == activity.id end)
1244 describe "uploading files" do
1246 test_file = %Plug.Upload{
1247 content_type: "image/jpeg",
1248 path: Path.absname("test/fixtures/image.jpg"),
1249 filename: "an_image.jpg"
1252 %{test_file: test_file}
1255 test "sets a description if given", %{test_file: file} do
1256 {:ok, %Object{} = object} = ActivityPub.upload(file, description: "a cool file")
1257 assert object.data["name"] == "a cool file"
1260 test "it sets the default description depending on the configuration", %{test_file: file} do
1261 clear_config([Pleroma.Upload, :default_description])
1263 clear_config([Pleroma.Upload, :default_description], nil)
1264 {:ok, %Object{} = object} = ActivityPub.upload(file)
1265 assert object.data["name"] == ""
1267 clear_config([Pleroma.Upload, :default_description], :filename)
1268 {:ok, %Object{} = object} = ActivityPub.upload(file)
1269 assert object.data["name"] == "an_image.jpg"
1271 clear_config([Pleroma.Upload, :default_description], "unnamed attachment")
1272 {:ok, %Object{} = object} = ActivityPub.upload(file)
1273 assert object.data["name"] == "unnamed attachment"
1276 test "copies the file to the configured folder", %{test_file: file} do
1277 clear_config([Pleroma.Upload, :default_description], :filename)
1278 {:ok, %Object{} = object} = ActivityPub.upload(file)
1279 assert object.data["name"] == "an_image.jpg"
1282 test "works with base64 encoded images" do
1287 {:ok, %Object{}} = ActivityPub.upload(file)
1291 describe "fetch the latest Follow" do
1292 test "fetches the latest Follow activity" do
1293 %Activity{data: %{"type" => "Follow"}} = activity = insert(:follow_activity)
1294 follower = Repo.get_by(User, ap_id: activity.data["actor"])
1295 followed = Repo.get_by(User, ap_id: activity.data["object"])
1297 assert activity == Utils.fetch_latest_follow(follower, followed)
1301 describe "unfollowing" do
1302 test "it reverts unfollow activity" do
1303 follower = insert(:user)
1304 followed = insert(:user)
1306 {:ok, _, _, follow_activity} = CommonAPI.follow(follower, followed)
1308 with_mock(Utils, [:passthrough], maybe_federate: fn _ -> {:error, :reverted} end) do
1309 assert {:error, :reverted} = ActivityPub.unfollow(follower, followed)
1312 activity = Activity.get_by_id(follow_activity.id)
1313 assert activity.data["type"] == "Follow"
1314 assert activity.data["actor"] == follower.ap_id
1316 assert activity.data["object"] == followed.ap_id
1319 test "creates an undo activity for the last follow" do
1320 follower = insert(:user)
1321 followed = insert(:user)
1323 {:ok, _, _, follow_activity} = CommonAPI.follow(follower, followed)
1324 {:ok, activity} = ActivityPub.unfollow(follower, followed)
1326 assert activity.data["type"] == "Undo"
1327 assert activity.data["actor"] == follower.ap_id
1329 embedded_object = activity.data["object"]
1330 assert is_map(embedded_object)
1331 assert embedded_object["type"] == "Follow"
1332 assert embedded_object["object"] == followed.ap_id
1333 assert embedded_object["id"] == follow_activity.data["id"]
1336 test "creates an undo activity for a pending follow request" do
1337 follower = insert(:user)
1338 followed = insert(:user, %{is_locked: true})
1340 {:ok, _, _, follow_activity} = CommonAPI.follow(follower, followed)
1341 {:ok, activity} = ActivityPub.unfollow(follower, followed)
1343 assert activity.data["type"] == "Undo"
1344 assert activity.data["actor"] == follower.ap_id
1346 embedded_object = activity.data["object"]
1347 assert is_map(embedded_object)
1348 assert embedded_object["type"] == "Follow"
1349 assert embedded_object["object"] == followed.ap_id
1350 assert embedded_object["id"] == follow_activity.data["id"]
1354 describe "timeline post-processing" do
1355 test "it filters broken threads" do
1356 user1 = insert(:user)
1357 user2 = insert(:user)
1358 user3 = insert(:user)
1360 {:ok, user1, user3} = User.follow(user1, user3)
1361 assert User.following?(user1, user3)
1363 {:ok, user2, user3} = User.follow(user2, user3)
1364 assert User.following?(user2, user3)
1366 {:ok, user3, user2} = User.follow(user3, user2)
1367 assert User.following?(user3, user2)
1369 {:ok, public_activity} = CommonAPI.post(user3, %{status: "hi 1"})
1371 {:ok, private_activity_1} = CommonAPI.post(user3, %{status: "hi 2", visibility: "private"})
1373 {:ok, private_activity_2} =
1374 CommonAPI.post(user2, %{
1376 visibility: "private",
1377 in_reply_to_status_id: private_activity_1.id
1380 {:ok, private_activity_3} =
1381 CommonAPI.post(user3, %{
1383 visibility: "private",
1384 in_reply_to_status_id: private_activity_2.id
1388 ActivityPub.fetch_activities([user1.ap_id | User.following(user1)])
1389 |> Enum.map(fn a -> a.id end)
1391 private_activity_1 = Activity.get_by_ap_id_with_object(private_activity_1.data["id"])
1393 assert [public_activity.id, private_activity_1.id, private_activity_3.id] == activities
1395 assert length(activities) == 3
1398 ActivityPub.fetch_activities([user1.ap_id | User.following(user1)], %{user: user1})
1399 |> Enum.map(fn a -> a.id end)
1401 assert [public_activity.id, private_activity_1.id] == activities
1402 assert length(activities) == 2
1406 describe "flag/1" do
1408 reporter = insert(:user)
1409 target_account = insert(:user)
1411 {:ok, activity} = CommonAPI.post(target_account, %{status: content})
1412 context = Utils.generate_context_id()
1414 reporter_ap_id = reporter.ap_id
1415 target_ap_id = target_account.ap_id
1416 activity_ap_id = activity.data["id"]
1418 activity_with_object = Activity.get_by_ap_id_with_object(activity_ap_id)
1424 target_account: target_account,
1425 reported_activity: activity,
1427 activity_ap_id: activity_ap_id,
1428 activity_with_object: activity_with_object,
1429 reporter_ap_id: reporter_ap_id,
1430 target_ap_id: target_ap_id
1434 test "it can create a Flag activity",
1438 target_account: target_account,
1439 reported_activity: reported_activity,
1441 activity_ap_id: activity_ap_id,
1442 activity_with_object: activity_with_object,
1443 reporter_ap_id: reporter_ap_id,
1444 target_ap_id: target_ap_id
1446 assert {:ok, activity} =
1450 account: target_account,
1451 statuses: [reported_activity],
1457 "id" => activity_ap_id,
1458 "content" => content,
1459 "published" => activity_with_object.object.data["published"],
1461 AccountView.render("show.json", %{user: target_account, skip_visibility_check: true})
1465 actor: ^reporter_ap_id,
1468 "content" => ^content,
1469 "context" => ^context,
1470 "object" => [^target_ap_id, ^note_obj]
1475 test_with_mock "strips status data from Flag, before federating it",
1479 target_account: target_account,
1480 reported_activity: reported_activity,
1490 account: target_account,
1491 statuses: [reported_activity],
1496 put_in(activity.data, ["object"], [target_account.ap_id, reported_activity.data["id"]])
1498 assert_called(Utils.maybe_federate(%{activity | data: new_data}))
1501 test_with_mock "reverts on error",
1505 target_account: target_account,
1506 reported_activity: reported_activity,
1511 maybe_federate: fn _ -> {:error, :reverted} end do
1512 assert {:error, :reverted} =
1516 account: target_account,
1517 statuses: [reported_activity],
1521 assert Repo.aggregate(Activity, :count, :id) == 1
1522 assert Repo.aggregate(Object, :count, :id) == 2
1523 assert Repo.aggregate(Notification, :count, :id) == 0
1527 test "fetch_activities/2 returns activities addressed to a list " do
1528 user = insert(:user)
1529 member = insert(:user)
1530 {:ok, list} = Pleroma.List.create("foo", user)
1531 {:ok, list} = Pleroma.List.follow(list, member)
1533 {:ok, activity} = CommonAPI.post(user, %{status: "foobar", visibility: "list:#{list.id}"})
1535 activity = Repo.preload(activity, :bookmark)
1536 activity = %Activity{activity | thread_muted?: !!activity.thread_muted?}
1538 assert ActivityPub.fetch_activities([], %{user: user}) == [activity]
1542 File.read!("test/fixtures/avatar_data_uri")
1545 describe "fetch_activities_bounded" do
1546 test "fetches private posts for followed users" do
1547 user = insert(:user)
1550 CommonAPI.post(user, %{
1551 status: "thought I looked cute might delete later :3",
1552 visibility: "private"
1555 [result] = ActivityPub.fetch_activities_bounded([user.follower_address], [])
1556 assert result.id == activity.id
1559 test "fetches only public posts for other users" do
1560 user = insert(:user)
1561 {:ok, activity} = CommonAPI.post(user, %{status: "#cofe", visibility: "public"})
1563 {:ok, _private_activity} =
1564 CommonAPI.post(user, %{
1565 status: "why is tenshi eating a corndog so cute?",
1566 visibility: "private"
1569 [result] = ActivityPub.fetch_activities_bounded([], [user.follower_address])
1570 assert result.id == activity.id
1574 describe "fetch_follow_information_for_user" do
1575 test "syncronizes following/followers counters" do
1579 follower_address: "http://localhost:4001/users/fuser2/followers",
1580 following_address: "http://localhost:4001/users/fuser2/following"
1583 {:ok, info} = ActivityPub.fetch_follow_information_for_user(user)
1584 assert info.follower_count == 527
1585 assert info.following_count == 267
1588 test "detects hidden followers" do
1591 "http://localhost:4001/users/masto_closed/followers?page=1" ->
1592 %Tesla.Env{status: 403, body: ""}
1595 apply(HttpRequestMock, :request, [env])
1602 follower_address: "http://localhost:4001/users/masto_closed/followers",
1603 following_address: "http://localhost:4001/users/masto_closed/following"
1606 {:ok, follow_info} = ActivityPub.fetch_follow_information_for_user(user)
1607 assert follow_info.hide_followers == true
1608 assert follow_info.hide_follows == false
1611 test "detects hidden follows" do
1614 "http://localhost:4001/users/masto_closed/following?page=1" ->
1615 %Tesla.Env{status: 403, body: ""}
1618 apply(HttpRequestMock, :request, [env])
1625 follower_address: "http://localhost:4001/users/masto_closed/followers",
1626 following_address: "http://localhost:4001/users/masto_closed/following"
1629 {:ok, follow_info} = ActivityPub.fetch_follow_information_for_user(user)
1630 assert follow_info.hide_followers == false
1631 assert follow_info.hide_follows == true
1634 test "detects hidden follows/followers for friendica" do
1638 follower_address: "http://localhost:8080/followers/fuser3",
1639 following_address: "http://localhost:8080/following/fuser3"
1642 {:ok, follow_info} = ActivityPub.fetch_follow_information_for_user(user)
1643 assert follow_info.hide_followers == true
1644 assert follow_info.follower_count == 296
1645 assert follow_info.following_count == 32
1646 assert follow_info.hide_follows == true
1649 test "doesn't crash when follower and following counters are hidden" do
1652 "http://localhost:4001/users/masto_hidden_counters/following" ->
1655 "@context" => "https://www.w3.org/ns/activitystreams",
1656 "id" => "http://localhost:4001/users/masto_hidden_counters/followers"
1658 headers: HttpRequestMock.activitypub_object_headers()
1661 "http://localhost:4001/users/masto_hidden_counters/following?page=1" ->
1662 %Tesla.Env{status: 403, body: ""}
1664 "http://localhost:4001/users/masto_hidden_counters/followers" ->
1667 "@context" => "https://www.w3.org/ns/activitystreams",
1668 "id" => "http://localhost:4001/users/masto_hidden_counters/following"
1670 headers: HttpRequestMock.activitypub_object_headers()
1673 "http://localhost:4001/users/masto_hidden_counters/followers?page=1" ->
1674 %Tesla.Env{status: 403, body: ""}
1681 follower_address: "http://localhost:4001/users/masto_hidden_counters/followers",
1682 following_address: "http://localhost:4001/users/masto_hidden_counters/following"
1685 {:ok, follow_info} = ActivityPub.fetch_follow_information_for_user(user)
1687 assert follow_info.hide_followers == true
1688 assert follow_info.follower_count == 0
1689 assert follow_info.hide_follows == true
1690 assert follow_info.following_count == 0
1694 describe "fetch_favourites/3" do
1695 test "returns a favourite activities sorted by adds to favorite" do
1696 user = insert(:user)
1697 other_user = insert(:user)
1698 user1 = insert(:user)
1699 user2 = insert(:user)
1700 {:ok, a1} = CommonAPI.post(user1, %{status: "bla"})
1701 {:ok, _a2} = CommonAPI.post(user2, %{status: "traps are happy"})
1702 {:ok, a3} = CommonAPI.post(user2, %{status: "Trees Are "})
1703 {:ok, a4} = CommonAPI.post(user2, %{status: "Agent Smith "})
1704 {:ok, a5} = CommonAPI.post(user1, %{status: "Red or Blue "})
1706 {:ok, _} = CommonAPI.favorite(user, a4.id)
1707 {:ok, _} = CommonAPI.favorite(other_user, a3.id)
1708 {:ok, _} = CommonAPI.favorite(user, a3.id)
1709 {:ok, _} = CommonAPI.favorite(other_user, a5.id)
1710 {:ok, _} = CommonAPI.favorite(user, a5.id)
1711 {:ok, _} = CommonAPI.favorite(other_user, a4.id)
1712 {:ok, _} = CommonAPI.favorite(user, a1.id)
1713 {:ok, _} = CommonAPI.favorite(other_user, a1.id)
1714 result = ActivityPub.fetch_favourites(user)
1716 assert Enum.map(result, & &1.id) == [a1.id, a5.id, a3.id, a4.id]
1718 result = ActivityPub.fetch_favourites(user, %{limit: 2})
1719 assert Enum.map(result, & &1.id) == [a1.id, a5.id]
1723 describe "Move activity" do
1725 %{ap_id: old_ap_id} = old_user = insert(:user)
1726 %{ap_id: new_ap_id} = new_user = insert(:user, also_known_as: [old_ap_id])
1727 follower = insert(:user)
1728 follower_move_opted_out = insert(:user, allow_following_move: false)
1730 User.follow(follower, old_user)
1731 User.follow(follower_move_opted_out, old_user)
1733 assert User.following?(follower, old_user)
1734 assert User.following?(follower_move_opted_out, old_user)
1736 assert {:ok, activity} = ActivityPub.move(old_user, new_user)
1741 "actor" => ^old_ap_id,
1742 "object" => ^old_ap_id,
1743 "target" => ^new_ap_id,
1747 recipients: recipients
1750 assert old_user.follower_address in recipients
1753 "op" => "move_following",
1754 "origin_id" => old_user.id,
1755 "target_id" => new_user.id
1758 assert_enqueued(worker: Pleroma.Workers.BackgroundWorker, args: params)
1760 Pleroma.Workers.BackgroundWorker.perform(%Oban.Job{args: params})
1762 refute User.following?(follower, old_user)
1763 assert User.following?(follower, new_user)
1765 assert User.following?(follower_move_opted_out, old_user)
1766 refute User.following?(follower_move_opted_out, new_user)
1768 activity = %Activity{activity | object: nil}
1770 assert [%Notification{activity: ^activity}] = Notification.for_user(follower)
1772 assert [%Notification{activity: ^activity}] = Notification.for_user(follower_move_opted_out)
1775 test "old user must be in the new user's `also_known_as` list" do
1776 old_user = insert(:user)
1777 new_user = insert(:user)
1779 assert {:error, "Target account must have the origin in `alsoKnownAs`"} =
1780 ActivityPub.move(old_user, new_user)
1783 test "do not move remote user following relationships" do
1784 %{ap_id: old_ap_id} = old_user = insert(:user)
1785 %{ap_id: new_ap_id} = new_user = insert(:user, also_known_as: [old_ap_id])
1786 follower_remote = insert(:user, local: false)
1788 User.follow(follower_remote, old_user)
1790 assert User.following?(follower_remote, old_user)
1792 assert {:ok, activity} = ActivityPub.move(old_user, new_user)
1797 "actor" => ^old_ap_id,
1798 "object" => ^old_ap_id,
1799 "target" => ^new_ap_id,
1806 "op" => "move_following",
1807 "origin_id" => old_user.id,
1808 "target_id" => new_user.id
1811 assert_enqueued(worker: Pleroma.Workers.BackgroundWorker, args: params)
1813 Pleroma.Workers.BackgroundWorker.perform(%Oban.Job{args: params})
1815 assert User.following?(follower_remote, old_user)
1816 refute User.following?(follower_remote, new_user)
1820 test "doesn't retrieve replies activities with exclude_replies" do
1821 user = insert(:user)
1823 {:ok, activity} = CommonAPI.post(user, %{status: "yeah"})
1825 {:ok, _reply} = CommonAPI.post(user, %{status: "yeah", in_reply_to_status_id: activity.id})
1827 [result] = ActivityPub.fetch_public_activities(%{exclude_replies: true})
1829 assert result.id == activity.id
1831 assert length(ActivityPub.fetch_public_activities()) == 2
1834 describe "replies filtering with public messages" do
1835 setup :public_messages
1837 test "public timeline", %{users: %{u1: user}} do
1840 |> Map.put(:type, ["Create", "Announce"])
1841 |> Map.put(:local_only, false)
1842 |> Map.put(:blocking_user, user)
1843 |> Map.put(:muting_user, user)
1844 |> Map.put(:reply_filtering_user, user)
1845 |> ActivityPub.fetch_public_activities()
1846 |> Enum.map(& &1.id)
1848 assert length(activities_ids) == 16
1851 test "public timeline with reply_visibility `following`", %{
1857 activities: activities
1861 |> Map.put(:type, ["Create", "Announce"])
1862 |> Map.put(:local_only, false)
1863 |> Map.put(:blocking_user, user)
1864 |> Map.put(:muting_user, user)
1865 |> Map.put(:reply_visibility, "following")
1866 |> Map.put(:reply_filtering_user, user)
1867 |> ActivityPub.fetch_public_activities()
1868 |> Enum.map(& &1.id)
1870 assert length(activities_ids) == 14
1873 Map.values(u1) ++ Map.values(u2) ++ Map.values(u4) ++ Map.values(activities) ++ [u3[:r1]]
1875 assert Enum.all?(visible_ids, &(&1 in activities_ids))
1878 test "public timeline with reply_visibility `self`", %{
1884 activities: activities
1888 |> Map.put(:type, ["Create", "Announce"])
1889 |> Map.put(:local_only, false)
1890 |> Map.put(:blocking_user, user)
1891 |> Map.put(:muting_user, user)
1892 |> Map.put(:reply_visibility, "self")
1893 |> Map.put(:reply_filtering_user, user)
1894 |> ActivityPub.fetch_public_activities()
1895 |> Enum.map(& &1.id)
1897 assert length(activities_ids) == 10
1898 visible_ids = Map.values(u1) ++ [u2[:r1], u3[:r1], u4[:r1]] ++ Map.values(activities)
1899 assert Enum.all?(visible_ids, &(&1 in activities_ids))
1902 test "home timeline", %{
1904 activities: activities,
1912 |> Map.put(:type, ["Create", "Announce"])
1913 |> Map.put(:blocking_user, user)
1914 |> Map.put(:muting_user, user)
1915 |> Map.put(:user, user)
1916 |> Map.put(:reply_filtering_user, user)
1919 ActivityPub.fetch_activities([user.ap_id | User.following(user)], params)
1920 |> Enum.map(& &1.id)
1922 assert length(activities_ids) == 13
1937 assert Enum.all?(visible_ids, &(&1 in activities_ids))
1940 test "home timeline with reply_visibility `following`", %{
1942 activities: activities,
1950 |> Map.put(:type, ["Create", "Announce"])
1951 |> Map.put(:blocking_user, user)
1952 |> Map.put(:muting_user, user)
1953 |> Map.put(:user, user)
1954 |> Map.put(:reply_visibility, "following")
1955 |> Map.put(:reply_filtering_user, user)
1958 ActivityPub.fetch_activities([user.ap_id | User.following(user)], params)
1959 |> Enum.map(& &1.id)
1961 assert length(activities_ids) == 11
1976 assert Enum.all?(visible_ids, &(&1 in activities_ids))
1979 test "home timeline with reply_visibility `self`", %{
1981 activities: activities,
1989 |> Map.put(:type, ["Create", "Announce"])
1990 |> Map.put(:blocking_user, user)
1991 |> Map.put(:muting_user, user)
1992 |> Map.put(:user, user)
1993 |> Map.put(:reply_visibility, "self")
1994 |> Map.put(:reply_filtering_user, user)
1997 ActivityPub.fetch_activities([user.ap_id | User.following(user)], params)
1998 |> Enum.map(& &1.id)
2000 assert length(activities_ids) == 9
2013 assert Enum.all?(visible_ids, &(&1 in activities_ids))
2016 test "filtering out announces where the user is the actor of the announced message" do
2017 user = insert(:user)
2018 other_user = insert(:user)
2019 third_user = insert(:user)
2020 User.follow(user, other_user)
2022 {:ok, post} = CommonAPI.post(user, %{status: "yo"})
2023 {:ok, other_post} = CommonAPI.post(third_user, %{status: "yo"})
2024 {:ok, _announce} = CommonAPI.repeat(post.id, other_user)
2025 {:ok, _announce} = CommonAPI.repeat(post.id, third_user)
2026 {:ok, announce} = CommonAPI.repeat(other_post.id, other_user)
2033 [user.ap_id | User.following(user)]
2034 |> ActivityPub.fetch_activities(params)
2036 assert length(results) == 3
2040 announce_filtering_user: user
2044 [user.ap_id | User.following(user)]
2045 |> ActivityPub.fetch_activities(params)
2047 assert result.id == announce.id
2051 describe "replies filtering with private messages" do
2052 setup :private_messages
2054 test "public timeline", %{users: %{u1: user}} do
2057 |> Map.put(:type, ["Create", "Announce"])
2058 |> Map.put(:local_only, false)
2059 |> Map.put(:blocking_user, user)
2060 |> Map.put(:muting_user, user)
2061 |> Map.put(:user, user)
2062 |> ActivityPub.fetch_public_activities()
2063 |> Enum.map(& &1.id)
2065 assert activities_ids == []
2068 test "public timeline with default reply_visibility `following`", %{users: %{u1: user}} do
2071 |> Map.put(:type, ["Create", "Announce"])
2072 |> Map.put(:local_only, false)
2073 |> Map.put(:blocking_user, user)
2074 |> Map.put(:muting_user, user)
2075 |> Map.put(:reply_visibility, "following")
2076 |> Map.put(:reply_filtering_user, user)
2077 |> Map.put(:user, user)
2078 |> ActivityPub.fetch_public_activities()
2079 |> Enum.map(& &1.id)
2081 assert activities_ids == []
2084 test "public timeline with default reply_visibility `self`", %{users: %{u1: user}} do
2087 |> Map.put(:type, ["Create", "Announce"])
2088 |> Map.put(:local_only, false)
2089 |> Map.put(:blocking_user, user)
2090 |> Map.put(:muting_user, user)
2091 |> Map.put(:reply_visibility, "self")
2092 |> Map.put(:reply_filtering_user, user)
2093 |> Map.put(:user, user)
2094 |> ActivityPub.fetch_public_activities()
2095 |> Enum.map(& &1.id)
2097 assert activities_ids == []
2101 |> Map.put(:reply_visibility, "self")
2102 |> Map.put(:reply_filtering_user, nil)
2103 |> ActivityPub.fetch_public_activities()
2105 assert activities_ids == []
2108 test "home timeline", %{users: %{u1: user}} do
2111 |> Map.put(:type, ["Create", "Announce"])
2112 |> Map.put(:blocking_user, user)
2113 |> Map.put(:muting_user, user)
2114 |> Map.put(:user, user)
2117 ActivityPub.fetch_activities([user.ap_id | User.following(user)], params)
2118 |> Enum.map(& &1.id)
2120 assert length(activities_ids) == 12
2123 test "home timeline with default reply_visibility `following`", %{users: %{u1: user}} do
2126 |> Map.put(:type, ["Create", "Announce"])
2127 |> Map.put(:blocking_user, user)
2128 |> Map.put(:muting_user, user)
2129 |> Map.put(:user, user)
2130 |> Map.put(:reply_visibility, "following")
2131 |> Map.put(:reply_filtering_user, user)
2134 ActivityPub.fetch_activities([user.ap_id | User.following(user)], params)
2135 |> Enum.map(& &1.id)
2137 assert length(activities_ids) == 12
2140 test "home timeline with default reply_visibility `self`", %{
2142 activities: activities,
2150 |> Map.put(:type, ["Create", "Announce"])
2151 |> Map.put(:blocking_user, user)
2152 |> Map.put(:muting_user, user)
2153 |> Map.put(:user, user)
2154 |> Map.put(:reply_visibility, "self")
2155 |> Map.put(:reply_filtering_user, user)
2158 ActivityPub.fetch_activities([user.ap_id | User.following(user)], params)
2159 |> Enum.map(& &1.id)
2161 assert length(activities_ids) == 10
2164 Map.values(u1) ++ Map.values(u4) ++ [u2[:r1], u3[:r1]] ++ Map.values(activities)
2166 assert Enum.all?(visible_ids, &(&1 in activities_ids))
2170 defp public_messages(_) do
2171 [u1, u2, u3, u4] = insert_list(4, :user)
2172 {:ok, u1, u2} = User.follow(u1, u2)
2173 {:ok, u2, u1} = User.follow(u2, u1)
2174 {:ok, u1, u4} = User.follow(u1, u4)
2175 {:ok, u4, u1} = User.follow(u4, u1)
2177 {:ok, u2, u3} = User.follow(u2, u3)
2178 {:ok, u3, u2} = User.follow(u3, u2)
2180 {:ok, a1} = CommonAPI.post(u1, %{status: "Status"})
2183 CommonAPI.post(u2, %{
2184 status: "@#{u1.nickname} reply from u2 to u1",
2185 in_reply_to_status_id: a1.id
2189 CommonAPI.post(u3, %{
2190 status: "@#{u1.nickname} reply from u3 to u1",
2191 in_reply_to_status_id: a1.id
2195 CommonAPI.post(u4, %{
2196 status: "@#{u1.nickname} reply from u4 to u1",
2197 in_reply_to_status_id: a1.id
2200 {:ok, a2} = CommonAPI.post(u2, %{status: "Status"})
2203 CommonAPI.post(u1, %{
2204 status: "@#{u2.nickname} reply from u1 to u2",
2205 in_reply_to_status_id: a2.id
2209 CommonAPI.post(u3, %{
2210 status: "@#{u2.nickname} reply from u3 to u2",
2211 in_reply_to_status_id: a2.id
2215 CommonAPI.post(u4, %{
2216 status: "@#{u2.nickname} reply from u4 to u2",
2217 in_reply_to_status_id: a2.id
2220 {:ok, a3} = CommonAPI.post(u3, %{status: "Status"})
2223 CommonAPI.post(u1, %{
2224 status: "@#{u3.nickname} reply from u1 to u3",
2225 in_reply_to_status_id: a3.id
2229 CommonAPI.post(u2, %{
2230 status: "@#{u3.nickname} reply from u2 to u3",
2231 in_reply_to_status_id: a3.id
2235 CommonAPI.post(u4, %{
2236 status: "@#{u3.nickname} reply from u4 to u3",
2237 in_reply_to_status_id: a3.id
2240 {:ok, a4} = CommonAPI.post(u4, %{status: "Status"})
2243 CommonAPI.post(u1, %{
2244 status: "@#{u4.nickname} reply from u1 to u4",
2245 in_reply_to_status_id: a4.id
2249 CommonAPI.post(u2, %{
2250 status: "@#{u4.nickname} reply from u2 to u4",
2251 in_reply_to_status_id: a4.id
2255 CommonAPI.post(u3, %{
2256 status: "@#{u4.nickname} reply from u3 to u4",
2257 in_reply_to_status_id: a4.id
2261 users: %{u1: u1, u2: u2, u3: u3, u4: u4},
2262 activities: %{a1: a1.id, a2: a2.id, a3: a3.id, a4: a4.id},
2263 u1: %{r1: r1_1.id, r2: r1_2.id, r3: r1_3.id},
2264 u2: %{r1: r2_1.id, r2: r2_2.id, r3: r2_3.id},
2265 u3: %{r1: r3_1.id, r2: r3_2.id, r3: r3_3.id},
2266 u4: %{r1: r4_1.id, r2: r4_2.id, r3: r4_3.id}}
2269 defp private_messages(_) do
2270 [u1, u2, u3, u4] = insert_list(4, :user)
2271 {:ok, u1, u2} = User.follow(u1, u2)
2272 {:ok, u2, u1} = User.follow(u2, u1)
2273 {:ok, u1, u3} = User.follow(u1, u3)
2274 {:ok, u3, u1} = User.follow(u3, u1)
2275 {:ok, u1, u4} = User.follow(u1, u4)
2276 {:ok, u4, u1} = User.follow(u4, u1)
2278 {:ok, u2, u3} = User.follow(u2, u3)
2279 {:ok, u3, u2} = User.follow(u3, u2)
2281 {:ok, a1} = CommonAPI.post(u1, %{status: "Status", visibility: "private"})
2284 CommonAPI.post(u2, %{
2285 status: "@#{u1.nickname} reply from u2 to u1",
2286 in_reply_to_status_id: a1.id,
2287 visibility: "private"
2291 CommonAPI.post(u3, %{
2292 status: "@#{u1.nickname} reply from u3 to u1",
2293 in_reply_to_status_id: a1.id,
2294 visibility: "private"
2298 CommonAPI.post(u4, %{
2299 status: "@#{u1.nickname} reply from u4 to u1",
2300 in_reply_to_status_id: a1.id,
2301 visibility: "private"
2304 {:ok, a2} = CommonAPI.post(u2, %{status: "Status", visibility: "private"})
2307 CommonAPI.post(u1, %{
2308 status: "@#{u2.nickname} reply from u1 to u2",
2309 in_reply_to_status_id: a2.id,
2310 visibility: "private"
2314 CommonAPI.post(u3, %{
2315 status: "@#{u2.nickname} reply from u3 to u2",
2316 in_reply_to_status_id: a2.id,
2317 visibility: "private"
2320 {:ok, a3} = CommonAPI.post(u3, %{status: "Status", visibility: "private"})
2323 CommonAPI.post(u1, %{
2324 status: "@#{u3.nickname} reply from u1 to u3",
2325 in_reply_to_status_id: a3.id,
2326 visibility: "private"
2330 CommonAPI.post(u2, %{
2331 status: "@#{u3.nickname} reply from u2 to u3",
2332 in_reply_to_status_id: a3.id,
2333 visibility: "private"
2336 {:ok, a4} = CommonAPI.post(u4, %{status: "Status", visibility: "private"})
2339 CommonAPI.post(u1, %{
2340 status: "@#{u4.nickname} reply from u1 to u4",
2341 in_reply_to_status_id: a4.id,
2342 visibility: "private"
2346 users: %{u1: u1, u2: u2, u3: u3, u4: u4},
2347 activities: %{a1: a1.id, a2: a2.id, a3: a3.id, a4: a4.id},
2348 u1: %{r1: r1_1.id, r2: r1_2.id, r3: r1_3.id},
2349 u2: %{r1: r2_1.id, r2: r2_2.id},
2350 u3: %{r1: r3_1.id, r2: r3_2.id},
2354 describe "maybe_update_follow_information/1" do
2356 clear_config([:instance, :external_user_synchronization], true)
2360 ap_id: "https://gensokyo.2hu/users/raymoo",
2361 following_address: "https://gensokyo.2hu/users/following",
2362 follower_address: "https://gensokyo.2hu/users/followers",
2369 test "logs an error when it can't fetch the info", %{user: user} do
2370 assert capture_log(fn ->
2371 ActivityPub.maybe_update_follow_information(user)
2372 end) =~ "Follower/Following counter update for #{user.ap_id} failed"
2375 test "just returns the input if the user type is Application", %{
2380 |> Map.put(:type, "Application")
2382 refute capture_log(fn ->
2383 assert ^user = ActivityPub.maybe_update_follow_information(user)
2384 end) =~ "Follower/Following counter update for #{user.ap_id} failed"
2387 test "it just returns the input if the user has no following/follower addresses", %{
2392 |> Map.put(:following_address, nil)
2393 |> Map.put(:follower_address, nil)
2395 refute capture_log(fn ->
2396 assert ^user = ActivityPub.maybe_update_follow_information(user)
2397 end) =~ "Follower/Following counter update for #{user.ap_id} failed"
2401 describe "global activity expiration" do
2402 test "creates an activity expiration for local Create activities" do
2403 clear_config([:mrf, :policies], Pleroma.Web.ActivityPub.MRF.ActivityExpirationPolicy)
2405 {:ok, activity} = ActivityBuilder.insert(%{"type" => "Create", "context" => "3hu"})
2406 {:ok, follow} = ActivityBuilder.insert(%{"type" => "Follow", "context" => "3hu"})
2409 worker: Pleroma.Workers.PurgeExpiredActivity,
2410 args: %{activity_id: activity.id},
2412 activity.inserted_at
2413 |> DateTime.from_naive!("Etc/UTC")
2414 |> Timex.shift(days: 365)
2418 worker: Pleroma.Workers.PurgeExpiredActivity,
2419 args: %{activity_id: follow.id}
2424 describe "handling of clashing nicknames" do
2425 test "renames an existing user with a clashing nickname and a different ap id" do
2430 nickname: "admin@mastodon.example.org",
2431 ap_id: "http://mastodon.example.org/users/harinezumigari"
2435 nickname: orig_user.nickname,
2436 ap_id: orig_user.ap_id <> "part_2"
2438 |> ActivityPub.maybe_handle_clashing_nickname()
2440 user = User.get_by_id(orig_user.id)
2442 assert user.nickname == "#{orig_user.id}.admin@mastodon.example.org"
2445 test "does nothing with a clashing nickname and the same ap id" do
2450 nickname: "admin@mastodon.example.org",
2451 ap_id: "http://mastodon.example.org/users/harinezumigari"
2455 nickname: orig_user.nickname,
2456 ap_id: orig_user.ap_id
2458 |> ActivityPub.maybe_handle_clashing_nickname()
2460 user = User.get_by_id(orig_user.id)
2462 assert user.nickname == orig_user.nickname
2466 describe "reply filtering" do
2467 test "`following` still contains announcements by friends" do
2468 user = insert(:user)
2469 followed = insert(:user)
2470 not_followed = insert(:user)
2472 User.follow(user, followed)
2474 {:ok, followed_post} = CommonAPI.post(followed, %{status: "Hello"})
2476 {:ok, not_followed_to_followed} =
2477 CommonAPI.post(not_followed, %{
2478 status: "Also hello",
2479 in_reply_to_status_id: followed_post.id
2482 {:ok, retoot} = CommonAPI.repeat(not_followed_to_followed.id, followed)
2486 |> Map.put(:type, ["Create", "Announce"])
2487 |> Map.put(:blocking_user, user)
2488 |> Map.put(:muting_user, user)
2489 |> Map.put(:reply_filtering_user, user)
2490 |> Map.put(:reply_visibility, "following")
2491 |> Map.put(:announce_filtering_user, user)
2492 |> Map.put(:user, user)
2495 [user.ap_id | User.following(user)]
2496 |> ActivityPub.fetch_activities(params)
2498 followed_post_id = followed_post.id
2499 retoot_id = retoot.id
2501 assert [%{id: ^followed_post_id}, %{id: ^retoot_id}] = activities
2503 assert length(activities) == 2
2506 # This test is skipped because, while this is the desired behavior,
2507 # there seems to be no good way to achieve it with the method that
2508 # we currently use for detecting to who a reply is directed.
2509 # This is a TODO and should be fixed by a later rewrite of the code
2512 test "`following` still contains self-replies by friends" do
2513 user = insert(:user)
2514 followed = insert(:user)
2515 not_followed = insert(:user)
2517 User.follow(user, followed)
2519 {:ok, followed_post} = CommonAPI.post(followed, %{status: "Hello"})
2520 {:ok, not_followed_post} = CommonAPI.post(not_followed, %{status: "Also hello"})
2522 {:ok, _followed_to_not_followed} =
2523 CommonAPI.post(followed, %{status: "sup", in_reply_to_status_id: not_followed_post.id})
2525 {:ok, _followed_self_reply} =
2526 CommonAPI.post(followed, %{status: "Also cofe", in_reply_to_status_id: followed_post.id})
2530 |> Map.put(:type, ["Create", "Announce"])
2531 |> Map.put(:blocking_user, user)
2532 |> Map.put(:muting_user, user)
2533 |> Map.put(:reply_filtering_user, user)
2534 |> Map.put(:reply_visibility, "following")
2535 |> Map.put(:announce_filtering_user, user)
2536 |> Map.put(:user, user)
2539 [user.ap_id | User.following(user)]
2540 |> ActivityPub.fetch_activities(params)
2542 assert length(activities) == 2
2546 test "allow fetching of accounts with an empty string name field" do
2548 %{method: :get, url: "https://princess.cat/users/mewmew"} ->
2549 file = File.read!("test/fixtures/mewmew_no_name.json")
2550 %Tesla.Env{status: 200, body: file, headers: HttpRequestMock.activitypub_object_headers()}
2553 {:ok, user} = ActivityPub.make_user_from_ap_id("https://princess.cat/users/mewmew")
2554 assert user.name == " "